Spec URL: https://zdohnal.fedorapeople.org/braille-printer-app/braille-printer-app.spec SRPM URL: https://zdohnal.fedorapeople.org/braille-printer-app/braille-printer-app-2.0b0%5e7c80811050-1.fc39.src.rpm Description: Braille printer application contains Braille drivers, which were in cups-filters 1.x but moved into a separate project in cups-filters 2.x Fedora Account System Username: zdohnal
Copr build: https://copr.fedorainfracloud.org/coprs/build/5521027 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169277-braille-printer-app/fedora-rawhide-x86_64/05521027-braille-printer-app/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Issues from fedora-review: braille-printer-app.x86_64: W: package-with-huge-docs 71% braille-printer-app.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/cups-brf 700 braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf 700 braille-printer-app.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib/cups/backend/cups-brf braille-printer-app.spec:118: W: macro-in-comment %license braille-printer-app.x86_64: W: incoherent-version-in-changelog 2.0b0^9304787c07-1 ['2.0b0^1b63bd1af1-1.fc39', '2.0b0^1b63bd1af1-1']
Hi Benson, thank you for checking the output! (In reply to Benson Muite from comment #2) > Issues from fedora-review: > > braille-printer-app.x86_64: W: package-with-huge-docs 71% I've removed several files from documentation dir, since it wasn't worthy of shipping them separately. > braille-printer-app.x86_64: E: non-standard-executable-perm > /usr/lib/cups/backend/cups-brf 700 > braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf > 700 This is required by cupsd, which starts the backend (root is in cupsd System Groups - groups of users which are capable of printing, and due possible Kerberos setups) and cups-brf itself switches to the user who issued printing, so it needs root privileges to switch into user. The backend is not meant to be read, be written to by or executed by other user than root, so the permissions are OK. > braille-printer-app.x86_64: E: missing-call-to-setgroups-before-setuid > /usr/lib/cups/backend/cups-brf Sent a fix upstream https://github.com/OpenPrinting/braille-printer-app/pull/4 > braille-printer-app.spec:118: W: macro-in-comment %license > braille-printer-app.x86_64: W: incoherent-version-in-changelog > 2.0b0^9304787c07-1 ['2.0b0^1b63bd1af1-1.fc39', '2.0b0^1b63bd1af1-1'] Fixed in spec file. New versions are uploaded to previous locations on fedorapeople.org.
Benson Muite, are you taken this for review?
Yes.
Thanks, Benson, the latest versions should be now uploaded.
I've found out I've required the newest cups-filters, which is not needed - fixed and uploaded new versions.
Waiting for the review of the newest changes.
FTR this review is part of the announced Fedora change - https://bugzilla.redhat.com/show_bug.cgi?id=2166687 - where is a deadline Feb 21st. It would be great if the review was finished tomorrow to be on track with the change and have spare time in case some regressions are discovered.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_file_permissions ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2 Apache License 2.0", "*No copyright* Apache License 2.0", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "Apache License 2.0", "FSF All Permissive License". 12 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/braille-printer-app/2169277-braille- printer-app/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/cups/braille(cups- filters-braille) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: braille-printer-app-2.0b0^7c80811050-1.fc39.x86_64.rpm braille-printer-app-debuginfo-2.0b0^7c80811050-1.fc39.x86_64.rpm braille-printer-app-debugsource-2.0b0^7c80811050-1.fc39.x86_64.rpm braille-printer-app-2.0b0^7c80811050-1.fc39.src.rpm ============================================ rpmlint session starts =========================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa7c4rvze')] checks: 31, packages: 4 braille-printer-app.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/cups-brf 700 braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf 700 ============= 4 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 1.3 s ============ Rpmlint (debuginfo) ------------------- Checking: braille-printer-app-debuginfo-2.0b0^7c80811050-1.fc39.x86_64.rpm ============================================ rpmlint session starts =========================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpg_3fh147')] checks: 31, packages: 1 ============= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ============ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 braille-printer-app.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/cups-brf 700 braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf 700 3 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 1.8 s Source checksums ---------------- https://github.com/OpenPrinting/braille-printer-app/archive/7c80811/braille-printer-app-7c80811050bb02377b2cb274a20dc54baee7f078.tar.gz : CHECKSUM(SHA256) this package : 1e4ae40f3953394b4bedc2d07319f153933e867b98dcf2fc8180cd4482bd8d76 CHECKSUM(SHA256) upstream package : 1e4ae40f3953394b4bedc2d07319f153933e867b98dcf2fc8180cd4482bd8d76 Requires -------- braille-printer-app (rpmlib, GLIBC filtered): /usr/bin/bash ImageMagick cups cups-filesystem cups-filters libc.so.6()(64bit) liblouisutdml-utils poppler-utils rtld(GNU_HASH) unzip braille-printer-app-debuginfo (rpmlib, GLIBC filtered): braille-printer-app-debugsource (rpmlib, GLIBC filtered): Provides -------- braille-printer-app: braille-printer-app braille-printer-app(x86-64) cups-filters-braille braille-printer-app-debuginfo: braille-printer-app-debuginfo braille-printer-app-debuginfo(x86-64) debuginfo(build-id) braille-printer-app-debugsource: braille-printer-app-debugsource braille-printer-app-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: braille-printer- app-7c80811050bb02377b2cb274a20dc54baee7f078/configure.ac:58 Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2169277 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, SugarActivity, Ocaml, Ruby, R, Haskell, Java, Perl, fonts, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Freedots https://github.com/mlang/freedots is not yet packaged, but could add extra functionality b) Can BuildRequires: liblouis-devel be added, probably helpful for functionality c) Is git-core required? Perhaps remove -S git from the spec file? See: https://download.copr.fedorainfracloud.org/results/fed500/braille-printer-app/fedora-rawhide-x86_64/05533116-braille-printer-app/braille-printer-app.spec d) Check if need it to build on CentOS, maybe some changes are needed: https://copr.fedorainfracloud.org/coprs/fed500/braille-printer-app/build/5533116/ e) Could tests be added, for example, from the README: /usr/sbin/cupsfilter -m application/vnd.cups-brf -p /etc/cups/ppd/yourprinter.ppd yourdocument.txt > ~/test.brf /usr/sbin/cupsfilter -m image/vnd.cups-ubrl -p /etc/cups/ppd/yourprinter.ppd yourimage.png > ~/test.ubrl
(In reply to Benson Muite from comment #10) > Issues: > ======= > - Permissions on files are set properly. > Note: See rpmlint output > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_file_permissions > Explained above - the backend has to be run as root. I tested permissions 744, but rpmlint still complained. Fortunately we have a check for whether the binary is run under root, and if not, it exits, so I can change it - though it is useless. > Generic: > [!]: Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools Fixed upstream - I've rebased the package. > [x]: Rpmlint is run on debuginfo package(s). > Note: No rpmlint messages. > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > [x]: Spec file according to URL is the same as in SRPM. > > > > Comments: > a) Freedots https://github.com/mlang/freedots is not yet packaged, but could > add extra functionality I focused on having supported some basic file formats - in case someone is willing to package freedots and maintain it, I can add Recommends to braille-printer-app (I have some memory of it being in Fedora in the past, but was dropped due Java deps iirc). But thanks to that I found out converting musicxml files won't work without it (thought lou_translate does the trick), so I'll remove its filter for now. > b) Can > BuildRequires: liblouis-devel > be added, probably helpful for functionality AFAIK liblouis-devel provides only shared library and the only files which are compiled is cups-brf backend and ubrlto4dot driver, which doesn't use any function from liblouis-devel. Which functionality did you see in braille-printer-app which can be provided by the library? > c) Is git-core required? Perhaps remove -S git from the spec file? See: > https://download.copr.fedorainfracloud.org/results/fed500/braille-printer- > app/fedora-rawhide-x86_64/05533116-braille-printer-app/braille-printer-app. > spec Creating simple git repo in source is a neat feature when working with extracted source tarball - easier to create patches. I'm not going to remove the build dependency. > d) Check if need it to build on CentOS, maybe some changes are needed: > https://copr.fedorainfracloud.org/coprs/fed500/braille-printer-app/build/ > 5533116/ I don't plan to put the package to CentOS Stream, since the list of dependencies is quite long and some packages aren't in CentOS Stream. If someone wants to make it available in EPEL for CentOS Stream 8/9 and has a packager rights, I can make him/her a co-maintainer of such branch. > e) Could tests be added, for example, from the README: > /usr/sbin/cupsfilter -m application/vnd.cups-brf -p > /etc/cups/ppd/yourprinter.ppd yourdocument.txt > ~/test.brf > /usr/sbin/cupsfilter -m image/vnd.cups-ubrl -p /etc/cups/ppd/yourprinter.ppd > yourimage.png > ~/test.ubrl This would need a PPD driver, running cupsd and a document in chroot, which is IMO easier to solve in Fedora CI - I'm planning to create a name space at src.fedoraproject.org/tests namespace and move braille sanity test we have in cups-filters. I have uploaded the newest changes, would you mind checking them?
b) Without liblouis-devel buildlog contains: filter/liblouis1.defs.gen > filter/liblouis1.defs grep: /usr/share/liblouis/tables/*.utb: No such file or directory grep: /usr/share/liblouis/tables/*.utb: No such file or directory grep: /usr/share/liblouis/tables/*.ctb: No such file or directory grep: /usr/share/liblouis/tables/*.ctb: No such file or directory Unclear if this affects the build though. d) The spec file contains: # remove once CentOS Stream 10 is released Obsoletes: cups-filters-braille < 2.0 # remove once CentOS Stream 10 is released Provides: cups-filters-braille = %{version}-%{release} but, this does not affect Fedora.
(In reply to Benson Muite from comment #12) > b) Without liblouis-devel buildlog contains: > filter/liblouis1.defs.gen > filter/liblouis1.defs > grep: /usr/share/liblouis/tables/*.utb: No such file or directory > grep: /usr/share/liblouis/tables/*.utb: No such file or directory > grep: /usr/share/liblouis/tables/*.ctb: No such file or directory > grep: /usr/share/liblouis/tables/*.ctb: No such file or directory > > Unclear if this affects the build though. Aha, good catch! Those files are actually from liblouis library itself, but since liblouis-devel requires it, the library is brought with it. Those files are used for generating more braille drivers definitions, so if it had been missing, some options would have not been available when Braille drivers was generated during runtime. I've added BuildRequires: liblouis directly, since we don't need header files from liblouis-devel. > > > d) The spec file contains: > # remove once CentOS Stream 10 is released > Obsoletes: cups-filters-braille < 2.0 > > # remove once CentOS Stream 10 is released > Provides: cups-filters-braille = %{version}-%{release} > > but, this does not affect Fedora. Thanks, that's my bad habit during adding Provides/Conflicts/Obsoletes tags - I automatically think about migrations in CentOS Stream, but forgot about the fact the original subpackage is not in CentOS Stream 9 :) - I rewrote the comment to mention F39 EOL. The newest files are uploaded.
Ok, checking spec: https://zdohnal.fedorapeople.org/braille-printer-app/braille-printer-app.spec srpm: https://zdohnal.fedorapeople.org/braille-printer-app/braille-printer-app-2.0b0%5e386eea385f-1.fc39.src.rpm
Testing the following: $ echo "An example sentence" > test.txt $ lpadmin -p ubrl -v cups-brf:/ -m drv:///generic-ubrl.drv/gen-ubrl.ppd $ lpadmin -p ubrl -E $ lp -d ubrl test.txt $ cat $HOME/BRF/*.brf $ rm $HOME/BRF/*.brf $ lpadmin -p brf -v cups-brf:/ -m drv:///generic-brf.drv/gen-brf.ppd $ lpadmin -p brf -E $ lp -d ubrl test.txt $ cat $HOME/BRF/*.brf $ rm $HOME/BRF/*.brf If gutenprint is installed, one can get a timeout when adding printers: https://9to5answer.com/cups-adding-printer-fails-with-quot-unable-to-get-list-of-printer-drivers-success-quot
(In reply to Benson Muite from comment #15) > If gutenprint is installed, one can get a timeout when adding printers: > https://9to5answer.com/cups-adding-printer-fails-with-quot-unable-to-get- > list-of-printer-drivers-success-quot Have you been able to reproduce the issue? I've installed all foomatic and gutenprint packages and I wasn't able to get the error either via CLI or in CUPS Web Interface. Additionally, gutenprint is not shipping IJS for about 6 years. The error which the page is talking about can happen due various reasons - cupsd has already reached the max number of clients or max number of connections waiting in queue for IPP port, cupsd can't answer within time limit due being in other operations (cupsd is one-threaded program with one exception of generating driverless queue) or cups-driverd, the binary which is spawned for getting the drivers, is not able to get the answer within the limit. To list drivers cups-driverd runs binaries which are in /usr/lib/cups/driver and reads all files in /usr/share/cups/drv and /usr/share/cups/models - braille-printer-app does not have any driver binary and has only four files in /usr/share/cups/drv: /usr/share/cups/drv/generic-brf.drv /usr/share/cups/drv/generic-ubrl.drv /usr/share/cups/drv/indexv3.drv /usr/share/cups/drv/indexv4.drv which provides only several driver definitions (from lpinfo -m): drv:///generic-brf.drv/gen-brf.ppd Generic Braille embosser, 1.0 drv:///generic-ubrl.drv/gen-ubrl.ppd Generic UBRL generator, 1.0 drv:///indexv3.drv/i4waves3.ppd Index 4-Waves PRO, 1.0 drv:///indexv3.drv/i4x4pro3.ppd Index 4x4 PRO V3, 1.0 drv:///indexv3.drv/ibasicd3.ppd Index Basic-D V3, 1.0 drv:///indexv4.drv/ibasicd4.ppd Index Basic-D V4/V5, 1.0 drv:///indexv3.drv/ibasics3.ppd Index Basic-S V3, 1.0 drv:///indexv4.drv/ibasics4.ppd Index Basic-S V4/V5, 1.0 drv:///indexv4.drv/ibrlbox4.ppd Index Braille Box V4/V5, 1.0 drv:///indexv3.drv/ieveres3.ppd Index Everest-D V3, 1.0 drv:///indexv4.drv/ieveres4.ppd Index Everest-D V4/V5, 1.0 Usually the error with 'lpinfo -m' is got via binaries in /usr/lib/cups/driver, reading files in /usr/share/cups/drv and /usr/share/cups/models doesn't take that much time and braille-printer-app doesn't bring that much drivers to trigger it. On the top of that, braille-printer-app will be migrated to an actual printer application, so it won't influence 'lpinfo -m' at all, and if someone hits the driverd timeout in the meantime, Fedora cups has a downstream patch for driverd time limit already, so the limit can be raised. Either way, it is a possible CUPS related situation and not braille-printer-app due reasons explained above, it shouldn't block braille-printer-app review. It would be great if you set review+ , I don't see an issue which should prevent it on braille-printer-app's side.
Installed this on a rawhide VM $ sudo dnf update $ sudo dnf install wget $ wget https://download.copr.fedorainfracloud.org/results/fed500/braille-printer-app/fedora-rawhide-aarch64/05537922-braille-printer-app/braille-printer-app-2.0b0%5E386eea385f-1.fc39.aarch64.rpm $ sudo dnf install ./'braille-printer-app-2.0b0^386eea385f-1.fc39.aarch64.rpm' $ echo "An example sentence" > test.txt $ sudo systemctl enable cups $ sudo systemctl start cups $ lpadmin -p ubrl -v cups-brf:/ -m drv:///generic-ubrl.drv/gen-ubrl.ppd $ lpadmin -p ubrl -E $ lp -d ubrl test.txt lp: Unsupported document-format "text/plain". $ lpadmin -p brf -v cups-brf:/ -m drv:///generic-brf.drv/gen-brf.ppd $ lpadmin -p brf -E $ lp -d brf test.txt $ lpstat -o brf-1 fedora 1024 Sat 18 Feb 2023 11:20:04 AM UTC JOB DOES NOT COMPLETE $ sudo /usr/sbin/cupsfilter -m application/vnd.cups-brf -p /etc/cups/ppd/brf.ppd test.txt > ~/test.brf $ sudo /usr/sbin/cupsfilter -m application/vnd.cups-brf -p /etc/cups/ppd/ubrl.ppd test.txt > ~/test.ubrl Using sudo on /usr/sbin/cupsfilter produces output. However lp -d seems not to work. Probably an error in my setup, and not a blocker, but let me know if have any suggestions.
(In reply to Benson Muite from comment #17) > Installed this on a rawhide VM > > $ sudo dnf update > $ sudo dnf install wget > $ wget > https://download.copr.fedorainfracloud.org/results/fed500/braille-printer- > app/fedora-rawhide-aarch64/05537922-braille-printer-app/braille-printer-app- > 2.0b0%5E386eea385f-1.fc39.aarch64.rpm > $ sudo dnf install > ./'braille-printer-app-2.0b0^386eea385f-1.fc39.aarch64.rpm' > $ echo "An example sentence" > test.txt > $ sudo systemctl enable cups > $ sudo systemctl start cups > $ lpadmin -p ubrl -v cups-brf:/ -m drv:///generic-ubrl.drv/gen-ubrl.ppd > $ lpadmin -p ubrl -E > $ lp -d ubrl test.txt > lp: Unsupported document-format "text/plain". That seems to be expected based on provided braille.convs - there is no conversion defined for text/plain to cups-ubrl, only for images. I've tested it with /usr/share/cups/ipptool/testfile.jpg.gz (after I applied the fix mentioned further down): $ lp -d ubrl /usr/share/cups/ipptool/testfile.jpg.gz CUPS DEBUG LOG: Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]: [Job 9] Set job-printer-state-message to "Ready", current level=INFO Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]: [Job 9] PID 17521 (/usr/lib/cups/filter/imagetoubrl) exited with no errors. Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]: [Job 9] PID 17522 (/usr/lib/cups/backend/cups-brf) exited with no errors. Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]: ubrl root 9 [19/Feb/2023:04:25:26 -0500] total 0 - localhost testfile.jpg.gz - - Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]: [Job 9] time-at-completed=1676798726 Feb 19 04:25:26 ci-vm-10-0-136-32.hosted.upshift.rdu2.redhat.com cupsd[1939]: [Job 9] Job completed. > $ lpadmin -p brf -v cups-brf:/ -m drv:///generic-brf.drv/gen-brf.ppd > $ lpadmin -p brf -E > $ lp -d brf test.txt > $ lpstat -o > brf-1 fedora 1024 Sat 18 Feb 2023 11:20:04 AM > UTC > JOB DOES NOT COMPLETE > $ sudo /usr/sbin/cupsfilter -m application/vnd.cups-brf -p > /etc/cups/ppd/brf.ppd test.txt > ~/test.brf > $ sudo /usr/sbin/cupsfilter -m application/vnd.cups-brf -p > /etc/cups/ppd/ubrl.ppd test.txt > ~/test.ubrl > > > Using sudo on /usr/sbin/cupsfilter produces output. However lp -d seems not > to work. Probably an error in my setup, and not a blocker, but let me know > if have any suggestions. This is result of wanting to comply with rpmlint against the past experience - it was caused by cups-brf being run as 'lp' user (which is a default user CUPS runs its executables with due security reasons, if permissions allow it) instead of root, so backend automatically failed. I've changed the permissions to 0744, which complies with FPG ("File must be universally readable (and executable if appropriate)" - which isn't in our case for 'group' and 'others' https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions) but rpmlint will complain - but IMHO that's a bug in rpmlint which doesn't match with FPG. Additionally I've found out removing the musicxmltobrf filter causes cupsd to report a missing filter, because braille defines conversions and data type for it - I've written a configure option to disable musicxml support in braille-printer-app and sent upstream - we won't ship a broken filter (due missing FreeDots) if the musicxml support is disabled and CUPS doesn't report missing filter because the braille MIME database was adjusted as well. I've uploaded a new set of spec and srpm - would you mind giving review+ ?
lp -d ubrl /usr/share/cups/ipptool/testfile.jpg.gz and lp -d ubrl test.txt both work on Rawhide. Have not tested with a brailler. Is it worth filing a bug on fedora-review? On Fedora 37, it seems possible to use ubrl on a text file when hplip package is installed. The file is first converted to an image file. Maybe it is possible to reenable this before importing? An example log is below: Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Applying default options... Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Adding start banner page "none". Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Queued on "ubrl" by "fedora". Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Auto-typing file... Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Request file type is text/plain. Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] File of type text/plain queued by "fedora". Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Adding end banner page "none". Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] time-at-processing=1676837066 Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] 4 filters for job: Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] texttopdf (text/plain to application/pdf, cost 32) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] pstotiff (application/pdf to image/tiff, cost 80) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] imagetoubrl (image/tiff to image/vnd.cups-ubrl, cost 70) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] - (image/vnd.cups-ubrl to printer/ubrl, cost 0) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] job-sheets=none,none Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[0]="ubrl" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[1]="11" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[2]="fedora" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[3]="test.txt" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[4]="1" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[5]="finishings=3 number-up=1 print-color-mode=monochrome job-uuid=urn:uuid:cf725edc-4cc4-3732-6fbe-93664b4e4543 job-originating-host-name=localhost date-time-at-creation= date-time-at-processing= time-at-creation=1676837066 time-at-processing=1676837066 document-name-supplied=test.txt" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] argv[6]="/var/spool/cups/d00011-001" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[0]="CUPS_CACHEDIR=/var/cache/cups" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[1]="CUPS_DATADIR=/usr/share/cups" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[2]="CUPS_DOCROOT=/usr/share/cups/www" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[3]="CUPS_REQUESTROOT=/var/spool/cups" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[4]="CUPS_SERVERBIN=/usr/lib/cups" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[5]="CUPS_SERVERROOT=/etc/cups" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[6]="CUPS_STATEDIR=/run/cups" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[7]="HOME=/var/spool/cups/tmp" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[8]="PATH=/usr/lib/cups/filter:/usr/bin:/usr/sbin:/bin:/usr/bin" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[9]="SERVER_ADMIN=root" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[10]="SOFTWARE=CUPS/2.4.2" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[11]="TMPDIR=/var/spool/cups/tmp" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[12]="USER=root" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[13]="CUPS_MAX_MESSAGE=2047" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[14]="CUPS_SERVER=/run/cups/cups.sock" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[15]="CUPS_ENCRYPTION=IfRequested" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[16]="IPP_PORT=631" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[17]="CHARSET=utf-8" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[18]="LANG=en_US.UTF-8" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[19]="PPD=/etc/cups/ppd/ubrl.ppd" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[20]="CONTENT_TYPE=text/plain" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[21]="DEVICE_URI=cups-brf:/" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[22]="PRINTER_INFO=ubrl" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[23]="PRINTER_LOCATION=" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[24]="PRINTER=ubrl" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[25]="PRINTER_STATE_REASONS=none" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[26]="CUPS_FILETYPE=document" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[27]="FINAL_CONTENT_TYPE=image/vnd.cups-ubrl" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] envp[28]="AUTH_I****" Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Started filter /usr/lib/cups/filter/texttopdf (PID 869272) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Started filter /usr/lib/cups/filter/pstotiff (PID 869273) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Started filter /usr/lib/cups/filter/imagetoubrl (PID 869274) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] Started backend /usr/lib/cups/backend/cups-brf (PID 869275) Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] creating directory \"/home/fedora/BRF Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] creating file \"/home/fedora/BRF/test.txt.XXXXXX.brf Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultpage-ranges is \'\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default page-ranges is \'\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultPageSize is \'A4TF\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default PageSize is \'A4TF\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute HWMargins is \'28.34645652771 28.34645652771 28.34645652771 28.34645652771\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] HW margins are 28.34645652771 28.34645652771 28.34645652771 28.34645652771 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultpage-left is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default page-left is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultpage-right is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default page-right is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultpage-top is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default page-top is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultpage-bottom is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default page-bottom is \'15\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] hard margins are left 1000 right 1000 top 1000 bottom 1000 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] graphical margins are left 1000 right 1000 top 1000 bottom 1000 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] printable area is 19000x28480 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultTextDotDistance is \'250\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default TextDotDistance is \'250\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultTextDots is \'6\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default TextDots is \'6\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultLineSpacing is \'500\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default LineSpacing is \'500\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultTopMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default TopMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultTopMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default TopMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultBottomMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default BottomMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultLeftMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default LeftMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultRightMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default RightMargin is \'2\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultGraphicDotDistance is \'200\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default GraphicDotDistance is \'200\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] total graphical: 94x140 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] graphical offset: 0x0 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] rounded graphical top-left corner margin: 1000x1000 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] resulting graphical area: 94x141 Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Liblouis table directory is /usr/share/liblouis/tables Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultLibLouis is \'Locale\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Default LibLouis is \'Locale\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] looking for locale \'en_US\' and grade \'\' Feb 19 23:04:27 localhost.localdomain cupsd[869240]: [Job 11] Page = 594x864; 0,0 to 594,864 Feb 19 23:04:29 localhost.localdomain cupsd[869240]: [Job 11] PID 869272 (/usr/lib/cups/filter/texttopdf) exited with no errors. Feb 19 23:04:30 localhost.localdomain cupsd[869240]: [Job 11] GPL Ghostscript 9.56.1 (2022-04-04) Feb 19 23:04:30 localhost.localdomain cupsd[869240]: [Job 11] Copyright (C) 2022 Artifex Software, Inc. All rights reserved. Feb 19 23:04:30 localhost.localdomain cupsd[869240]: [Job 11] This software is supplied under the GNU AGPLv3 and comes with NO WARRANTY: Feb 19 23:04:30 localhost.localdomain cupsd[869240]: [Job 11] see the file COPYING for details. Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] *** WARNING - you have selected SAFER, indicating you want Ghostscript Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] to execute in a safer environment, but at the same time Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] have selected WRITESYSTEMDICT. Unless you use this option with Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] care and specifically, remember to execute code like: Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] \"systemdict readonly pop\" Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] it is possible that malicious code may be able to evade the Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] limited security offered by the SAFER option. Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] Processing pages 1 through 2. Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] Page 1 Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] Page 2 Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] The following errors were encountered at least once while processing this file: Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] circular reference to indirect object Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] **** This file had errors that were repaired or ignored. Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] **** Please notify the author of the software that produced this Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] **** file that it does not conform to Adobe\'s published PDF Feb 19 23:04:32 localhost.localdomain cupsd[869240]: [Job 11] **** specification. Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultLibLouis2 is \'HyphLocale\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Default LibLouis2 is \'HyphLocale\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultLibLouis3 is \'None\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Default LibLouis3 is \'None\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultLibLouis4 is \'None\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Default LibLouis4 is \'None\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Table1 en_US.tbl Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Table2 hyph_en_US.dic Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Table3 None Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Table4 None Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultNegate is \'False\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Default Negate is \'False\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultRotate is \'90>\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Default Rotate is \'90>\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultmirror is \'False\' Feb 19 23:04:34 localhost.localdomain cupsd[869240]: [Job 11] Default mirror is \'False\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute Defaultfitplot is \'True\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default fitplot is \'True\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultEdge is \'Canny\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default Edge is \'Canny\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultEdgeFactor is \'1\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default EdgeFactor is \'1\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultCannyRadius is \'0\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default CannyRadius is \'0\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultCannySigma is \'1\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default CannySigma is \'1\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultCannyLower is \'10\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default CannyLower is \'10\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Attribute DefaultCannyUpper is \'30\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Default CannyUpper is \'30\' Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Converting image Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Set job-printer-state-message to "Converting image", current level=INFO Feb 19 23:04:35 localhost.localdomain cupsd[869240]: [Job 11] Calling convert -canny 0x1+10%+30% -negate -rotate 90> -page 94x140+0+0 -size 94x141 -resize 94x141 -flatten - ubrl:- from stdin Feb 19 23:04:36 localhost.localdomain cupsd[869240]: [Job 11] PID 869273 (/usr/lib/cups/filter/pstotiff) exited with no errors. Feb 19 23:04:46 localhost.localdomain cupsd[869240]: [Job 11] Ready Feb 19 23:04:46 localhost.localdomain cupsd[869240]: [Job 11] Set job-printer-state-message to "Ready", current level=INFO Feb 19 23:04:46 localhost.localdomain cupsd[869240]: [Job 11] PID 869274 (/usr/lib/cups/filter/imagetoubrl) exited with no errors. Feb 19 23:04:46 localhost.localdomain cupsd[869240]: [Job 11] PID 869275 (/usr/lib/cups/backend/cups-brf) exited with no errors. Feb 19 23:04:46 localhost.localdomain cupsd[869240]: ubrl benson 11 [19/Feb/2023:23:04:46 +0300] total 0 - localhost test.txt - - Feb 19 23:04:46 localhost.localdomain cupsd[869240]: [Job 11] time-at-completed=1676837086 Feb 19 23:04:46 localhost.localdomain cupsd[869240]: [Job 11] Job completed. Feb 19 23:04:47 localhost.localdomain cupsd[869240]: [Job 11] Unloading...
(In reply to Benson Muite from comment #19) > lp -d ubrl /usr/share/cups/ipptool/testfile.jpg.gz > and > lp -d ubrl test.txt > both work on Rawhide. Have not tested with a brailler. > > Is it worth filing a bug on fedora-review? I've filled a bug on rpmlint https://bugzilla.redhat.com/show_bug.cgi?id=2171377 > > On Fedora 37, it seems possible to use ubrl on a text file when hplip > package is installed. The file is first converted to an image file. Maybe it > is possible to reenable this before importing? An example log is below: > > Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] 4 filters for > job: > Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] texttopdf > (text/plain to application/pdf, cost 32) > Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] pstotiff > (application/pdf to image/tiff, cost 80) > Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] imagetoubrl > (image/tiff to image/vnd.cups-ubrl, cost 70) > Feb 19 23:04:26 localhost.localdomain cupsd[869240]: [Job 11] - > (image/vnd.cups-ubrl to printer/ubrl, cost 0) I wouldn't like to add an additional dependency to the app, especially when braille conversion table doesn't mention such a rule, and we have to keep in mind every filter in the chain slows printing a little. On the top of that, hplip ships bunch of HP drivers, which are of no value for braille-printer-app user, and there is a possibility libcupsfilters+cups-filters will provide the conversion. To sum it up I won't add a new dependency because there is no explicit conversion rule which tells us that should be possible in default installation. However I've filed an issue with question about direct conversion support as https://github.com/OpenPrinting/braille-printer-app/issues/7 .
The Pagure repository was created at https://src.fedoraproject.org/rpms/braille-printer-app
FEDORA-2023-3b5412cd52 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3b5412cd52
FEDORA-2023-3b5412cd52 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-689c6807a8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-689c6807a8
FEDORA-2023-689c6807a8 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.