SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05521594-stats-collect/stats-collect.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05521594-stats-collect/stats-collect-1.0.1-1.fc39.src.rpm Description: A tool for collecting and visualising system statistics and telemetry
Copr build: https://copr.fedorainfracloud.org/coprs/build/5521704 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/05521704-stats-collect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file main.js.LICENSE.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License". 27 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/stats-collect/2169357-stats- collect/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/statscollectlibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/collector(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/collector/__pycache__(python3-wult), /usr/lib/python3.11/site-packages/statscollectlibs/defs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/defs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/deploylibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/deploylibs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/helperlibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/helperlibs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/sysinfo(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/sysinfo/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/turbostat(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/turbostat/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/parsers(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/parsers/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/rawresultlibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/rawresultlibs/__pycache__(python3-wult), /usr/lib/python3.11/site-packages/statscollecttools(python3-wult), /usr/lib/python3.11/site- packages/statscollecttools/__pycache__(python3-wult) [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: stats-collect-1.0.1-1.fc39.noarch.rpm stats-collect-1.0.1-1.fc39.src.rpm =============================== rpmlint session starts ============================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps0vlc882')] checks: 31, packages: 2 stats-collect.noarch: W: no-manual-page-for-binary ipmi-helper stats-collect.noarch: W: no-manual-page-for-binary stc-agent 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 5.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 stats-collect.noarch: W: no-manual-page-for-binary ipmi-helper stats-collect.noarch: W: no-manual-page-for-binary stc-agent 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.7 s Source checksums ---------------- https://github.com/intel/stats-collect/archive/v1.0.1/stats-collect-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 3da62741810955b408cc257db35dab00c7892864b90c45d36fb20bb84ea13e56 CHECKSUM(SHA256) upstream package : 3da62741810955b408cc257db35dab00c7892864b90c45d36fb20bb84ea13e56 Requires -------- stats-collect (rpmlib, GLIBC filtered): (python3.11dist(pepc) < 1.4~~ with python3.11dist(pepc) >= 1.3.13) /usr/bin/python3 python(abi) python3.11dist(colorama) python3.11dist(numpy) python3.11dist(pandas) python3.11dist(plotly) python3.11dist(pyyaml) Provides -------- stats-collect: python3.11dist(stats-collect) python3dist(stats-collect) stats-collect Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2169357 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: C/C++, R, Perl, Ocaml, fonts, Ruby, PHP, Haskell, SugarActivity, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Please add javascript license file b) Can the bundled javascript libraries (shoelace and lit) be built from source? Can they be packaged? See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/ https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ c) Please add CHANGELOG.md and security.md to the documentation d) Not essential for packaging, but possibly upstream can examine reducing the number of dependencies, 2.0GB e) Some of the features seem specific to x86_64, though the package will install anywhere Python runs. Should architecture choices be restricted? f) Can a smoke test be added? For example stats-collect start -o my_stats "ls /usr/bin" stats-collect report -o my_results my_stats
Hello again, thank you for the comments SPEC url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05850854-stats-collect/stats-collect.spec SRPM url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05850854-stats-collect/stats-collect-1.0.3-1.fc39.src.rpm
Created attachment 1959986 [details] The .spec file difference from Copr build 5521704 to 5850867
Copr build: https://copr.fedorainfracloud.org/coprs/build/5850867 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/05850867-stats-collect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
@benson_muite ?
Thanks. Sorry for the delay. Can you add %license js/dist/main.js.LICENSE.txt to the spec file. See https://github.com/intel/stats-collect/blob/main/js/dist/main.js.LICENSE.txt https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/05850867-stats-collect/fedora-review/review.txt lit https://lit.dev/ is not packaged in Fedora and given the changes may be difficult to use if it was. Maybe a comment should be added that it is bundled?
Thank you. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05972276-stats-collect/stats-collect.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/05972276-stats-collect/stats-collect-1.0.3-1.fc39.src.rpm
Created attachment 1967648 [details] The .spec file difference from Copr build 5850867 to 5972451
Copr build: https://copr.fedorainfracloud.org/coprs/build/5972451 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/05972451-stats-collect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License". 55 files have unknown license. Detailed output of licensecheck in /home/fedora/2169357-stats-collect/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/statscollectlibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/collector(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/collector/__pycache__(python3-wult), /usr/lib/python3.11/site-packages/statscollectlibs/defs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/defs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/deploylibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/deploylibs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/helperlibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/helperlibs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/sysinfo(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/sysinfo/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/turbostat(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/htmlreport/tabs/turbostat/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/parsers(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/parsers/__pycache__(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/rawresultlibs(python3-wult), /usr/lib/python3.11/site- packages/statscollectlibs/rawresultlibs/__pycache__(python3-wult), /usr/lib/python3.11/site-packages/statscollecttools(python3-wult), /usr/lib/python3.11/site- packages/statscollecttools/__pycache__(python3-wult), /usr/share/javascript/stats-collect(wult), /usr/share/javascript/stats-collect/js(wult), /usr/share/javascript/stats-collect/js/dist(wult), /usr/share/stats- collect(wult), /usr/share/stats-collect/defs(wult), /usr/share/stats- collect/defs/statscollect(wult), /usr/share/stats- collect/helpers(wult), /usr/share/stats-collect/helpers/stc- agent(wult), /usr/share/stats-collect/js(wult), /usr/share/stats- collect/misc(wult), /usr/share/stats-collect/misc/servedir(wult), /usr/share/stats-collect/misc/servedir/__pycache__(wult) [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: stats-collect-1.0.3-1.fc39.noarch.rpm stats-collect-1.0.3-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmc9iijc0')] checks: 31, packages: 2 stats-collect.noarch: W: no-manual-page-for-binary ipmi-helper stats-collect.noarch: W: no-manual-page-for-binary stc-agent stats-collect.noarch: W: files-duplicate /usr/share/licenses/stats-collect/main.js.LICENSE.txt /usr/share/javascript/stats-collect/js/dist/main.js.LICENSE.txt 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 stats-collect.noarch: W: no-manual-page-for-binary ipmi-helper stats-collect.noarch: W: no-manual-page-for-binary stc-agent stats-collect.noarch: W: files-duplicate /usr/share/licenses/stats-collect/main.js.LICENSE.txt /usr/share/javascript/stats-collect/js/dist/main.js.LICENSE.txt 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.2 s Source checksums ---------------- https://github.com/intel/stats-collect/archive/v1.0.3/stats-collect-1.0.3.tar.gz : CHECKSUM(SHA256) this package : e881b03d7fd77aa2cb131bade22c1d2a870a60ab654cbc9bf34e33e06939e0cd CHECKSUM(SHA256) upstream package : e881b03d7fd77aa2cb131bade22c1d2a870a60ab654cbc9bf34e33e06939e0cd Requires -------- stats-collect (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.11dist(colorama) python3.11dist(numpy) python3.11dist(pandas) python3.11dist(pepc) python3.11dist(plotly) python3.11dist(pyyaml) web-assets-filesystem Provides -------- stats-collect: python3.11dist(stats-collect) python3dist(stats-collect) stats-collect Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2169357 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: SugarActivity, C/C++, R, Haskell, Java, fonts, Ocaml, PHP, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Coments: a) For bundling see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling need to add Provides: bundled(<libname>) = <version> or Provides: bundled(<libname>) b) May also want to mark license.md as a license file c) When installed main.js.LICENSE.txt is duplicated in share/javascript/stats-collect/js/dist/ is this reasonable? d) Wult https://packages.fedoraproject.org/pkgs/wult/wult/ provides binaries ipmi-helper , stats-collect and stc-agent probably these will raise a conflict?
Hello Benson, a: Done b: License.md is already marked by rpm-python-macro c: You asked me too add it before :) d: Yes we knew that just waiting for stats-collect's approval and then we'll release new version wult without those binaries. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/06006624-stats-collect/stats-collect.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/06006624-stats-collect/stats-collect-1.0.3-1.fc39.src.rpm
Created attachment 1969147 [details] The .spec file difference from Copr build 5972451 to 6006722
Copr build: https://copr.fedorainfracloud.org/coprs/build/6006722 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/06006722-stats-collect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks. > a: Done Thanks. > b: License.md is already marked by rpm-python-macro Ok, it is in usr/lib/python3.11/site-packages/stats_collect-1.0.3.dist-info/ > c: You asked me too add it before :) Sorry, review tool indicates preference for the license folder and not in share/javascript/stats-collect/js/dist/ Duplicate seems ok. Please add a license breakdown in the spec file indicating bundled library is also BSD. Can be done on import. > d: Yes we knew that just waiting for stats-collect's approval and then we'll release new version wult without those binaries. Ok. There seems to be some problem with installation: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/06006722-stats-collect/fedora-review/review.txt https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2169357-stats-collect/fedora-rawhide-x86_64/06006722-stats-collect/builder-live.log.gz root.log contains: DEBUG util.py:444: package stats-collect is not installed DEBUG util.py:595: Child return code was: 1 and DEBUG util.py:442: Error: DEBUG util.py:442: Problem: conflicting requests DEBUG util.py:442: - nothing provides wult(x86-64) >= 1.11.21 needed by stats-collect-1.0.3-1.fc39.noarch from @commandline DEBUG util.py:444: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) DEBUG util.py:595: Child return code was: 1 DEBUG util.py:167: kill orphans So I guess will be fixed when Wult is simultaneously updated. Approved.
Thank you Benson SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/06008264-stats-collect/stats-collect.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/06008264-stats-collect/stats-collect-1.0.3-1.fc39.src.rpm
The Pagure repository was created at https://src.fedoraproject.org/rpms/stats-collect