Bug 2169612 - Review request: nqp
Summary: Review request: nqp
Keywords:
Status: CLOSED COMPLETED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vasiliy Glazov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2169611
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-14 04:44 UTC by Felix Wang
Modified: 2023-03-23 14:21 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-03-23 14:21:39 UTC
Type: Bug
Embargoed:
vascom2: fedora-review+


Attachments (Terms of Use)

Comment 1 Vasiliy Glazov 2023-02-14 06:53:58 UTC
1. License name must be changed to Artistic-2.0 according https://docs.fedoraproject.org/en-US/legal/allowed-licenses/

2. Remove -n nqp-%{version} from %autosetup line.

3. make %{?_smp_mflags}
change to
%make_build

4. Need to clarify this files owning:
%dir /usr/share/nqp
/usr/share/nqp/lib/

Because /usr/share/nqp already owned by moarvm.
And you must change /usr/share to %{_datadir}

Comment 2 Felix Wang 2023-02-14 13:10:37 UTC
(In reply to Vasiliy Glazov from comment #1)
> 1. License name must be changed to Artistic-2.0 according
> https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
> 
> 2. Remove -n nqp-%{version} from %autosetup line.
> 
> 3. make %{?_smp_mflags}
> change to
> %make_build
> 
> 4. Need to clarify this files owning:
> %dir /usr/share/nqp
> /usr/share/nqp/lib/
> 
> Because /usr/share/nqp already owned by moarvm.
> And you must change /usr/share to %{_datadir}

Many thanks for your detailed and helpful suggestions. I modified the nqp.spec file as you corrected and upload to my COPR for building.
build: https://copr.fedorainfracloud.org/coprs/topazus/raku/build/5525320/
Spec URL: https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05525320-nqp/nqp.spec
Fedora Review: https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05525320-nqp/fedora-review/review.txt
SRPM URL: https://download.copr.fedorainfracloud.org/results/topazus/raku/fedora-rawhide-x86_64/05525320-nqp/nqp-2022.12-1.fc39.src.rpm

Comment 3 Vasiliy Glazov 2023-02-15 07:29:50 UTC
Please change
%{_datadir}/nqp/lib/profiler/template.html
to
%{_datadir}/nqp/lib/profiler

And post new Spec and SRPM URLs.

Comment 5 Vasiliy Glazov 2023-02-15 10:53:01 UTC
Remove %dir /usr/share/nqp
This directory owned by moarvm.

Comment 6 Vasiliy Glazov 2023-02-15 11:01:52 UTC
And description too long.
You must split it to two lines. Each line must not exceed 80 symbols.

Comment 8 Vasiliy Glazov 2023-02-15 12:37:23 UTC
Approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/nqp
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Artistic License 2.0",
     "BSD 3-Clause License", "*No copyright* Apache License 2.0", "*No
     copyright* Apache License", "*No copyright* [generated file]", "MIT
     License". 670 files have unknown license. Detailed output of
     licensecheck in /home/vascom/2169612-nqp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/nqp, /usr/share/nqp/lib
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/nqp,
     /usr/share/nqp/lib
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 3993600 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nqp-2022.12-1.fc39.x86_64.rpm
          nqp-debuginfo-2022.12-1.fc39.x86_64.rpm
          nqp-debugsource-2022.12-1.fc39.x86_64.rpm
          nqp-2022.12-1.fc39.src.rpm
====================================================================== rpmlint session starts =====================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp7f2wcz2t')]
checks: 31, packages: 4

nqp.x86_64: W: no-manual-page-for-binary nqp
nqp.x86_64: W: no-manual-page-for-binary nqp-m
nqp.x86_64: W: no-documentation
======================================= 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 1.1 s ======================================




Rpmlint (debuginfo)
-------------------
Checking: nqp-debuginfo-2022.12-1.fc39.x86_64.rpm
====================================================================== rpmlint session starts =====================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpp59d37kr')]
checks: 31, packages: 1

======================================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s ======================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

nqp.x86_64: W: no-manual-page-for-binary nqp
nqp.x86_64: W: no-manual-page-for-binary nqp-m
nqp.x86_64: W: no-documentation
 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 1.2 s 



Source checksums
----------------
https://github.com/Raku/nqp/releases/download/2022.12/nqp-2022.12.tar.gz :
  CHECKSUM(SHA256) this package     : e5f7d13a0a4855be420c071cdaf004c7abd0984977863bd2828a5cf7de8459ad
  CHECKSUM(SHA256) upstream package : e5f7d13a0a4855be420c071cdaf004c7abd0984977863bd2828a5cf7de8459ad


Requires
--------
nqp (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libmoar.so()(64bit)
    moarvm
    rtld(GNU_HASH)

nqp-debuginfo (rpmlib, GLIBC filtered):

nqp-debugsource (rpmlib, GLIBC filtered):



Provides
--------
nqp:
    nqp
    nqp(x86-64)

nqp-debuginfo:
    debuginfo(build-id)
    nqp-debuginfo
    nqp-debuginfo(x86-64)

nqp-debugsource:
    nqp-debugsource
    nqp-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2169612 -L 2169611-moarvm/results/dd/
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Perl, Ocaml, SugarActivity, Java, fonts, Python, R, Haskell, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /home/vascom/2169611-moarvm/results/dd/moarvm-devel-2022.12-1.fc39.x86_64.rpm
    /home/vascom/2169611-moarvm/results/dd/moarvm-2022.12-1.fc39.x86_64.rpm


Note You need to log in before you can comment on or make changes to this bug.