Bug 2169641 - Syntax highlight for sh files broken
Summary: Syntax highlight for sh files broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vim
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karsten
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2170704 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-14 07:39 UTC by Villy Kruse
Modified: 2023-02-18 01:27 UTC (History)
6 users (show)

Fixed In Version: vim-9.0.1307-1.fc37 vim-9.0.1307-1.fc36
Clone Of:
Environment:
Last Closed: 2023-02-17 18:16:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Image showing the file /usr/bin/vimdot with broken highlight (75.43 KB, image/png)
2023-02-14 07:39 UTC, Villy Kruse
no flags Details
The same file after replacing the file /usr/share/vim/vim90/syntax/sh.vim from previous version (72.03 KB, image/png)
2023-02-14 07:42 UTC, Villy Kruse
no flags Details

Description Villy Kruse 2023-02-14 07:39:40 UTC
Created attachment 1944012 [details]
Image showing the file /usr/bin/vimdot with broken highlight

Description of problem:

After updating to vim-common-9.0.1293-1.fc37.x86_64 the syntax highlithting of sh files is broken.  It worked on previous version vim-common-2:9.0.1262-1.fc37.x86_64

Version-Release number of selected component (if applicable):

vim-common-9.0.1293-1.fc37.x86_64

How reproducible:

Always

Steps to Reproduce:
1. vim /usr/bin/vimdot
2.
3.

Actual results:

See image

Expected results:


Additional info:

Comment 1 Villy Kruse 2023-02-14 07:42:16 UTC
Created attachment 1944014 [details]
The same file after replacing the file /usr/share/vim/vim90/syntax/sh.vim from previous version

Extracting the file /usr/share/vim/vim90/syntax/sh.vim from the previous version fixes the problem

Comment 2 Zdenek Dohnal 2023-02-14 10:38:15 UTC
Hi Villy,

thank you for reporting the issue and the investigation!

I was able to find which specific change in sh.vim caused it and reverted it in https://github.com/vim/vim/pull/11991 . Once it is accepted, I will build a new version.

Comment 3 Zdenek Dohnal 2023-02-14 11:20:04 UTC
Actually it is already fixed in plugin, but hasn't propagated yet to Vim project, I'll backport it.

Comment 4 Zdenek Dohnal 2023-02-14 11:20:32 UTC
The original issue https://github.com/vim/vim/issues/11937

Comment 5 Fedora Update System 2023-02-14 12:49:03 UTC
FEDORA-2023-ac5432434c has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ac5432434c

Comment 6 Fedora Update System 2023-02-14 14:15:07 UTC
FEDORA-2023-93fb5b08eb has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-93fb5b08eb

Comment 7 Fedora Update System 2023-02-15 01:34:44 UTC
FEDORA-2023-ac5432434c has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-ac5432434c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-ac5432434c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-02-15 02:26:41 UTC
FEDORA-2023-93fb5b08eb has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-93fb5b08eb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-93fb5b08eb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Zdenek Dohnal 2023-02-17 07:42:04 UTC
*** Bug 2170704 has been marked as a duplicate of this bug. ***

Comment 10 Fedora Update System 2023-02-17 18:16:36 UTC
FEDORA-2023-ac5432434c has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-02-18 01:27:40 UTC
FEDORA-2023-93fb5b08eb has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.