Bug 2170204 - Review Request: rust2rpm - Generate RPM spec files for Rust crates
Summary: Review Request: rust2rpm - Generate RPM spec files for Rust crates
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL: https://pagure.io/fedora-rust/rust2rpm
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-15 20:44 UTC by Fabio Valentini
Modified: 2023-02-16 18:48 UTC (History)
2 users (show)

Fixed In Version: rust2rpm-24.0.1-1.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-16 18:48:15 UTC
Type: ---
Embargoed:
mhroncok: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-02-15 20:44:54 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust2rpm.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust2rpm-24.0.0-1.fc37.src.rpm

Description:
rust2rpm is a tool that automates the generation of RPM spec files for
Rust crates.

Fedora Account System Username: decathorpe

Note: This package is split off from rust-packaging to decouple development and packaging of a couple of unrelated components. When building this package without the required changes and update for rust-packaging, it will fail to install due to a missing dependency on the new "cargo-rpm-macros" subpackage of rust-packaging.

Comment 1 Jakub Kadlčík 2023-02-15 20:48:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5529723
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2170204-rust2rpm/fedora-rawhide-x86_64/05529723-rust2rpm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-02-15 20:49:47 UTC
(The COPR build failed because cargo2rpm 0.1.1 is available in rawhide koji, but not from published rawhide repos yet.)

Comment 3 Miro Hrončok 2023-02-16 11:37:15 UTC
Spec sanity:

> Provides:       python3-rust2rpm = %{version}-%{release}
 ---> %py_provides python3-rust2rpm

> Provides:       python3-rust2rpm-core = %{version}-%{release}
 ---> %py_provides python3-rust2rpm-core

This ensures python3.11-rust2rpm etc. is also provided.


> %autosetup -n rust2rpm-%{version} -p1
rust2rpm-%{version} is the default name, maybe consider committing it



> %pyproject_buildrequires -t
 ---> %pyproject_buildrequires %{?with_check:-t}


> %check
> %if %{with check}
> %tox
> %endif

Consider adding unconditional %pyproject_check_import to %check (requires %pyproject_save_files).
If (and only if) you don't add it, please hide the entire %check section in the conditional, to avoid empty %check ("package has %check" will be true, but not tests will run).



> %files ...

Consider using -f %{pyproject_files} here.

Comment 4 Miro Hrončok 2023-02-16 11:48:58 UTC
s/maybe consider committing it/maybe consider omitting it/

Comment 5 Fabio Valentini 2023-02-16 12:37:03 UTC
All good points, thanks! It shows that I haven't done much Python packaging lately ...

URLs are the same, here's a diff:
https://github.com/decathorpe/rust-packaging-ng/commit/c8c6a8f02e06ad6b1f77bdf9efa613fec9a3cf7f

In addition to your changes, I also removed the Provides for rust2pm-core, which is actually no longer provided, but should only be obsoleted.

Comment 6 Miro Hrončok 2023-02-16 12:51:22 UTC
I worry the manual `%license LICENSE` thing is now redundant, but I have not built the package to verify.

Comment 7 Miro Hrončok 2023-02-16 12:52:00 UTC
OCD comment: The check bcond now disables tests, not check :)

Comment 8 Fabio Valentini 2023-02-16 12:54:55 UTC
(In reply to Miro Hrončok from comment #6)
> I worry the manual `%license LICENSE` thing is now redundant, but I have not
> built the package to verify.

Indeed, the LICENSE file is now installed in both the dist-info directory *and* %_licensedir.
I'll remove the "%license LICENSE" statement.

(In reply to Miro Hrončok from comment #7)
> OCD comment: The check bcond now disables tests, not check :)

That is true, however, it is consistent with all other Rust packages. So if we ever need to bootstrap something, "--without check" is the canonical way to do that.

Comment 9 Fabio Valentini 2023-02-16 13:01:20 UTC
Confirmed:

$ rpm -q --licensefiles rust2rpm-24.0.0-1.fc39.noarch.rpm 
/usr/lib/python3.11/site-packages/rust2rpm-24.0.0.dist-info/LICENSE

Unless you want to see a new version of the spec file with the "%license LICENSE" file removed, I'd just apply that change before importing the package.

Comment 10 Miro Hrončok 2023-02-16 13:40:45 UTC
I get this even with the Koji repo. Where do I get it, is there a side tag or copr?

Error: 
 Problem: conflicting requests
  - nothing provides cargo-rpm-macros needed by rust2rpm-24.0.0-1.fc39.noarch

Comment 11 Fabio Valentini 2023-02-16 13:54:28 UTC
Oh, I forgot about that. All components are here in COPR:
https://copr.fedorainfracloud.org/coprs/decathorpe/rust-packaging-ng/monitor/

I've put up a PR for the changes to the rust-packaging package:
https://src.fedoraproject.org/rpms/rust-packaging/pull-request/5

Comment 12 Miro Hrončok 2023-02-16 16:52:23 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Package APPROVED.

Conditionals:
=============
- https://src.fedoraproject.org/rpms/rust-packaging/pull-request/5 to be shipped together with this
- duplicate %license to be removed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "*No copyright* MIT
     License". 37 files have unknown license.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.11/site-
     packages/rust2rpm(rust2rpm, python3-rust2rpm),
     /usr/lib/python3.11/site-packages/rust2rpm/__pycache__(rust2rpm,
     python3-rust2rpm), /usr/lib/python3.11/site-
     packages/rust2rpm/templates(rust2rpm, python3-rust2rpm)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust2rpm-24.0.0-1.fc39.noarch.rpm
          rust2rpm-24.0.0-1.fc39.src.rpm
============================================= rpmlint session starts ============================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpdqz2j9z3')]
checks: 31, packages: 2

rust2rpm.noarch: W: obsolete-not-provided cargo-inspector
rust2rpm.noarch: W: obsolete-not-provided python3-rust2rpm-core
rust2rpm.noarch: W: no-manual-page-for-binary rust2rpm
rust2rpm.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/rust2rpm/templates/plain-changelog.spec.inc /usr/lib/python3.11/site-packages/rust2rpm/templates/fedora-changelog.spec.inc:/usr/lib/python3.11/site-packages/rust2rpm/templates/mageia-changelog.spec.inc
============== 2 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.9 s =============

All OK.


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

rust2rpm.noarch: W: obsolete-not-provided cargo-inspector
rust2rpm.noarch: W: obsolete-not-provided python3-rust2rpm-core
rust2rpm.noarch: W: no-manual-page-for-binary rust2rpm
rust2rpm.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/rust2rpm/templates/plain-changelog.spec.inc /usr/lib/python3.11/site-packages/rust2rpm/templates/fedora-changelog.spec.inc:/usr/lib/python3.11/site-packages/rust2rpm/templates/mageia-changelog.spec.inc
 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.0 s 

All OK.

Source checksums
----------------
https://pagure.io/fedora-rust/rust2rpm/archive/24.0.0/rust2rpm-24.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : fd47a4fa080e8dfd5f336bd823fd9dc078e73db3ac1639bebdafab24cd2b8a86
  CHECKSUM(SHA256) upstream package : fd47a4fa080e8dfd5f336bd823fd9dc078e73db3ac1639bebdafab24cd2b8a86


BuildRequires
-------------

    (python3dist(toml) if python3-devel < 3.11)
    cargo
    pyproject-rpm-macros
    python3-devel
    python3dist(cargo2rpm)
    python3dist(jinja2)
    python3dist(packaging)
    python3dist(pip) >= 19
    python3dist(pyparsing)
    python3dist(pytest)
    python3dist(requests)
    python3dist(setuptools)
    python3dist(termcolor)
    python3dist(tox)
    python3dist(tox-current-env) >= 0.0.6
    python3dist(tqdm)
    python3dist(wheel)


Requires
--------
rust2rpm (rpmlib, GLIBC filtered):
    /usr/bin/python3
    cargo
    cargo-rpm-macros
    cargo2rpm >= 0.1.1
    python(abi) = 3.11
    python3.11dist(cargo2rpm)
    python3.11dist(jinja2)
    python3.11dist(pyparsing)
    python3.11dist(requests)
    python3.11dist(termcolor)
    python3.11dist(tqdm)


Provides
--------
rust2rpm:
    python-rust2rpm = 24.0.0-1.fc39
    python3-rust2rpm = 24.0.0-1.fc39
    python3.11-rust2rpm = 24.0.0-1.fc39
    python3.11dist(rust2rpm) = 24
    python3dist(rust2rpm) = 24
    rust2rpm = 24.0.0-1.fc39


Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17
Command line :try-fedora-review -b 2170204 -m fedora-rawhide-x86_64 -o=--addrepo=https://download.copr.fedorainfracloud.org/results/decathorpe/rust-packaging-ng/fedora-rawhide-x86_64/
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: SugarActivity, Ruby, Perl, C/C++, Haskell, Java, PHP, fonts, R, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 13 Miro Hrončok 2023-02-16 16:53:47 UTC
Style nitpick:

Consider aligning %py_provides like a normal tag:

# obsolete and / or provide removed Python subpackages
%py_provides    python3-rust2rpm
Obsoletes:      python3-rust2rpm < 24
Obsoletes:      python3-rust2rpm-core < 24

Comment 14 Fabio Valentini 2023-02-16 17:20:48 UTC
Good point, I'll do that. Thanks for the review!

Comment 15 Fedora Admin user for bugzilla script actions 2023-02-16 17:21:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust2rpm

Comment 16 Fabio Valentini 2023-02-16 18:48:15 UTC
I have addressed the %license and %py_provides alignment issues, and pushed it together with the rust-packaging update:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-77a65a092d


Note You need to log in before you can comment on or make changes to this bug.