Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05552597-python-trove-classifiers/python-trove-classifiers.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05552597-python-trove-classifiers/python-trove-classifiers-2023.2.8-1.fc39.src.rpm Description: Canonical source for classifiers on PyPI. Classifiers categorize projects per PEP 301. Use this package to validate classifiers in packages for PyPI upload or download. Fedora Account System Username: thrnciar
Copr build: https://copr.fedorainfracloud.org/coprs/build/5552946 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2172053-python-trove-classifiers/fedora-rawhide-x86_64/05552946-python-trove-classifiers/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Beware the patch makes this a different version. $ rpm -qPp python3-trove-classifiers-2023.2.8-1.fc39.noarch.rpm python-trove-classifiers = 2023.2.8-1.fc39 python3-trove-classifiers = 2023.2.8-1.fc39 python3.11-trove-classifiers = 2023.2.8-1.fc39 python3.11dist(trove-classifiers) = 2022.12.22 python3dist(trove-classifiers) = 2022.12.22
Good catch, fixed. I also updated the spec file to the latest version, since there was a new release yesterday. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05553522-python-trove-classifiers/python-trove-classifiers.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05553522-python-trove-classifiers/python3-trove-classifiers-2023.2.20-1.fc39.noarch.rpm
Fixed links: Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05553522-python-trove-classifiers/python-trove-classifiers.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05553522-python-trove-classifiers/python-trove-classifiers-2023.2.20-1.fc39.src.rpm
1) the patch is modified and does not correspond to the patch URL: --- 809156bb35852bcaa1c753e0165f1814f2bcedf6.patch.1 2023-02-21 17:59:20.638478801 +0100 +++ 809156bb35852bcaa1c753e0165f1814f2bcedf6.patch 2023-02-21 01:00:00.000000000 +0100 @@ -12,20 +12,6 @@ delete mode 100644 setup.py create mode 100644 src/trove_classifiers/version.py -diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml -index b11e366..d6b68a7 100644 ---- a/.github/workflows/release.yml -+++ b/.github/workflows/release.yml -@@ -32,7 +32,8 @@ jobs: - password: ${{ secrets.pypi_password }} - - name: Version - id: version -- run: echo "::set-output name=version::$(python setup.py --version 2>/dev/null)" -+ run: | -+ echo version=$(python -c "from trove_classifiers import version; print(version.__version__)" 2>/dev/null) >> $GITHUB_OUTPUT - - name: Tag - uses: actions/create-release@v1 - env: diff --git a/pyproject.toml b/pyproject.toml index 672fc13..23542a4 100644 --- a/pyproject.toml @@ -117,4 +103,4 @@ --- /dev/null +++ b/src/trove_classifiers/version.py @@ -0,0 +1 @@ -+__version__ = "2022.12.22" ++__version__ = "2023.2.20" 2) the %check section is empty 3) W: summary-ended-with-dot Canonical source for classifiers on PyPI (pypi.org). 4) %license LICENSE is duplicated: $ rpm -qp --licensefiles python3-trove-classifiers-2023.2.20-1.fc39.noarch.rpm /usr/lib/python3.11/site-packages/trove_classifiers-2023.2.20.dist-info/LICENSE /usr/share/licenses/python3-trove-classifiers/LICENSE
I've addressed all remarks above. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05554360-python-trove-classifiers/python-trove-classifiers.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-trove-classifiers/fedora-rawhide-x86_64/05554360-python-trove-classifiers/python-trove-classifiers-2023.2.20-1.fc39.src.rpm
Created attachment 1945567 [details] The .spec file difference from Copr build 5552946 to 5554376
Copr build: https://copr.fedorainfracloud.org/coprs/build/5554376 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2172053-python-trove-classifiers/fedora-rawhide-x86_64/05554376-python-trove-classifiers/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License". [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-trove-classifiers-2023.2.20-1.fc39.noarch.rpm python-trove-classifiers-2023.2.20-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfvam0k6m')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/t/trove-classifiers/trove-classifiers-2023.2.20.tar.gz : CHECKSUM(SHA256) this package : 860b0c0d8c9e0d32629ca5ef137ea1e637580b634b74ba40e1539fd34464c0f5 CHECKSUM(SHA256) upstream package : 860b0c0d8c9e0d32629ca5ef137ea1e637580b634b74ba40e1539fd34464c0f5 BuildRequires ------------- (python3dist(toml) if python3-devel < 3.11) pyproject-rpm-macros python3-devel python3-pytest python3dist(packaging) python3dist(pip) >= 19 python3dist(setuptools) >= 61 python3dist(wheel) Requires -------- python3-trove-classifiers (rpmlib, GLIBC filtered): python(abi) = 3.11 Provides -------- python3-trove-classifiers: python-trove-classifiers = 2023.2.20-1.fc39 python3-trove-classifiers = 2023.2.20-1.fc39 python3.11-trove-classifiers = 2023.2.20-1.fc39 python3.11dist(trove-classifiers) = 2023.2.20 python3dist(trove-classifiers) = 2023.2.20 Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-trove-classifiers --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: R, Haskell, Ocaml, Java, SugarActivity, fonts, Perl, C/C++, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-trove-classifiers