Red Hat Bugzilla – Bug 217229
Review Request: libmpd - Music Player Daemon library
Last modified: 2015-04-02 19:46:43 EDT
Spec URL: http://lisas.de/~adrian/rpm/libmpd.spec
SRPM URL: http://lisas.de/~adrian/rpm/libmpd-0.12.0-2.src.rpm
libmpd is an abstraction around libmpdclient. It provides an easy and
reliable callback based interface to mpd.
This library is needed to update gmpc to 0.13
Review for release 2:
* RPM name is OK
* Source libmpd-0.12.0.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of libmpd looks OK
* rpmlint of libmpd-devel looks OK
* File list of libmpd looks OK
* File list of libmpd-devel looks OK
* INSERT RESULT OF RUN TEST
* As libmpd-devel ships a pkgconfig file (.pc), is should have "Requires: pkgconfig"
Fix this and you're good to go
(sorry for the "INSERT RESULT OF RUN TEST", I did actually test it)
Sorry. I just saw that you changed the blocker bug to FE-REVIEW. Unfortunately I
already imported it because I thought it was FE-ACCEPT. I will not request a
build before you change it to FE-ACCEPT. Really sorry.
I have updated the package in the CVS to include Requires: pkgconfig in the
-devel package. Hope it is alright now.
No problem. If it has the proper "Requires" in CVS, just go ahead and build it.
Aurelien, thanks a lot. Package has been build for devel.
Please don't forget to assign the review to yourself when you take or approve it.
Package Change Request
Package Name: libmpd
New Branches: epel7
Adrianr is not on the list of packagers that are okay with anyone requesting their packages for EPEL (http://fedoraproject.org/wiki/EPEL/ContributorStatusNo), so please ask him to request the branch.
Git done (by process-git-requests).
Thank you Patrick and Adrian! Quick response much appreciated.