Bug 217229 - Review Request: libmpd - Music Player Daemon library
Review Request: libmpd - Music Player Daemon library
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-11-25 06:18 EST by Adrian Reber
Modified: 2015-04-02 19:46 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-11-26 07:32:31 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
puiterwijk: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Adrian Reber 2006-11-25 06:18:40 EST
Spec URL: http://lisas.de/~adrian/rpm/libmpd.spec
SRPM URL: http://lisas.de/~adrian/rpm/libmpd-0.12.0-2.src.rpm
Description:
libmpd is an abstraction around libmpdclient. It provides an easy and
reliable callback based interface to mpd.

This library is needed to update gmpc to 0.13
Comment 1 Aurelien Bompard 2006-11-25 08:27:24 EST
Review for release 2:
* RPM name is OK
* Source libmpd-0.12.0.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of libmpd looks OK
* rpmlint of libmpd-devel looks OK
* File list of libmpd looks OK
* File list of libmpd-devel looks OK
* INSERT RESULT OF RUN TEST

Needs work:
* As libmpd-devel ships a pkgconfig file (.pc), is should have "Requires: pkgconfig"

Fix this and you're good to go
Comment 2 Aurelien Bompard 2006-11-25 09:14:29 EST
(sorry for the "INSERT RESULT OF RUN TEST", I did actually test it)
Comment 3 Adrian Reber 2006-11-25 17:22:44 EST
Sorry. I just saw that you changed the blocker bug to FE-REVIEW. Unfortunately I
already imported it because I thought it was FE-ACCEPT. I will not request a
build  before you change it to FE-ACCEPT. Really sorry.

I have updated the package in the CVS to include Requires: pkgconfig in the
-devel package. Hope it is alright now.
Comment 4 Aurelien Bompard 2006-11-25 18:20:52 EST
No problem. If it has the proper "Requires" in CVS, just go ahead and build it.
Comment 5 Adrian Reber 2006-11-26 07:32:31 EST
Aurelien, thanks a lot. Package has been build for devel.
Comment 6 Warren Togami 2006-11-26 20:01:30 EST
Please don't forget to assign the review to yourself when you take or approve it.
Comment 7 Mukundan Ragavan 2015-03-31 20:24:51 EDT
Package Change Request
======================
Package Name: libmpd
New Branches: epel7
Owners: nonamedotc
Comment 8 Patrick Uiterwijk 2015-04-02 09:03:57 EDT
Adrianr is not on the list of packagers that are okay with anyone requesting their packages for EPEL (http://fedoraproject.org/wiki/EPEL/ContributorStatusNo), so please ask him to request the branch.
Comment 9 Adrian Reber 2015-04-02 09:09:07 EDT
Package Change Request
======================
Package Name: libmpd
New Branches: epel7
Owners: nonamedotc
Comment 10 Patrick Uiterwijk 2015-04-02 10:42:19 EDT
Git done (by process-git-requests).
Comment 11 Mukundan Ragavan 2015-04-02 19:46:43 EDT
Thank you Patrick and Adrian! Quick response much appreciated.

Note You need to log in before you can comment on or make changes to this bug.