Bug 217239 - (arrows) Review Request: arrows - Neat little maze game
Review Request: arrows - Neat little maze game
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Christopher Stone
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-11-25 10:38 EST by Hans de Goede
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-11-25 16:17:24 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Hans de Goede 2006-11-25 10:38:54 EST
Spec URL: http://people.atrpms.net/~hdegoede/arrows.spec
SRPM URL: http://people.atrpms.net/~hdegoede/arrows-0.6-1.fc7.src.rpm
Description:
It's a maze game of sorts. Guide the spinning blue thing through
the maze of arrows, creating and destroying arrows as necessary
to collect the green things.
Comment 1 Christopher Stone 2006-11-25 12:41:59 EST
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets Packaging Guidelines
- package licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec is legible
- sources match upstream
d6cf52ff319c295b9fb6982c023ec7f0  arrows-0.6.tar.gz
- successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
X package uses a directory it doesnt create and I cannot determine if its pulled
in from Requires packages.
This package puts an icon in /usr/share/icons/hicolor/24x24/apps/
- no duplicates in %files
- file permissions set properly
- package contains proper %clean
- macro usage consistent
- contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no devel subpackage required
- no .la files
O desktop file installed properly
(although see my comment in SHOULD fix)
- package does not own files or directories owned by other packages

==== MUST FIX ====
- Shouldn't this require some package to get the icon dir?  If not, please tell
me how I determine which Requires would pull this in.  Perhaps Require:
gnome-icon-theme?  Or hicolor-icon-theme if you decide to move this out of the
GNOME menu (see SHOULD FIX section).

==== SHOULD FIX ====
- I'm not sure I agree all games compiled with gtk2 should be placed under
GNOME->Games.  I think GNOME->Games should be for games that are distributed
with GNOME much like KDE has their kde-games package.  This may require further
discussion on the fedora-games-list.  Not a blocker.
Comment 2 Hans de Goede 2006-11-25 15:37:48 EST
(In reply to comment #1)
> ==== MUST FIX ====
> - Shouldn't this require some package to get the icon dir?  If not, please tell
> me how I determine which Requires would pull this in.  Perhaps Require:
> gnome-icon-theme?  Or hicolor-icon-theme if you decide to move this out of the
> GNOME menu (see SHOULD FIX section).
> 

Yes it should have a "Requires: hicolor-icon-theme", my bad , fixed.

> ==== SHOULD FIX ====
> - I'm not sure I agree all games compiled with gtk2 should be placed under
> GNOME->Games.  I think GNOME->Games should be for games that are distributed
> with GNOME much like KDE has their kde-games package.  This may require further
> discussion on the fedora-games-list.  Not a blocker.

I took that GNOME entry in the .desktop over from the package on which I based
mine, but I agree it isn't a gnome app, dropped.

New version here:
Spec URL: http://people.atrpms.net/~hdegoede/arrows.spec
SRPM URL: http://people.atrpms.net/~hdegoede/arrows-0.6-2.fc7.src.rpm
Comment 3 Christopher Stone 2006-11-25 15:57:28 EST
All MUST/SHOULD items fixed.

Please re-check scummvm spec for icon issue mentioned here, I might have missed
this on my review of scummvm.

APPROVED.
Comment 4 Hans de Goede 2006-11-25 16:17:24 EST
Thanks, imported and build, closing.

p.s.

scummvm is fine.

Note You need to log in before you can comment on or make changes to this bug.