nbdkit commit cf2b6297646a ("common/include/unique-name.h: Rename UNIQUE_NAME macro", 2022-01-11) and libnbd in commit 485f5ddf2d48 ("common/include/unique-name.h: Rename UNIQUE_NAME macro", 2022-02-23) have made some lines overlong (>80 chars). On top, libnbd commit b5101fbc59cb ("use space consistently in function and function-like macro invocations", 2023-02-22) made some lines even longer. Rewrap the libnbd source code (primarily in the files modified by the above-noted commits) with an 80 characters line length. Mirror the result back to nbdkit.
Unless it complicates the libnbd generator too much, stay within the 80 characters line width in the generated *.[ch] files as well.
Related threads: [Libguestfs] [libnbd PATCH v3 01/29] use space consistently in function and function-like macro invocations https://listman.redhat.com/archives/libguestfs/2023-February/030685.html [Libguestfs] [libnbd PATCH v3 02/29] generator/C.ml: use space consistently in func. and func.-like macro calls https://listman.redhat.com/archives/libguestfs/2023-February/030683.html
(In reply to Laszlo Ersek from comment #1) > Unless it complicates the libnbd generator too much, stay within the 80 > characters line width in the generated *.[ch] files as well. The generator should always attempt to produce readable code, as if it had been written by hand (except obviously more consistent and correct). It should be possible to go through generated code with a debugger and understand what's going on. There are even some generated comments. To this end there are various functions in the generator for creating nicely line-wrapped code.
[nbdkit PATCH 00/17] wrap source code at 80 chars Message-Id: <20230413140346.908687-1-lersek> https://listman.redhat.com/archives/libguestfs/2023-April/031226.html
(In reply to Laszlo Ersek from comment #4) > [nbdkit PATCH 00/17] wrap source code at 80 chars > Message-Id: <20230413140346.908687-1-lersek> > https://listman.redhat.com/archives/libguestfs/2023-April/031226.html Commit range a7709a69ac08..64f7c65cfc4c.
[libnbd PATCH 0/4] copy: wrap source code at 80 characters Message-Id: <20230414075956.240682-1-lersek> https://listman.redhat.com/archives/libguestfs/2023-April/031258.html
[libnbd PATCH v2 0/3] copy: wrap source code at 80 characters Message-Id: <20230414100534.377169-1-lersek> https://listman.redhat.com/archives/libguestfs/2023-April/031270.html
(In reply to Laszlo Ersek from comment #7) > [libnbd PATCH v2 0/3] copy: wrap source code at 80 characters > Message-Id: <20230414100534.377169-1-lersek> > https://listman.redhat.com/archives/libguestfs/2023-April/031270.html Commit range 30d8e6414bde..424420a55bab.
[libnbd PATCH 00/18] wrap hand-written source code at 80 characters Message-Id: <20230418172631.485472-1-lersek> (no link in the archive just yet)
(In reply to Laszlo Ersek from comment #9) > [libnbd PATCH 00/18] wrap hand-written source code at 80 characters > Message-Id: <20230418172631.485472-1-lersek> > (no link in the archive just yet) Patches 01..15 and 17..18 merged as commit range 1acdeec1a248..a458f0644de0.
[libnbd PATCH v2] tests/requires: wrap source code at 80 characters Message-Id: <20230419153127.178015-1-lersek>
(In reply to Laszlo Ersek from comment #11) > [libnbd PATCH v2] tests/requires: wrap source code at 80 characters > Message-Id: <20230419153127.178015-1-lersek> Commit 86820dbab497.
[libnbd PATCH 0/3] start wrapping generated C source code harder at 80 chars Message-Id: <20230420140458.247274-1-lersek>
[libnbd PATCH v2 0/4] start wrapping generated C source code harder at 80 chars Message-Id: <20230421073418.146910-1-lersek>
(In reply to Laszlo Ersek from comment #14) > [libnbd PATCH v2 0/4] start wrapping generated C source code harder at 80 chars > Message-Id: <20230421073418.146910-1-lersek> Commit range 86820dbab497..0744f748ed90.
[libnbd PATCH 00/23] continue wrapping generated C code harder Message-Id: <20230425071108.82663-1-lersek> https://listman.redhat.com/archives/libguestfs/2023-April/031375.html
(In reply to Laszlo Ersek from comment #16) > [libnbd PATCH 00/23] continue wrapping generated C code harder > Message-Id: <20230425071108.82663-1-lersek> > https://listman.redhat.com/archives/libguestfs/2023-April/031375.html The first 21 patches have been pushed as 0744f748ed90..2fa6198f61d4; the last two patches need a v2.
[libnbd PATCH v2 0/2] continue wrapping generated C code harder Message-Id: <20230502170426.166550-1-lersek> https://listman.redhat.com/archives/libguestfs/2023-May/031427.html
(In reply to Laszlo Ersek from comment #18) > [libnbd PATCH v2 0/2] continue wrapping generated C code harder > Message-Id: <20230502170426.166550-1-lersek> > https://listman.redhat.com/archives/libguestfs/2023-May/031427.html Commit range 2fa6198f61d4..99d18799f407.
[libnbd PATCH 0/6] finish wrapping generated C code harder Message-Id: <20230510114814.458531-1-lersek> https://listman.redhat.com/archives/libguestfs/2023-May/031480.html
(In reply to Laszlo Ersek from comment #20) > [libnbd PATCH 0/6] finish wrapping generated C code harder > Message-Id: <20230510114814.458531-1-lersek> > https://listman.redhat.com/archives/libguestfs/2023-May/031480.html Merged as commit range d2d214c4e161..96fdc62ad59d.