Bug 217262 - Review Request: tdom - DOM parser for Tcl
Summary: Review Request: tdom - DOM parser for Tcl
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gérard Milmeister
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-11-26 03:10 UTC by Wart
Modified: 2014-07-20 14:44 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-05-21 19:56:40 UTC
Type: ---
Embargoed:
gemi: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Wart 2006-11-26 03:10:06 UTC
Spec URL: http://www.kobold.org/~wart/fedora/tdom.spec
SRPM URL: http://www.kobold.org/~wart/fedora/tdom-0.8.0-1.src.rpm
Description:
DOM parser for Tcl

There is another package, tcldom, that provides similar functionality, but with a different API.  Some Tcl applications are written for one Tcl DOM api or the other, so it would be good to include both in FE.

Comment 1 Gérard Milmeister 2007-05-01 12:25:52 UTC
rpmlint is silent on this: good.
However:
configure: WARNING:
    Building tdom without threads enabled, but building against a Tcl
    that IS thread-enabled.
Is there a reason why threads are disabled?
Also, it seems that RPM_OPT_FLAGS are not used.

Comment 2 Wart 2007-05-01 17:31:25 UTC
(In reply to comment #1)
> rpmlint is silent on this: good.
> However:
> configure: WARNING:
>     Building tdom without threads enabled, but building against a Tcl
>     that IS thread-enabled.
> Is there a reason why threads are disabled?

They weren't disabled explicitly.  The default for this package is to build
without threading enabled.  I've added --enable-threads to the configure line to
fix.

> Also, it seems that RPM_OPT_FLAGS are not used.

Fixed as well:

http://www.kobold.org/~wart/fedora/tdom-0.8.0-2.src.rpm
http://www.kobold.org/~wart/fedora/tdom.spec

Comment 3 Gérard Milmeister 2007-05-05 13:28:43 UTC
* package meets naming and packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently
* dist tag is present
* build root is correct
* license field matches the actual license
* license is open source-compatible, license text included in package
* latest version is being packaged
* BuildRequires are proper
* compiler flags are appropriate
* %clean is present
* package builds in mock (FC-6, i386)
* package installs properly
* rpmlint is silent
* final provides and requires are sane
* owns the directories it creates
* doesn't own any directories it shouldn't
* no duplicates in %files
* file permissions are appropriate
* no scriptlets present
* code, not content
* documentation is small, so no -docs subpackage is necessary
* %docs are not necessary for the proper functioning of the package
* no headers
* no pkgconfig files
* no libtool .la droppings

APPROVED

Comment 4 Wart 2007-05-05 21:58:17 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: tdom
Short Description: Tcl dom parser
Owners: wart
Branches: FC-6
InitialCC:


Comment 5 Dennis Gilmore 2007-05-06 05:35:00 UTC
cvs done

Comment 6 Wart 2007-05-07 04:24:23 UTC
Imported and built.  Thanks!

Comment 7 Wart 2007-05-21 19:58:57 UTC
Removing FE-NEW blocker

Comment 8 Wart 2007-08-27 01:41:36 UTC
Package Change Request
======================
Package Name: tdom
New Branches: F-7

Comment 9 Kevin Fenzi 2007-08-28 04:29:49 UTC
cvs done. 

Comment 10 Wart 2008-06-20 12:15:23 UTC
Package Change Request
======================
Package Name: tdom
New Branches: EL-4 EL-5

Comment 11 Kevin Fenzi 2008-06-20 15:21:09 UTC
cvs done.

Comment 12 Kyle Lanclos 2014-07-20 14:44:38 UTC
Package Change Request
======================
Package Name: tdom
New Branches: EPEL7


Note You need to log in before you can comment on or make changes to this bug.