Spec URL: http://www.kobold.org/~wart/fedora/tdom.spec SRPM URL: http://www.kobold.org/~wart/fedora/tdom-0.8.0-1.src.rpm Description: DOM parser for Tcl There is another package, tcldom, that provides similar functionality, but with a different API. Some Tcl applications are written for one Tcl DOM api or the other, so it would be good to include both in FE.
rpmlint is silent on this: good. However: configure: WARNING: Building tdom without threads enabled, but building against a Tcl that IS thread-enabled. Is there a reason why threads are disabled? Also, it seems that RPM_OPT_FLAGS are not used.
(In reply to comment #1) > rpmlint is silent on this: good. > However: > configure: WARNING: > Building tdom without threads enabled, but building against a Tcl > that IS thread-enabled. > Is there a reason why threads are disabled? They weren't disabled explicitly. The default for this package is to build without threading enabled. I've added --enable-threads to the configure line to fix. > Also, it seems that RPM_OPT_FLAGS are not used. Fixed as well: http://www.kobold.org/~wart/fedora/tdom-0.8.0-2.src.rpm http://www.kobold.org/~wart/fedora/tdom.spec
* package meets naming and packaging guidelines * specfile is properly named, is cleanly written and uses macros consistently * dist tag is present * build root is correct * license field matches the actual license * license is open source-compatible, license text included in package * latest version is being packaged * BuildRequires are proper * compiler flags are appropriate * %clean is present * package builds in mock (FC-6, i386) * package installs properly * rpmlint is silent * final provides and requires are sane * owns the directories it creates * doesn't own any directories it shouldn't * no duplicates in %files * file permissions are appropriate * no scriptlets present * code, not content * documentation is small, so no -docs subpackage is necessary * %docs are not necessary for the proper functioning of the package * no headers * no pkgconfig files * no libtool .la droppings APPROVED
Thanks for the review! New Package CVS Request ======================= Package Name: tdom Short Description: Tcl dom parser Owners: wart Branches: FC-6 InitialCC:
cvs done
Imported and built. Thanks!
Removing FE-NEW blocker
Package Change Request ====================== Package Name: tdom New Branches: F-7
cvs done.
Package Change Request ====================== Package Name: tdom New Branches: EL-4 EL-5
Package Change Request ====================== Package Name: tdom New Branches: EPEL7