Bug 2172672 - Review Request: rust-json_to_table - Libary for pretty print JSON as a table
Summary: Review Request: rust-json_to_table - Libary for pretty print JSON as a table
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/json_to_table
Whiteboard:
Depends On:
Blocks: 2172673
TreeView+ depends on / blocked
 
Reported: 2023-02-22 23:09 UTC by Michel Lind
Modified: 2023-03-28 15:39 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-02-27 01:44:47 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2023-02-22 23:09:19 UTC
Spec URL: https://salimma.fedorapeople.org/rust-json_to_table.spec
SRPM URL: https://salimma.fedorapeople.org/rust-json_to_table-0.3.1-1.fc37.src.rpm

Description:
A libary for pretty print JSON as a table.

Fedora Account System Username: salimma

Comment 1 Davide Cavalca 2023-02-22 23:13:21 UTC
This is missing the license text

Comment 2 Jakub Kadlčík 2023-02-22 23:17:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5558646
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2172672-rust-json_to_table/fedora-rawhide-x86_64/05558646-rust-json_to_table/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2023-02-23 02:47:25 UTC
License added, thanks!

Comment 4 Davide Cavalca 2023-02-23 16:17:30 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-02-23 16:25:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-json_to_table

Comment 6 Fedora Update System 2023-02-23 20:34:53 UTC
FEDORA-2023-98ad341df8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

Comment 7 Fedora Update System 2023-02-23 20:36:45 UTC
FEDORA-2023-c100b44172 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

Comment 8 Fedora Update System 2023-02-24 03:39:09 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c100b44172`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-02-24 04:34:10 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-02-26 00:30:48 UTC
FEDORA-2023-f0c2d69ebd has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f0c2d69ebd

Comment 11 Fedora Update System 2023-02-26 02:01:13 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-98ad341df8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-02-26 02:02:22 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c100b44172`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c100b44172

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-02-27 01:44:47 UTC
FEDORA-2023-c100b44172 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-02-27 02:53:02 UTC
FEDORA-2023-f0c2d69ebd has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2023-03-11 03:07:26 UTC
FEDORA-2023-98ad341df8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fabio Valentini 2023-03-28 15:39:12 UTC
Please don't forget to add rust-sig with commit access. I've set up release-monitoring and koschei.


Note You need to log in before you can comment on or make changes to this bug.