Bug 2173092 - Review Request: rust-defmt-parser - Parsing library for defmt format strings
Summary: Review Request: rust-defmt-parser - Parsing library for defmt format strings
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/defmt-parser
Whiteboard:
Depends On:
Blocks: 2173093
TreeView+ depends on / blocked
 
Reported: 2023-02-23 22:10 UTC by Michel Lind
Modified: 2023-02-24 21:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-02-24 21:07:23 UTC
Type: ---
Embargoed:
davide: fedora-review?


Attachments (Terms of Use)

Description Michel Lind 2023-02-23 22:10:50 UTC
Spec URL: https://salimma.fedorapeople.org/rust-defmt-parser.spec
SRPM URL: https://salimma.fedorapeople.org/rust-defmt-parser-0.3.1-1.fc37.src.rpm

Description:
Parsing library for defmt format strings.

Fedora Account System Username: salimma

Comment 1 Jakub Kadlčík 2023-02-23 22:17:05 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5561845
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173092-rust-defmt-parser/fedora-rawhide-x86_64/05561845-rust-defmt-parser/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Davide Cavalca 2023-02-24 17:33:24 UTC
Do you actually need the unstable feature? That doesn't look like something we should ship.

Comment 3 Michel Lind 2023-02-24 21:07:23 UTC
Needed by defmt-macros, which is concerning, let's just drop defmt dependencies from heapless


Note You need to log in before you can comment on or make changes to this bug.