Spec URL: https://v02460.fedorapeople.org/rust-pythonize.spec SRPM URL: https://v02460.fedorapeople.org/rust-pythonize-0.17.0-5.fc39.src.rpm Description: Pythonize is an experimental serializer for Rust’s serde ecosystem, which can convert Rust objects to Python values and back. Fedora Account System Username: v02460 Notes: - Dependency of matrix-synapse. - This is not the newest version 0.18, but version 0.17 which is compatible with Fedora’s current version of rust-pyo3 0.17. - The extra LICENSE file is included because upstream did not provide one. We resolved it for version 0.18 from where the files is copied.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5564080 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173183-rust-pythonize/fedora-rawhide-x86_64/05564080-rust-pythonize/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review. NOTE: Package was generated with `rust2rpm` and contains minimal changes. Package looks good. The only thing that is missing is the update to the latest version. You wrote: > This is not the newest version 0.18, but version 0.17 which is compatible with Fedora’s current version of rust-pyo3 0.17 `rust-pyo3` has been updated to 0.18.1 so the update should now be possible. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 13 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust- pythonize/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. In the packaged version (0.17.0) upstream did not contain a license file. From version 0.18.0 and upwards, upstream has included one. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- pythonize-devel , rust-pythonize+default-devel [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: rust-pythonize-devel-0.17.0-5.fc39.noarch.rpm rust-pythonize+default-devel-0.17.0-5.fc39.noarch.rpm rust-pythonize-0.17.0-5.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpeuxsbgpf')] checks: 31, packages: 3 rust-pythonize+default-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 rust-pythonize+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/pythonize/0.17.0/download#/pythonize-0.17.0.crate : CHECKSUM(SHA256) this package : 0f7f0c136f5fbc01868185eef462800e49659eb23acca83b9e884367a006acb6 CHECKSUM(SHA256) upstream package : 0f7f0c136f5fbc01868185eef462800e49659eb23acca83b9e884367a006acb6 Requires -------- rust-pythonize-devel (rpmlib, GLIBC filtered): (crate(pyo3) >= 0.17.0 with crate(pyo3) < 0.18.0~) (crate(serde) >= 1.0.0 with crate(serde) < 2.0.0~) (crate(serde/std) >= 1.0.0 with crate(serde/std) < 2.0.0~) cargo rust-pythonize+default-devel (rpmlib, GLIBC filtered): cargo crate(pythonize) Provides -------- rust-pythonize-devel: crate(pythonize) rust-pythonize-devel rust-pythonize+default-devel: crate(pythonize/default) rust-pythonize+default-devel Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-pythonize --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, Haskell, Python, Java, fonts, Perl, PHP, Ocaml, C/C++, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thank you for the review! Updated to version 0.18.0, which now is the unmodified spec file from rust2rpm. Spec URL: https://v02460.fedorapeople.org/rust-pythonize.spec SRPM URL: https://v02460.fedorapeople.org/rust-pythonize-0.18.0-1.fc39.src.rpm
Created attachment 1952843 [details] The .spec file difference from Copr build 5564080 to 5695113
Copr build: https://copr.fedorainfracloud.org/coprs/build/5695113 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173183-rust-pythonize/fedora-rawhide-x86_64/05695113-rust-pythonize/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me. APPROVED Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pythonize
FEDORA-2023-2164367fd9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2164367fd9
FEDORA-2023-2164367fd9 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-800d7cfba0 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-800d7cfba0
FEDORA-2023-e67444351a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e67444351a
FEDORA-2023-e67444351a has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e67444351a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e67444351a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-800d7cfba0 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-800d7cfba0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-e67444351a has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-800d7cfba0 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.