Bug 2173500 - Review Request: bqlmon - a ncurses interface to monitor the current number of bytes in-flight in the queue
Summary: Review Request: bqlmon - a ncurses interface to monitor the current number of...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-02-27 06:40 UTC by Kishan Takoordyal
Modified: 2024-06-12 00:45 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-06-12 00:45:30 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Kishan Takoordyal 2023-02-27 06:40:55 UTC
Spec URL: https://raw.githubusercontent.com/EdgeKing810/bqlmon/master/package-fedora/bqlmon.spec
SRPM URL: https://github.com/EdgeKing810/bqlmon/raw/master/package-fedora/bqlmon-1.0-1.fc37.x86_64.rpm
Description: This program uses the Linux Byte Queue Limits support that some Linux Ethernet drivers do support. Byte Queue Limits is refered to below as BQL. The program provides a ncurses interface to monitor the current number of bytes in-flight in the queue.
Fedora Account System Username:

Comment 1 Petr Pisar 2023-04-24 10:54:48 UTC
Where did you get the Source0 archive from? At that URL is just an HTML web page. If you used a git tree snapshot, then please follow <https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots> to set proper Version and <https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision> to set Source0 value.

Comment 2 Artur Frenszek-Iwicki 2023-04-27 09:47:15 UTC
> %global debug_package %{nil}
No-go. We require debuginfo to be present in Fedora. The distro's CFLAGS include flags for generating debuginfo, so this should happen by default.
If Fedora's CFLAGS are not respected, you may need to patch the Makefile.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages

> %description
> This program uses the Linux Byte Queue Limits support that some Linux Ethernet drivers do support.
> Byte Queue Limits is refered to below as BQL. The program provides a ncurses interface to monitor
> the current number of bytes in-flight in the queue.
The description text should be wrapped so that all lines fit within 80 characters.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

Also, please fix the Source0 issue that Petr mentioned.

Comment 3 Package Review 2024-05-12 00:45:35 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 4 Package Review 2024-06-12 00:45:30 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.