Bug 2173527 - VM details: Machine type- should it be just q35 or everything?
Summary: VM details: Machine type- should it be just q35 or everything?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.13.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.13.0
Assignee: Hilda Stastna
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-02-27 08:15 UTC by Guohua Ouyang
Modified: 2023-05-18 02:58 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-18 02:57:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 1101 0 None open Bug 2173527: Add help text to Machine type field 2023-03-02 17:11:04 UTC
Red Hat Issue Tracker CNV-26168 0 None None None 2023-02-27 09:01:32 UTC
Red Hat Product Errata RHSA-2023:3205 0 None None None 2023-05-18 02:58:07 UTC

Description Guohua Ouyang 2023-02-27 08:15:45 UTC
Description of problem:
The Machine type is just q35 in VM Details tab, we've discussed in the meeting about whether should we support other machine type types, so open the bug to track the discussion. 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Fabian Deutsch 2023-02-27 13:04:22 UTC
The correct value in the API depends on the CNV version, in general it follows the format
```
machine:
  type: pc-q35-rhel8.6.0
```

`q35` will not be used by CNV in the API or templates, because q35 is an alias and always points to the latest q35 `variant` - iow a VM could have a different ABI between restarts.

What was the reason fpr only exposing q35 in the UI?

Comment 3 Ronen 2023-02-27 13:18:50 UTC
@fdeutsch I see that the value is built from: pc-${machine_type}-${qemu_version}
I find it confusing to see pc-q35-rhel8.6.0 for all VMs, regardless of the OS (even for Windows).
If this is the correct value we can close the BZ

Comment 4 Fabian Deutsch 2023-02-27 13:35:36 UTC
Thanks Ronen.

Yes, this is the correct value.
I understand that this can be confusing as rhel is being mentioned.
The reason for this is that MT is a "property" of the hypervisor (qemu/kvm), and not something related to the guest.
pc-q35-rhel8.6.0 simply says: Take the q35 machine type which is defined in rhel 8.6.0

Woul dit help to add a tooltip or (?) questionmark icon with an explanatory description?

Comment 5 Yifat Menchik 2023-02-27 15:10:53 UTC
+1 @fdeutsch TMHO it would be helpful to add a (?) icon with a popover including an explanatory description.

Comment 6 Hilda Stastna 2023-02-28 18:15:25 UTC
Can you, please, folks, formulate the text for the popover so we can add it to the UI for explanation to VM Details tab?
Thanks!

Comment 7 Fabian Deutsch 2023-03-01 08:26:08 UTC
Something like:
 The machine type defines the basic virtual hardware configuration of
 a VM. The name and version relate to the underlying hypervisor.

Comment 8 Avital Pinnick 2023-03-01 11:01:57 UTC
How does this sound?

"The machine type defines the virtual hardware configuration while the operating system name and version refer to the hypervisor."

I don't think it is necessary to mention "of the VM" because the context is clear.

Comment 9 Fabian Deutsch 2023-03-01 11:22:47 UTC
Sounds good!

Comment 10 Hilda Stastna 2023-03-01 19:24:08 UTC
Does make any sense to add the popover also to VMI, VM Template's Details, or to Catalog, where "Machine type" also occurs? Thanks!

Comment 11 Fabian Deutsch 2023-03-01 20:24:39 UTC
Ideally consistently wherever "machine type" appears

Comment 13 errata-xmlrpc 2023-05-18 02:57:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.13.0 Images security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:3205


Note You need to log in before you can comment on or make changes to this bug.