Spec URL: https://download.copr.fedorainfracloud.org/results/fed500/parlaylib/fedora-rawhide-x86_64/05573280-parlaylib/parlaylib.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fed500/parlaylib/fedora-rawhide-x86_64/05573280-parlaylib/parlaylib-2.1.5%5E20230215git137076b-1.fc39.src.rpm Description: ParlayLib is a header only C++ library for developing efficient parallel algorithms and software on shared-memory multicore machines. It provides additional tools and primitives that go beyond what is available in the C++ standard library, and simplifies the task of programming provably efficient and scalable parallel algorithms. It consists of a sequence data type (analogous to std::vector), many parallel routines and algorithms, a work-stealing scheduler to support nested parallelism, and a scalable memory allocator. Fedora Account System Username: fed500
Copr build: https://copr.fedorainfracloud.org/coprs/build/5573921 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2173710-parlaylib/fedora-rawhide-x86_64/05573921-parlaylib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
1. Patch not applied. It is really needed?
Thanks for taking the review. Tried without the patch. It does not build: https://download.copr.fedorainfracloud.org/results/fed500/parlaylib/fedora-rawhide-x86_64/05581571-parlaylib/builder-live.log.gz The patch is needed.
I mean that in your spec file patch not applied at all. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_applying_patches Normally, patches to a package SHOULD be listed in PatchN: tags in the RPM spec file and applied using the %patch or %autosetup macros.
Or patches applied now without any additional parameters for autosetup?..
Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/2d_linear_program.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/3d_range.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/BFS.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/BFS_ligra.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/bellman_ford.h parlaylib- examples : /usr/share/doc/parlaylib- examples/examples/betweenness_centrality.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/bigint_add.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/box_kdtree.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/bucketed_dijkstra.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/cartesian_tree.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/cycle_count.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/decision_tree_c45.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/delaunay.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/fast_fourier_transform.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/filter.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/filter_kruskal.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/find_if.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/flatten.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/graph_color.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/hash_map.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/helper/graph_utils.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/helper/heap_tree.h parlaylib- examples : /usr/share/doc/parlaylib- examples/examples/helper/ligra_light.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/helper/speculative_for.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/helper/spherical.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/helper/union_find.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/huffman_tree.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/karatsuba.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/kcore.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/kmeans_pp.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/knn.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/knuth_morris_pratt.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/knuth_shuffle.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/kruskal.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/kth_smallest.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/lasso_regression.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/le_list.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/linefit.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/longest_common_prefix.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/longest_repeated_substring.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/low_diameter_decomposition.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/maximal_independent_set.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/maximal_matching.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/mcss.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/mergesort.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/minimum_edit_distance.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/nbody_fmm.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/oct_tree.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/pagerank.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/primes.h parlaylib- examples : /usr/share/doc/parlaylib- examples/examples/push_relabel_max_flow.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/quickhull.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/quicksort.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/rabin_karp.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/radix_tree.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/range_min.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/ray_trace.h parlaylib- examples : /usr/share/doc/parlaylib- examples/examples/rectangle_intersection.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/reduce.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/samplesort.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/scan.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/set_cover.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/spanning_tree.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/spectral_separator.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/suffix_array.h parlaylib-examples : /usr/share/doc/parlaylib-examples/examples/suffix_tree.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/tokens.h parlaylib- examples : /usr/share/doc/parlaylib-examples/examples/triangle_count.h parlaylib-examples : /usr/share/doc/parlaylib- examples/examples/word_counts.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Creative Commons Attribution 3.0". 254 files have unknown license. Detailed output of licensecheck in /home/vascom/2173710-parlaylib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 460800 bytes in 135 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in parlaylib-devel , parlaylib-examples [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: parlaylib-devel-2.1.5^20230215git137076b-1.fc39.x86_64.rpm parlaylib-examples-2.1.5^20230215git137076b-1.fc39.noarch.rpm parlaylib-2.1.5^20230215git137076b-1.fc39.src.rpm ====================================================================== rpmlint session starts ===================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps_mc8c7a')] checks: 31, packages: 3 parlaylib-examples.noarch: W: package-with-huge-docs 99% parlaylib-devel.x86_64: W: only-non-binary-in-usr-lib ======================================= 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.5 s ====================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 parlaylib-examples.noarch: W: package-with-huge-docs 99% parlaylib-devel.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.2 s Source checksums ---------------- https://github.com/cmuparlay/parlaylib/archive/137076b48013b7ba3dfce968076f09577e5d027a/parlaylib-137076b.tar.gz : CHECKSUM(SHA256) this package : 3418acbaf34cf2f24d90db87b53459ccb4a059883f82ae218e72696645a88f85 CHECKSUM(SHA256) upstream package : 3418acbaf34cf2f24d90db87b53459ccb4a059883f82ae218e72696645a88f85 Requires -------- parlaylib-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) parlaylib-examples (rpmlib, GLIBC filtered): Provides -------- parlaylib-devel: cmake(Parlay) cmake(parlay) parlaylib-devel parlaylib-devel(x86-64) parlaylib-static parlaylib-examples: parlaylib-examples Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2173710 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, fonts, R, Ocaml, SugarActivity, PHP, Haskell, Perl, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/parlaylib