Spec URL: https://decathorpe.fedorapeople.org/rust-git-absorb.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-git-absorb-0.6.9-1.fc37.src.rpm Description: Git commit --fixup, but automatic. Fedora Account System Username: decathorpe
Copr build: https://copr.fedorainfracloud.org/coprs/build/5582269 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174380-rust-git-absorb/fedora-rawhide-x86_64/05582269-rust-git-absorb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Can you include the shell completions in the package? ``` %build [...] ./target/release/git-absorb --gen-completions bash >git-absorb.bash ./target/release/git-absorb --gen-completions fish >git-absorb.fish ./target/release/git-absorb --gen-completions zsh >git-absorb.zsh ``` ``` %install [...] install -Dpm 0644 git-absorb.bash %{buildroot}%{bash_completions_dir}/git-absorb install -Dpm 0644 git-absorb.fish %{buildroot}%{fish_completions_dir}/git-absorb.fish install -Dpm 0644 git-absorb.zsh %{buildroot}%{zsh_completions_dir}/_git-absorb ``` ``` %files -n %{crate} [...] %{bash_completions_dir}/git-absorb %{fish_completions_dir}/git-absorb.fish %{zsh_completions_dir}/_git-absorb ```
Sure. I didn't know there were any completions, since they aren't mentioned in the project README or committed into git 😅
Spec URL: https://decathorpe.fedorapeople.org/rust-git-absorb.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-git-absorb-0.6.9-1.fc37.src.rpm Changes: Generate and include shell completions for bash, fish, and zsh.
Created attachment 1947288 [details] The .spec file difference from Copr build 5582269 to 5583818
Copr build: https://copr.fedorainfracloud.org/coprs/build/5583818 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174380-rust-git-absorb/fedora-rawhide-x86_64/05583818-rust-git-absorb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This package was generated with rust2rpm which simplifies the review. - The package builds in mock. - The test suite is run in %check. - The latest version is packaged. - The package includes the license texts and they are congruent with the License: tag. The License: accounts for statically linked dependencies. - The package abides by the Rust Packaging Guidelines and general Packaging Guidelines. Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
Thanks for working on this!
Thanks for the quick review :)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-git-absorb
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-500b227b15 https://bodhi.fedoraproject.org/updates/FEDORA-2023-1c3f0bf94a https://bodhi.fedoraproject.org/updates/FEDORA-2023-e107afba0e https://bodhi.fedoraproject.org/updates/FEDORA-2023-78d8ff8690