2174397 – [snapshot] failed to validate snapshot xml with "<snapshotDeleteInProgress/>"

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2174397 - [snapshot] failed to validate snapshot xml with "<snapshotDeleteInProgress/>"

Summary: [snapshot] failed to validate snapshot xml with "<snapshotDeleteInProgress/>"

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 9
Classification:	Red Hat
Component:	libvirt
Sub Component:
Version:	9.2
Hardware:	All
OS:	Linux
Priority:	low
Severity:	low
Target Milestone:	rc
Target Release:	---
Assignee:	Pavel Hrdina
QA Contact:	yisun
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1519002
TreeView+	depends on / blocked

Reported:	2023-03-01 13:25 UTC by yisun
Modified:	2023-11-07 09:38 UTC (History)
CC List:	5 users (show)
Fixed In Version:	libvirt-9.2.0-1.el9
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:	2023-11-07 08:30:47 UTC
Type:	Bug
Target Upstream Version:	9.2.0
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Issue Tracker	RHELPLAN-150294	0	None	None	None	2023-03-01 13:25:52 UTC
Red Hat Product Errata	RHSA-2023:6409	0	None	None	None	2023-11-07 08:31:33 UTC

Description yisun 2023-03-01 13:25:32 UTC

Description of problem:
failed to validate snapshot xml with "<snapshotDeleteInProgress/>"

Version-Release number of selected component (if applicable):
libvirt-libs-9.0.0-7.el9.x86_64
libvirt-9.0.0-7.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
with commit 565bcb5d79, there is a new element <snapshotDeleteInProgress/> introduced to snapshot xml, which indicate the parent snapshot is invalid when a snapshot-delete failed. But this element is not defined in domainsnapshot.rng

1. have a running vm = vm1

2. create first diskonly snapshot for vm
# virsh snapshot-create-as vm1 s1 --disk-only

3. create second diskonly snapshot for vm
# virsh snapshot-create-as vm1 s1 --disk-only

4. generate some data in vm's vda
in_vm# dd if=/dev/urandom of=/tmp/test.data bs=1M count=5000; sync

5. create third diskonly snapshot for vm
# virsh snapshot-create-as vm1 s3 --disk-only

6. delete snapshot=s2, and during the same time, in anthoer terminal, turnoff the vm
T1 # virsh snapshot-delete vm1 s2
T2 # virsh destroy vm1
T1 will get snapshot-delete error

7. check the snapshot xml of s1, it will have tag <snapshotDeleteInProgress/> 
# virsh snapshot-dumpxml vm1 s1 | grep InProgress -a10
...
  <disks>
    <disk name='vda' snapshot='external' type='file'>
      <snapshotDeleteInProgress/>
      <driver type='qcow2'/>
      <source file='/var/lib/libvirt/images/vm1.s1'/>
    </disk>
...

8. try to validate the xml, it'll be failed
# virsh snapshot-dumpxml vm1 s1 --security-info|virt-xml-validate -
Relax-NG validity error : Extra element disks in interleave
-:6: element disks: Relax-NG validity error : Element domainsnapshot failed to validate content
- fails to validate


Actual results:
virt-xml-validate failed when snapshot xml has <snapshotDeleteInProgress/>

Expected results:
virt-xml-validate passed

Comment 2 Peter Krempa 2023-03-01 13:31:17 UTC

In cases when the user want's to redefine such a snapshot we need to allow it wven with validation.

Comment 3 Pavel Hrdina 2023-03-20 09:41:44 UTC

Upstream commit:

commit 61d51c9c418dd3c77794519a5f66a02118b11326
Author: Pavel Hrdina <phrdina>
Date:   Wed Mar 8 13:02:37 2023 +0100

    domainsnapshot: add snapshotDeleteInProgress to RNG schema

Comment 4 yisun 2023-04-10 13:45:15 UTC

preverified with libvirt-9.2.0-1.el9.x86_64:
1. check rng file
# cat /usr/share/libvirt/schemas/domainsnapshot.rng
...
  <define name="snapshotDeleteInProgress">
    <optional>
      <element name="snapshotDeleteInProgress">
        <empty/>
      </element>
    </optional>
  </define>

…
                <ref name="storageSourceExtra"/>
                <ref name="snapshotDeleteInProgress"/>
…
                <ref name="storageSourceExtra"/>
                <ref name="snapshotDeleteInProgress"/>
              </interleave>

2. use same steps as comment0, from step 6 it works as follow:
[root@lenovo-sr630-14 ~]# virsh snapshot-delete vm1 s2
error: Failed to delete snapshot s2
error: operation failed: domain is no longer running

[root@lenovo-sr630-14 ~]# virsh snapshot-dumpxml vm1 s1 | grep InProgress -a10
<domainsnapshot>
  <name>s1</name>
  <state>disk-snapshot</state>
  <creationTime>1681133878</creationTime>
  <memory snapshot='no'/>
  <disks>
    <disk name='vda' snapshot='external' type='file'>
      <snapshotDeleteInProgress/>
      <driver type='qcow2'/>
      <source file='/var/lib/libvirt/images/jeos-27-x86_64.s1'/>
    </disk>
  </disks>
  <domain type='kvm'>
    <name>vm1</name>
    <uuid>6b71c477-6392-4305-be34-11a4672aab73</uuid>
    <metadata>
      <libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0">
        <libosinfo:os id="http://redhat.com/rhel/9.2"/>
[root@lenovo-sr630-14 ~]# virsh snapshot-dumpxml vm1 s1 --security-info|virt-xml-validate -
- validates

<=== it's correct now

Comment 8 yisun 2023-05-19 08:55:39 UTC

test with libvirt-9.3.0-2.el9.x86_64 and result is PASS

Comment 10 errata-xmlrpc 2023-11-07 08:30:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6409

Note You need to log in before you can comment on or make changes to this bug.