Spec URL: https://raw.githubusercontent.com/Vascom/hyperhdr/main/hyperhdr.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4636/98184636/hyperhdr-19.0.0.0-1.fc39.src.rpm Description: Open source ambient lighting implementation for television sets based on the video and audio streams analysis, using performance improvements especially for USB grabbers. With x11/wayland support.
I will review this package.
> Source1: https://raw.githubusercontent.com/mjansson/mdns/1.4.2/mdns.h Provides: bundled(mdns) = 1.4.2 > mkdir -p %{buildroot}/usr/share/hyperhdr/lut/ mkdir -p %{buildroot}%{_datadir}/%{name}/lut/
Copr build: https://copr.fedorainfracloud.org/coprs/build/5585828 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174746-hyperhdr/fedora-rawhide-x86_64/05585828-hyperhdr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://raw.githubusercontent.com/Vascom/hyperhdr/main/hyperhdr.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5746/98185746/hyperhdr-19.0.0.0-2.fc39.src.rpm Done.
> Unversioned so-files > -------------------- > hyperhdr: /usr/lib64/libsmartPipewire.so > hyperhdr: /usr/lib64/libsmartX11.so Please move these symlinks to -devel subpackage or simply remove them: rm -f %{_libdir}/libsmart{Pipewire,X11}.so
This unversioned symlinks used by main executable file and can't be removed.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "Boost Software License 1.0", "*No copyright* BSD 3-Clause License", "*No copyright* Public domain", "BSD 3-Clause License", "Apache License 2.0", "ISC License". 671 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/hyperhdr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 151040000 bytes in /usr/share hyperhdr-19.0.0.0-1.fc39.x86_64.rpm:151040000 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: hyperhdr-19.0.0.0-1.fc39.x86_64.rpm hyperhdr-debuginfo-19.0.0.0-1.fc39.x86_64.rpm hyperhdr-debugsource-19.0.0.0-1.fc39.x86_64.rpm hyperhdr-19.0.0.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptxrjaghu')] checks: 31, packages: 4 hyperhdr.x86_64: W: no-manual-page-for-binary hyperhdr hyperhdr.x86_64: W: no-manual-page-for-binary hyperhdr-remote hyperhdr.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libsmartPipewire.so hyperhdr.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libsmartX11.so 4 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 2.5 s Rpmlint (debuginfo) ------------------- Checking: hyperhdr-debuginfo-19.0.0.0-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1_tt6i0g')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 hyperhdr.x86_64: W: no-manual-page-for-binary hyperhdr hyperhdr.x86_64: W: no-manual-page-for-binary hyperhdr-remote hyperhdr.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libsmartPipewire.so hyperhdr.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libsmartX11.so 3 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 1.9 s Unversioned so-files -------------------- hyperhdr: /usr/lib64/libsmartPipewire.so hyperhdr: /usr/lib64/libsmartX11.so Source checksums ---------------- https://raw.githubusercontent.com/mjansson/mdns/1.4.2/mdns.h : CHECKSUM(SHA256) this package : 61b0c237e49dac7dade9082ced20e51150d918ecc9569d5f272c480985db9e26 CHECKSUM(SHA256) upstream package : 61b0c237e49dac7dade9082ced20e51150d918ecc9569d5f272c480985db9e26 https://github.com/awawa-dev/HyperHDR/archive/refs/tags/v19.0.0.0/hyperhdr-19.0.0.0.tar.gz : CHECKSUM(SHA256) this package : 3bb8c60224b8f5c564b7d07ebdf71159573b8ba3716460af3247a7f021cec249 CHECKSUM(SHA256) upstream package : 3bb8c60224b8f5c564b7d07ebdf71159573b8ba3716460af3247a7f021cec249 Requires -------- hyperhdr (rpmlib, GLIBC filtered): /bin/sh libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.4)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6SerialPort.so.6()(64bit) libQt6Sql.so.6()(64bit) libQt6Sql.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libX11.so.6()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmbedcrypto.so.7()(64bit) libmbedtls.so.14()(64bit) libmbedx509.so.1()(64bit) libpipewire-0.3.so.0()(64bit) libsmartPipewire.so.1()(64bit) libsmartX11.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libturbojpeg.so.0()(64bit) libturbojpeg.so.0(TURBOJPEG_1.0)(64bit) libturbojpeg.so.0(TURBOJPEG_1.1)(64bit) libturbojpeg.so.0(TURBOJPEG_1.2)(64bit) libturbojpeg.so.0(TURBOJPEG_1.4)(64bit) libturbojpeg.so.0(TURBOJPEG_2.0)(64bit) rtld(GNU_HASH) hyperhdr-debuginfo (rpmlib, GLIBC filtered): hyperhdr-debugsource (rpmlib, GLIBC filtered): Provides -------- hyperhdr: application() application(hyperhdr.desktop) hyperhdr hyperhdr(x86-64) libsmartPipewire.so.1()(64bit) libsmartX11.so.1()(64bit) hyperhdr-debuginfo: debuginfo(build-id) hyperhdr-debuginfo hyperhdr-debuginfo(x86-64) libsmartPipewire.so.1-19.0.0.0-1.fc39.x86_64.debug()(64bit) libsmartX11.so.1-19.0.0.0-1.fc39.x86_64.debug()(64bit) hyperhdr-debugsource: hyperhdr-debugsource hyperhdr-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name hyperhdr --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, R, fonts, Ocaml, SugarActivity, Perl, Haskell, Java, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Created attachment 1947479 [details] The .spec file difference from Copr build 5585828 to 5585899
Copr build: https://copr.fedorainfracloud.org/coprs/build/5585899 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2174746-hyperhdr/fedora-rawhide-x86_64/05585899-hyperhdr/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> [-]: License field in the package spec file matches the actual license. License: MIT AND LicenseRef-Fedora-Public-Domain AND Apache-2.0 AND BSL-1.0 AND BSD-3-Clause > [-]: Package must own all directories that it creates. Requires: hicolor-icon-theme > [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Suggestion: extract large data to a separate -common noarch subpackage.
These minor issues can be fixed during import. Package approved.
Requires: hicolor-icon-theme Added to spec.
The Pagure repository was created at https://src.fedoraproject.org/rpms/hyperhdr