Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2174975 - Pulp headers are overwritten incorrectly during manifest pull
Summary: Pulp headers are overwritten incorrectly during manifest pull
Keywords:
Status: CLOSED DUPLICATE of bug 2102078
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Container Management - Content
Version: 6.13.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: Unspecified
Assignee: Ian Ballou
QA Contact: addubey
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-02 19:14 UTC by Ian Ballou
Modified: 2023-03-02 21:29 UTC (History)
0 users

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-03-02 21:29:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 36157 0 Normal New Pulp headers are overwritten incorrectly during manifest pull 2023-03-02 19:20:03 UTC

Description Ian Ballou 2023-03-02 19:14:42 UTC
Description of problem:

This issue: https://bugzilla.redhat.com/show_bug.cgi?id=2102078#c13

was fixed in Pulp but not Satellite as a whole, because Katello is overwriting Pulp's headers. This header overwriting code is left over from the Pulp 2 days so we can likely take it out altogether and rely on the headers that we get from Pulp.

Related code is here: https://github.com/Katello/katello/blame/master/app/controllers/katello/api/registry/registry_proxies_controller.rb#L169

We should be able to take Pulp's headers and redirect them right to the client.

The particular issue seems to be caused by the mediaType being blank in the manifest body from Pulp, where Katello then assumes that the content-type should be either 'application/vnd.docker.distribution.manifest.v1+json' or 'application/vnd.docker.distribution.manifest.v1+prettyjws'.  However, the type could be "application/vnd.oci.image.manifest.v1+json".

Also, we are parsing the result as JSON, which should also be removed. It is unnecessary if we're simply redirecting Pulp's request. 

Version-Release number of selected component (if applicable):

All Pulp 3 Satellite

See https://bugzilla.redhat.com/show_bug.cgi?id=2102078 for more details.

This BZ blocks https://bugzilla.redhat.com/show_bug.cgi?id=2102078 !

Comment 1 Ian Ballou 2023-03-02 19:20:02 UTC
Created redmine issue https://projects.theforeman.org/issues/36157 from this bug

Comment 3 Bryan Kearney 2023-03-02 20:03:38 UTC
Upstream bug assigned to iballou

Comment 4 Bryan Kearney 2023-03-02 20:03:40 UTC
Upstream bug assigned to iballou

Comment 5 Ian Ballou 2023-03-02 21:29:25 UTC
Closing this as a dupe to better fit the BZ process.

*** This bug has been marked as a duplicate of bug 2102078 ***


Note You need to log in before you can comment on or make changes to this bug.