Spec URL: https://thunderbirdtr.fedorapeople.org/vkroots.spec SRPM URL: https://thunderbirdtr.fedorapeople.org/vkroots-0-1.20230303git2675710.fc38.src.rpm Description: A stupid simple method of making Vulkan layers, at home! Fedora Account System Username: thunderbirdtr
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5589456 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175162-vkroots/fedora-rawhide-x86_64/05589456-vkroots/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec review =========== > %global git_date %%(date +'%Y%m%d') This date needs to be fixed, not floating. Base it on the commit date. > Version: 0 > Release: 1.%{git_date}git%{shortcommit}%{?dist} Please use modern snapshot versioning. It'd look something like this: > Version: 0^%{git_date}git%{shortcommit} > Release: 1%{?dist} Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > Source: https://github.com/Joshua-Ashton/vkroots/archive/%{commit}/%{name}-%{shortcommit}.tar.gz The source can be simplified to "%{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz" > License: LGPL-2.1-only The license is "LGPL-2.1-or-later AND (Apache-2.0 or MIT)"
You're also missing "BuildRequires: meson".
Spec URL: https://thunderbirdtr.fedorapeople.org/vkroots.spec SRPM URL: https://thunderbirdtr.fedorapeople.org/vkroots-0%5e20230103git2675710-1.fc38.src.rpm
All done.
> BuildArch: noarch You can't have header only libraries be noarch.
I removed it.
> %post -p /sbin/ldconfig Not needed.
Created attachment 1947689 [details] The .spec file difference from Copr build 5589456 to 5589497
Copr build: https://copr.fedorainfracloud.org/coprs/build/5589497 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175162-vkroots/fedora-rawhide-x86_64/05589497-vkroots/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two things left: * You need to put everything into a devel subpackage * You need to file an upstream issue for vkroots to include copies of the licenses referenced, since I could not find any...
I added everything under devel subpackage. Github issue opened for license https://github.com/Joshua-Ashton/vkroots/issues/4
Created attachment 1947693 [details] The .spec file difference from Copr build 5589497 to 5589666
Copr build: https://copr.fedorainfracloud.org/coprs/build/5589666 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2175162-vkroots/fedora-rawhide-x86_64/05589666-vkroots/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Are you going to make an updated package snapshot that contains the licensing stuff now that's fixed upstream?
SPEC: https://download.copr.fedorainfracloud.org/results/frantisekz/vkroots/fedora-rawhide-x86_64/06211814-vkroots/vkroots.spec SRPM: https://download.copr.fedorainfracloud.org/results/frantisekz/vkroots/fedora-rawhide-x86_64/06211814-vkroots/vkroots-0%5E20230313gite554d4c-1.fc39.src.rpm Rebased to the latest snapshot.
This looks good to me, but because this BZ is owned by Onuralp, please create a new BZ and close this one as a dupe of that one. (Onuralp is not around at this time because he's dealing with other things...)
*** This bug has been marked as a duplicate of bug 2226546 ***