Bug 2175648 - gnome-tour segfaults
Summary: gnome-tour segfaults
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-tour
Version: 38
Hardware: x86_64
OS: Linux
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
Whiteboard: AcceptedFreezeException
Depends On:
Blocks: F38BetaFreezeException F38FinalBlocker
TreeView+ depends on / blocked
Reported: 2023-03-06 08:21 UTC by Luna Jernberg
Modified: 2023-03-07 19:43 UTC (History)
9 users (show)

Fixed In Version: gnome-tour-43.0-5.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-03-07 19:43:53 UTC
Type: Bug

Attachments (Terms of Use)

Description Luna Jernberg 2023-03-06 08:21:01 UTC
Downloaded the latest Fedora 38 Branched compose from yesterday: https://kojipkgs.fedoraproject.org/compose/branched/latest-Fedora-38/compose/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-38-20230305.n.0.iso and installed

and gnome-tour crashes/segfaults might be something to look into

$ gnome-tour
thread 'main' panicked at 'Failed to retrieve template child. Please check that it has been bound and has a #[template_child] attribute.', /usr/share/cargo/registry/gtk4-0.4.8/src/subclass/widget.rs:1305:17
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Comment 1 Kamil Páral 2023-03-06 09:22:56 UTC
I can confirm this. The dialog asking to you start the tour appears, but when you confirm you want to start the tour, nothing happens, the tour doesn't start. Proposing for a blocker discussion.

Comment 2 Kalev Lember 2023-03-06 09:32:53 UTC
I can confirm this as well. I tried downgrading from gnome-tour-43.0-4.fc38 to gnome-tour-43.0-3.fc38 locally and that made it work again.

Fabio, you did the gnome-tour-43.0-4.fc38 build, do you by any chance have any ideas why it might be suddenly broken?

Comment 3 Lukas Ruzicka 2023-03-06 09:40:21 UTC
Same situation here.

Comment 4 Kalev Lember 2023-03-06 09:57:15 UTC
I suspect it's rust-gtk4_0.4 version 0.4.8 where template instantiation is broken and needs https://github.com/gtk-rs/gtk4-rs/pull/1193/commits/a3613c7b9b39fd6a93931e3d4fcbc2291e53272c . I'm building a rust-gtk4_0.4 update and rebuilding gnome-tour against that and hopefully that's enough to make it work again.

Comment 5 Fabio Valentini 2023-03-06 10:00:12 UTC
The build I made only ensured that there package was built with correct compiler flags, but the flags were only changed on i686, ppc64le, and s390x. So the only differences that could lead to this crash are the versions of the dependencies (and Rust compiler) that gnome-tour was built against. I'll compare the buildroots.

Comment 6 Fabio Valentini 2023-03-06 10:06:18 UTC
Ah, looks like you've already figured it out. The new hotness doesn't file "new version!" bugs for compat packages, so I didn't even know that 0.4.9 was released. I'll check the other gtk-rs projects for new releases on stable beaches as well ...

Side note: There's also a bug in gtk4 4.9.4 that currently affects gsk4 bindings, which might also break packages: https://github.com/gtk-rs/gtk4-rs/issues/1316
It appears the fix was included in 4.10.0, but that's not available for f38 yet.

Comment 7 Kalev Lember 2023-03-06 11:22:12 UTC
Thanks! Yep, I got this one figured out, just waiting on builds to finish now.

It would be nice if we could somehow map the compat packages in release-monitoring.org, but I don't think it has a good way of doing that right now. Maybe we should ask someone who works on the release monitoring code to help with coming up with a way.

As for gtk4, I don't know why it's not updated in F38. amigadave is doing the GNOME package updates this cycle, not me, and I am not very up to date with details there. In my quick testing I didn't seem to run into this though so maybe it's good enough for gnome-tour for F38 Beta. I am sure we'll get a gtk4 update eventually after the freeze.

Comment 8 Fedora Update System 2023-03-06 11:46:38 UTC
FEDORA-2023-e4f78876bf has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e4f78876bf

Comment 9 Fedora Update System 2023-03-06 11:47:05 UTC
FEDORA-2023-be6f2b5356 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-be6f2b5356

Comment 10 Fedora Update System 2023-03-06 11:49:35 UTC
FEDORA-2023-e4f78876bf has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 František Zatloukal 2023-03-06 11:56:28 UTC
Thanks Kalev, FEDORA-2023-be6f2b5356 fixes the issue!

Comment 12 František Zatloukal 2023-03-06 14:06:04 UTC
Discussed in ticket: https://pagure.io/fedora-qa/blocker-review/issue/1074

The decision to classify this bug as an AcceptedFreezeException was made:

"A lot of users/reviewers would hit this with the Beta Release and it can't be fixed with an update".

Comment 13 Luna Jernberg 2023-03-06 14:09:07 UTC
gnome-tour is still broken in todays compose

good to see it being worked on :)

Comment 14 František Zatloukal 2023-03-06 14:15:57 UTC
Also as per ticket voting, removing Beta Blocker proposal.

Comment 15 Fedora Update System 2023-03-07 02:03:09 UTC
FEDORA-2023-be6f2b5356 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-be6f2b5356

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Luna Jernberg 2023-03-07 07:49:59 UTC
FEDORA-2023-be6f2b5356 fixes it for me

Comment 17 Riya Bisht 2023-03-07 10:11:23 UTC
gnome-tour was found broken but FEDORA-2023-be6f2b5356 fixes it for me :)

Comment 18 Fedora Update System 2023-03-07 19:43:53 UTC
FEDORA-2023-be6f2b5356 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.