Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/05598721-autorestic/autorestic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/05598721-autorestic/autorestic-1.7.7-1.fc39.src.rpm Description: Config driven, easy backup cli for restic Fedora Account System Username: mhayden
This should be okay for review now that BZ 2175886 for the dependency is complete.
> # Upstream does not provide tests. > %bcond_with check I think it does, there're some _test.go files in the repo.
Trying to unretire a required dependency: golang-github-robfig-cron https://src.fedoraproject.org/rpms/golang-github-robfig-cron/pull-request/1
Got the tests working now. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/05798672-autorestic/autorestic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/05798672-autorestic/autorestic-1.7.7-1.fc39.src.rpm
(In reply to Major Hayden 🤠 from comment #4) > Got the tests working now. They're still disabled, you need %bcond_without check
Oh, boy. That will teach me to have too many windows open at the same time. Thank you. 🤦♂️
Tests running now. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/05798937-autorestic/autorestic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/05798937-autorestic/autorestic-1.7.7-1.fc39.src.rpm
Created attachment 1957905 [details] The .spec file difference from Copr build 5798698 to 5799427
This should be unblocked now that BZ 2188618 is done.
Hello, I stumbled on this review request as I was investigating the state of the Restic package. Autorestic looks like it could be useful, as Restic lacks configuration files. Are you aware that golang-github-robfig-cron is orphan and will get retired again in a few days?
Thanks for that heads up, Bjorn. That one looks pretty easy to maintain. I'll pick it up.
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/06220184-autorestic/autorestic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/06220184-autorestic/autorestic-1.7.7-1.fc39.src.rpm Updated to include auto-completions.
> # Generated by go2rpm 1.9.0 > > %bcond_without check minor cosmetic change, but go2rpm template doesn't have that empty line > Name: autorestic It's preferred to use the following after %gometa: > %global goname doctl > (...) > Name: %{goname} You can use the `--name` flag in go2rpm to automate it. > %gopkg > (...) > %gopkginstall > (...) > %gopkgfiles You can remove these to make autorestic only a binary package and not to include `golang-github-cupcakearmy-autorestic-devel` package.
Thanks, Mikel. Updated with those changes. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/06220361-autorestic/autorestic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/06220361-autorestic/autorestic-1.7.7-1.fc39.src.rpm
Created attachment 1980482 [details] The .spec file difference from Copr build 6220252 to 6220367
Added patch for fixing the cmd tests. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/06220551-autorestic/autorestic.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/autorestic/fedora-rawhide-x86_64/06220551-autorestic/autorestic-1.7.7-1.fc39.src.rpm
Created attachment 1980506 [details] The .spec file difference from Copr build 6220367 to 6220562
Approved, but please change to `Patch` instead of `Patch0`. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [x] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
Thank you, Mikel. I'll make a note of the to-do items here.
The Pagure repository was created at https://src.fedoraproject.org/rpms/autorestic
FEDORA-2023-c378ff87de has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c378ff87de
FEDORA-2023-c378ff87de has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.