Created attachment 1948602 [details] Select instanceType Description of problem: Below are the items were discussed to improve the dialog "Select instanceType" in the add volume modal: 1. remove the badge "VMCI", same for preference dialog above 2. add descriptive text to each and need to increase the dialog size to do so 3. remove "highperformance" and "server", don't know why they're in the list 4. sort the "Size" dropdown list Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
1. "Remove the badge VMCI" - AFAIU from @fdeutsch there can be two types of badges here, so differentiation is required. TMO we can use grouping in the dropdown menu to separate the two types.
Guohua, 3. "highperformance" and "server" InstanceTypes are there because we fetch them from the server, same as the other ones. That's something we cannot influence in the UI. Maybe later there will be even more of them?... 4. not reproducible in 4.13, sorted already some time ago
(In reply to Hilda Stastna from comment #2) > Guohua, > > 3. "highperformance" and "server" InstanceTypes are there because we fetch > them from the server, same as the other ones. That's something we cannot > influence in the UI. Maybe later there will be even more of them?... yes, it's from the backend. From comment #1, it seems it have two groups, maybe one for VMCI and one for these. > 4. not reproducible in 4.13, sorted already some time ago Look at it again, it should not be sorted by alphabetically but by the actual size, eg: large -> xlarge -> 2xlarge
Note that the problems mentioned in the Description are no longer present in Add volume modal. Also note that there is no any design that would support removing "VMCP" badge from Preference drop down, see: https://docs.google.com/document/d/1HTF6_H2WDXwlVy7RnrHH28dzFlhNIa15Hhpeoyg2R0Q/edit# This is the default behavior in our UI as the badge represents the type of the resource being displayed. You can see it in other drop downs across whole UI. For Default InstanceType drop down removing "VMCI" badge is appropriate, because there is a special design for this drop down's content in the design doc added above. However, the problems from Description of this bug are still present in "Edit volume metadata" modal, accessible from Bootable volumes list, so we need to fix the described problems only there. Doc for Edit volume metadata dialog: https://docs.google.com/document/d/15Cv54978AZKeukkurvkFN1YEx_kBsm_3XcmLey_cgZY/edit#heading=h.tj7met9j9m0q
verified on kubevirt-console-plugin-rhel9-container-v4.14.0-1047
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:6817