This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2176740 - [RHEL 9] tools/rpcdebug/rpcdebug.c: get_flags() fails to check read() return properly
Summary: [RHEL 9] tools/rpcdebug/rpcdebug.c: get_flags() fails to check read() return ...
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: nfs-utils
Version: 9.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Steve Dickson
QA Contact: Yongcheng Yang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-09 06:12 UTC by Zhi Li
Modified: 2023-09-23 11:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-23 11:34:51 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   RHEL-7931 0 None Migrated None 2023-09-23 11:34:48 UTC
Red Hat Issue Tracker RHELPLAN-151184 0 None None None 2023-03-09 06:15:24 UTC

Description Zhi Li 2023-03-09 06:12:10 UTC 
Description of problem:
If libcall read(sysfd, buffer, sizeof(buffer) returns 0, it may lead to an underflow later in buffer[len - 1].

...snip...
248 static unsigned int
249 get_flags(char *module)
250 {
251         char    buffer[256], filename[256];
252         int     sysfd, len;
253
254         snprintf(filename, 256, "/proc/sys/sunrpc/%s_debug", module);
255
256         if ((sysfd = open(filename, O_RDONLY)) < 0) {
257                 perror(filename);
258                 exit(1);
259         }
260         if ((len = read(sysfd, buffer, sizeof(buffer))) < 0) {   // <- if len returns 0 here
261                 perror("read");
262                 exit(1);
263         }
264         close(sysfd);
265         buffer[len - 1] = '\0';    // <- buffer underflow
266
267         return strtoul(buffer, NULL, 0);
268 }
...snip...

Version-Release number of selected component (if applicable):
nfs-utils-2.5.4-18.el9
Comment 2 Yongcheng Yang 2023-06-07 14:44:21 UTC 
It has been merged to the upstream nfs-utils now:

commit a746c35822e557766d1871ec976490a71e6962d9
Author: Zhi Li <yieli>
Date:   Wed Apr 5 12:08:10 2023 -0400

    rpcdebug: avoid buffer underflow if read() returns 0

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2176740

    Signed-off-by: Zhi Li <yieli>
    Signed-off-by: Steve Dickson <steved>
Comment 6 RHEL Program Management 2023-09-23 11:32:18 UTC 
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.
Comment 7 RHEL Program Management 2023-09-23 11:34:51 UTC 
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.
Note You need to log in before you can comment on or make changes to this bug.