Bug 2176745 - [RFE] Source available” badges are not aligned
Summary: [RFE] Source available” badges are not aligned
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.13.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.14.0
Assignee: Hilda Stastna
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-09 06:47 UTC by Guohua Ouyang
Modified: 2023-11-08 14:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-08 14:05:04 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Badges are not aligned (228.55 KB, image/png)
2023-03-14 09:06 UTC, Yifat Menchik
no flags Details
Source available badge is close to the BS column (175.22 KB, image/png)
2023-03-20 15:45 UTC, Yifat Menchik
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 1191 0 None open Bug 2176745: Align badges in Boot source column 2023-03-24 22:18:55 UTC
Red Hat Issue Tracker CNV-26710 0 None None None 2023-03-09 06:49:25 UTC
Red Hat Product Errata RHSA-2023:6817 0 None None None 2023-11-08 14:05:20 UTC

Description Guohua Ouyang 2023-03-09 06:47:53 UTC
Description of problem:
In template list view page, the “Source available” badges are not aligned. It happens in two places:
1. Virtualization -> Templates
2. Virtualization- > Catalog -> change the grid view to list view

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Hilda Stastna 2023-03-13 19:35:33 UTC
Guohua,

are you sure this is a bug? The badges don't have their own column, and are designed to be placed just next to the boot source. 
It would be problematic to align them somehow without having a specific column for them anyway.
And so IMO this is not a bug and it should be closed. But in case there was some design change to align the badges somehow (maybe by creating another column?),
please provide more info about the expected results. Thanks.

Comment 3 Guohua Ouyang 2023-03-14 00:31:18 UTC
When Yifat mention this bug to me, I also don't see it's a bug, so I opened it as a RFE.
But I strongly agreed if can make them aligned, we should do that. Because each time when I look at the template list either in catalog or template page, I have bad feelings. These unaligned badges with a shadow blue color are easy to catch by the eyeballs.

Regarding the design, can the badge be placed at the right of the column?

Comment 4 Yifat Menchik 2023-03-14 09:06:13 UTC
Created attachment 1950537 [details]
Badges are not aligned

hstastna gouyang I think this view could be improved if we align the badges and place them to the right of the Boot source column.

Comment 5 Hilda Stastna 2023-03-14 15:12:48 UTC
Thanks for the suggestions, folks. So let's align the badges to the right of the column.

Comment 7 Hilda Stastna 2023-03-15 12:28:59 UTC
Hi Yifat,

please check the attachment I've just added. Is this the result we expect? I tried to align the badges to the right of the column.
Note that column is a bit wide because another label "Clone in progress" can occur in the same column,
so the column needs to have enough space for both badge and the label.
Thanks a lot!

Comment 8 Yifat Menchik 2023-03-20 15:45:53 UTC
Created attachment 1952123 [details]
Source available badge is close to the BS column

Comment 9 Yifat Menchik 2023-03-20 15:46:59 UTC
@hstastna can we do something like in this mockup "Source available badge is close to the BS column"?

Comment 10 Hilda Stastna 2023-03-24 17:57:57 UTC
I do like this last suggestion. Let's try to align the badges/labels simply to the left within the BS column. 
Thanks Yifat a lot for your help!

Comment 11 Guohua Ouyang 2023-03-31 00:35:44 UTC
verified with v4.14.0-755

Comment 14 errata-xmlrpc 2023-11-08 14:05:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6817


Note You need to log in before you can comment on or make changes to this bug.