Bug 2177192 - probe nfsd.proc.lookup broken on rawhide
Summary: probe nfsd.proc.lookup broken on rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: systemtap
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Frank Ch. Eigler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-10 10:58 UTC by Martin Cermak
Modified: 2023-08-10 18:43 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-10 18:43:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Martin Cermak 2023-03-10 10:58:15 UTC
[root@rawh ipv6-tapset-support]# stap -vp4 'probe nfsd.proc.lookup { printf("%s %s\n", client_ip, filename) }'
Input file 'probe nfsd.proc.lookup { printf("%s %s\n", client_ip, filename) }' is missing.
Pass 1: parsed user script and 493 library scripts using 141080virt/111920res/16000shr/95160data kb, in 210usr/40sys/258real ms.
Pass 1: parse failed.  [man error::pass1]
[root@rawh ipv6-tapset-support]# stap -vp4 -e 'probe nfsd.proc.lookup { printf("%s %s\n", client_ip, filename) }'
Pass 1: parsed user script and 493 library scripts using 141080virt/111792res/15872shr/95160data kb, in 200usr/50sys/255real ms.
semantic error: resolution failed in alias expansion builder

semantic error: while resolving probe point: identifier 'nfsd' at /usr/share/systemtap/tapset/linux/nfsd.stp:313:7
        source:       nfsd.proc2.lookup
                      ^

semantic error: no match

Pass 2: analyzed script: 4 probes, 55 functions, 4 embeds, 1 global using 414196virt/388488res/20236shr/368276data kb, in 6330usr/750sys/7124real ms.
Pass 2: analysis failed.  [man error::pass2]
[root@rawh ipv6-tapset-support]# uname -r; rpm -qf `which stap`
6.2.0-0.rc8.57.fc39.x86_64
systemtap-devel-4.8-5.fc39.x86_64
systemtap-client-4.8-5.fc39.x86_64
[root@rawh ipv6-tapset-support]#

Comment 1 Martin Cermak 2023-03-10 11:02:44 UTC
Test coverage: tests/Regression/ipv6-tapset-support

Comment 2 William Cohen 2023-08-10 18:43:26 UTC
The reproducer compiles using current systemtap in rawhide with the following patch:

commit 532ab9fdfb0aba455697a57da0b6d398b591437c
Author: William Cohen <wcohen>
Date:   Tue Apr 25 09:44:51 2023 -0400

    Allow nfsd.stp tapset to work on kernels with CONFIG_NFSD_V2 unset
    
    Some of the newer Fedora kernels have CONFIG_NFSD_V2 unset (*).  The
    nfsd.stp tapset was requiring various NFSD V2 probes points to exist.
    These required probes caused examples like nfsd-trace and nfsdtop
    build failures.  Making the NFSD V2 probes optional allows the
    nfsd.stp tapset to work on these kernels.
    
    * https://src.fedoraproject.org/rpms/kernel/c/897c8e8d51d02e159116d60fe5bb5dde79150162?branch=rawhide

$ rpm -q systemtap
systemtap-5.0~pre16891249ge891a37e-0.2.fc39.x86_64
$ stap -vp4 -e 'probe nfsd.proc.lookup { printf("%s %s\n", client_ip, filename) }'
Pass 1: parsed user script and 541 library scripts using 543548virt/297528res/16128shr/280620data kb, in 610usr/70sys/1310real ms.
Pass 2: analyzed script: 4 probes, 16 functions, 4 embeds, 1 global using 823688virt/572992res/17728shr/560760data kb, in 2940usr/150sys/5019real ms.
Pass 3: translated to C into "/tmp/stapgYFzTz/stap_788d77e20b9652b674b364fcd6ace0fe_8804_src.c" using 823688virt/573120res/17856shr/560760data kb, in 810usr/70sys/1795real ms.
/home/wcohen/.systemtap/cache/78/stap_788d77e20b9652b674b364fcd6ace0fe_8804.ko
Pass 4: compiled C into "stap_788d77e20b9652b674b364fcd6ace0fe_8804.ko" in 19860usr/2450sys/43949real ms.


Note You need to log in before you can comment on or make changes to this bug.