Bug 2177274 - Prevent ironic protected node tests from orphaning test nodes
Summary: Prevent ironic protected node tests from orphaning test nodes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-ironic-tests-tempest
Version: 16.2 (Train)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z6
: 16.2 (Train on RHEL 8.4)
Assignee: Jason Paroly
QA Contact: Martin Kopec
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-10 16:47 UTC by Jason Paroly
Modified: 2023-11-08 19:19 UTC (History)
4 users (show)

Fixed In Version: python-ironic-tests-tempest-2.3.0-2.20220709024918.el8ost
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-08 19:18:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 871301 0 None MERGED Prevent protected node tests from orphaning test nodes 2023-03-13 17:42:32 UTC
Red Hat Issue Tracker OSP-23043 0 None None None 2023-03-10 16:49:23 UTC
Red Hat Product Errata RHBA-2023:6307 0 None None None 2023-11-08 19:19:07 UTC

Description Jason Paroly 2023-03-10 16:47:11 UTC
Description of problem:

While investigating failures where four orphaned nodes
were observed after running the tempest plugin against an
operating environment, it was discovered that each node
was created by the TestProtectedNode class. A review of the
logs indicated that tearDown() was being called, but
resource_cleanup was never being called which houses the
unified resource cleanup. Upon reviewing the pattern
in tempest itself, generally resource_cleanup is used
instead of teardown, however with our class structure,
that doesn't seem to work, so instead we just
explicitly call to unset the protected state for each
node.

We should now be consistent, and the four TestProtectedNode
tests should no longer orphan four nodes when run.

Also added some additional logging to help spotting cases
where orphaned nodes might be occuring, in order to aid
in troubleshooting when reviewing Tempest logs.


We need this for 16.1 and 16.2

Fix needing backport:
https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/871301

Comment 7 Martin Kopec 2023-09-27 08:17:46 UTC
The Fixed in version package contains the required fix. The package is also available in the latest puddle.

Comment 12 errata-xmlrpc 2023-11-08 19:18:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.2.6 (Train) bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6307


Note You need to log in before you can comment on or make changes to this bug.