Description of problem: While investigating failures where four orphaned nodes were observed after running the tempest plugin against an operating environment, it was discovered that each node was created by the TestProtectedNode class. A review of the logs indicated that tearDown() was being called, but resource_cleanup was never being called which houses the unified resource cleanup. Upon reviewing the pattern in tempest itself, generally resource_cleanup is used instead of teardown, however with our class structure, that doesn't seem to work, so instead we just explicitly call to unset the protected state for each node. We should now be consistent, and the four TestProtectedNode tests should no longer orphan four nodes when run. Also added some additional logging to help spotting cases where orphaned nodes might be occuring, in order to aid in troubleshooting when reviewing Tempest logs. We need this for 16.1 and 16.2 Fix needing backport: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/871301
The Fixed in version package contains the required fix. The package is also available in the latest puddle.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Red Hat OpenStack Platform 16.2.6 (Train) bug fix and enhancement advisory), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2023:6307