Bug 2177329 - fedpkg import srpm doesn't work with rpmautospec
Summary: fedpkg import srpm doesn't work with rpmautospec
Alias: None
Product: Fedora
Classification: Fedora
Component: python-rpmautospec
Version: 37
Hardware: All
OS: All
Target Milestone: ---
Assignee: Otto Liljalaakso
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2023-03-10 22:07 UTC by Gerald Cox
Modified: 2023-11-23 01:25 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed:
Type: Bug

Attachments (Terms of Use)

Description Gerald Cox 2023-03-10 22:07:31 UTC
Description of problem:

My workflow for uploading packages is:
$ git add -u
$ fedpkg clog
$ git commit -F clog
$ fedpkg import updated.srpm
$ git commit --am
fedpkg push
fedpkg build

When trying this with a package that has been converted to use rpmautospec, it brakes the import srpm functionality.  

I receive the following message:

Could not execute import_srpm: SRPM was processed by rpmautospec (specfile           msmtp.spec" was analyzed)

fedpkg import is a key function so this needs to be corrected

Comment 1 Gerald Cox 2023-03-10 22:52:42 UTC
I found this:  https://pagure.io/rpkg/issue/641
The first comment proposes a solution.  When can this be implemented, and in the meantime, what is
the mitigation workflow without having to backout of rpmautospec?

Comment 2 Otto Liljalaakso 2023-04-02 12:19:18 UTC
Regarding workaround:

You do not explain how you created updated.srpm,
but because you encountered this problem,
I assume you ran 'fedpkg srpm' or some other fedpkg command that internally ran the same.
If so, try to created it with 'rpmbuild -bs' instead.
Fedpkg does rpmautospec processing internally, while rpmbuild does not,
and the desired result is importing unprocessed changelogs.

I will assign this issue to me.
I have been meaning to tackle this issue for a long time already.
Unfortunately, I have not have *any* time for Fedora in weeks, so I have not been able to proceed.
(I will feel hurt at all if somebody fixes this in the meantime.)

My idea of fixing this is explained here:

Comment 3 Aoife Moloney 2023-11-23 01:25:52 UTC
This message is a reminder that Fedora Linux 37 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '37'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 37 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Note You need to log in before you can comment on or make changes to this bug.