Created attachment 1951049 [details]
A partial patch to fix some implicit function declarations

This package has several implicitly defined functions due to which it cannot build in C99 mode.

Somewhat related, it also occasionally declares function prototypes right before use instead of including the prototypes via a header. Here's an example from scalapack-2.2.0/scalapack-2.2.0/BLACS/SRC/blacs_map_.c:

#if (INTFACE == C_CALL)
void Cblacs_gridmap(Int *ConTxt, Int *usermap, Int ldup, Int nprow0, Int npcol0)
#else
F_VOID_FUNC blacs_gridmap_(Int *ConTxt, Int *usermap, Int *ldup, Int *nprow0,
                           Int *npcol0)
#endif
{
   void Cblacs_pinfo(Int *, Int *);
   void Cblacs_get(Int, Int, Int *);
   ...

...the above two functions are then used later on in the function.

Building this package as C99 leads to several implicit function declaration errors, and in some cases fixing them would presumably involve declarations (currently missed) such as the example above.

I am attaching a partial patch to fix up some implicit function declarations, but eventually decided that it is easier to simply build this package as C89 for now.

C99 porting should be deferred until it's fixed upstream and rebased.