Bug 2179075 - Review Request: libprometheus-cpp - Prometheus Client Library C++
Summary: Review Request: libprometheus-cpp - Prometheus Client Library C++
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-16 15:14 UTC by Kaleb KEITHLEY
Modified: 2023-04-06 13:44 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-06 13:44:51 UTC
Type: Bug
Embargoed:
vitaly: fedora-review+


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2023-03-16 15:14:56 UTC
Description of problem:
(lib)prometheus-cpp is a dependency for Prometheus support in nfs-ganesha, which is often a component in ceph deployments.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

https://kojipkgs.fedoraproject.org//work/tasks/3735/98763735/libprometheus-cpp-1.1.0-1.fc39.src.rpm

or 

https://kkeithle.fedorapeople.org/libprometheus-cpp/libprometheus-cpp.spec
https://kkeithle.fedorapeople.org/libprometheus-cpp/libprometheus-cpp-1.1.0-1.fc39.src.rpm

Comment 1 Kaleb KEITHLEY 2023-03-16 15:15:26 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "Apache License 2.0",
     "*No copyright* Apache License 2.0", "BSD 0-Clause License". 132 files
     have unknown license. Detailed output of licensecheck in
     /home/kkeithle/review-libprometheus-cpp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: libprometheus-cpp-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-devel-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-debuginfo-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-1.1.0-1.fc39.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6_xmmyiq')]
checks: 31, packages: 4

libprometheus-cpp.spec: E: superfluous-%clean-section
libprometheus-cpp.x86_64: E: explicit-lib-dependency libxcrypt
 4 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 0.8 s 




Rpmlint (debuginfo)
-------------------
Checking: libprometheus-cpp-debuginfo-1.1.0-1.fc39.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpur5f6hbg')]
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3

libprometheus-cpp.x86_64: E: explicit-lib-dependency libxcrypt
 3 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 1.1 s 



Source checksums
----------------
https://github.com/jupp0r/prometheus-cpp/archive/v1.1.0/prometheus-cpp-1.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : 397544fe91e183029120b4eebcfab24ed9ec833d15850aae78fd5db19062d13a
  CHECKSUM(SHA256) upstream package : 397544fe91e183029120b4eebcfab24ed9ec833d15850aae78fd5db19062d13a


Requires
--------
libprometheus-cpp (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libcivetweb-cpp.so.1.15.0()(64bit)
    libcivetweb.so.1.15.0()(64bit)
    libcurl.so.4()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libprometheus-cpp-core.so.1.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxcrypt
    libz.so.1()(64bit)
    rtld(GNU_HASH)

libprometheus-cpp-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    cmake-filesystem(x86-64)
    libprometheus-cpp(x86-64)
    libprometheus-cpp-core.so.1.1()(64bit)
    libprometheus-cpp-pull.so.1.1()(64bit)
    libprometheus-cpp-push.so.1.1()(64bit)
    pkgconfig(libcurl)
    pkgconfig(prometheus-cpp-core)
    pkgconfig(zlib)

libprometheus-cpp-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
libprometheus-cpp:
    libprometheus-cpp
    libprometheus-cpp(x86-64)
    libprometheus-cpp-core.so.1.1()(64bit)
    libprometheus-cpp-pull.so.1.1()(64bit)
    libprometheus-cpp-push.so.1.1()(64bit)

libprometheus-cpp-devel:
    cmake(prometheus-cpp)
    libprometheus-cpp-devel
    libprometheus-cpp-devel(x86-64)
    pkgconfig(prometheus-cpp-core)
    pkgconfig(prometheus-cpp-pull)
    pkgconfig(prometheus-cpp-push)

libprometheus-cpp-debuginfo:
    debuginfo(build-id)
    libprometheus-cpp-core.so.1.1.0-1.1.0-1.fc39.x86_64.debug()(64bit)
    libprometheus-cpp-debuginfo
    libprometheus-cpp-debuginfo(x86-64)
    libprometheus-cpp-pull.so.1.1.0-1.1.0-1.fc39.x86_64.debug()(64bit)
    libprometheus-cpp-push.so.1.1.0-1.1.0-1.fc39.x86_64.debug()(64bit)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -n libprometheus-cpp
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: SugarActivity, Perl, R, Python, PHP, Ocaml, Java, Haskell, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 3 Vitaly 2023-03-20 15:36:27 UTC
> Name:           lib%{sname}

Name: prometheus-cpp

> %global _hardened_build 1

All builds are hardened by default. You can safely remove this line.

> %undefine _debugsource_packages
> %undefine _debuginfo_subpackages

Debuginfo must be generated. Remove these lines.

> %package -n %{name}1

Why adding 1 suffix here?

> %setup -q -n %{sname}-%{version}

After changing Name, simply use this:

%autosetup

> %{cmake} . \

Remove dot.

> export GCC_COLORS=
> export VERBOSE=1

Can be removed. %cmake will automatically enable verbose mode.

> %cmake_build %{?_smp_mflags}

Remove %{?_smp_mflags}.

> %clean

Legacy and prohibited. Must be removed.

> %{_libdir}/%{name}-*.so.*

You must add soversion here.

> %dir %{_includedir}/prometheus
> %{_includedir}/prometheus/*

Should be simplified:

%{_includedir}/prometheus/

> %dir %{_libdir}/cmake/%{sname}
> %{_libdir}/cmake/%{sname}/%{sname}*.cmake

Should be simplified:

%{_libdir}/cmake/%{name}

Comment 4 Vitaly 2023-03-20 15:39:23 UTC
> -DCMAKE_INSTALL_PREFIX=%{_prefix} \

Should be removed. Will be set by %cmake.

> -DBUILD_SHARED_LIBS:BOOL=ON \

Should be removed too. Will be set by %cmake.

> -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir} \

Should be removed. Will be handled by GNUInstallDirs.

Comment 5 Vitaly 2023-03-20 15:53:47 UTC
> %package -n %{name}1
> Summary:        Prometheus Client C++ Libraries
> Requires:       %{name}%{?_isa} = %{version}-%{release}

> %description -n %{name}1
> Development files for prometheus-cpp library.

> %files -n %{name}1
> %{_libdir}/%{name}-*.so.*

Remove this subpackage and move everything to the base package.

> %{_libdir}/%{name}-*.so.*

%{_libdir}/%{name}-*.so.1*

Comment 6 Vitaly 2023-03-20 15:54:58 UTC
> %{_libdir}/%{name}-*.so.1*

%{_libdir}/lib%{name}-*.so.1*

> %{_libdir}/%{name}-*.so

%{_libdir}/lib%{name}-*.so

Comment 7 Vitaly 2023-03-20 15:56:38 UTC
> -DENABLE_TESTING:BOOL=OFF

If the project has tests and they can be executed without network access, they should be executed. Switch to `-DENABLE_TESTING:BOOL=ON` and add the following:

%check
%ctest

Comment 8 Kaleb KEITHLEY 2023-03-20 19:20:35 UTC
(In reply to Vitaly Zaitsev from comment #3)
> > Name:           lib%{sname}
> 
> Name: prometheus-cpp

This is a libraries-only package. The other libraries-only packages that I have packaged – nfs-ganesha ntirp, as libntirpc; Apache ORC, as liborc; and Apache Arrow, as libarrow — have passed review this way. I haven't checked every libfoo package but I suspect there are a few others like this. I know that some of the X11 libs are like this. And maybe not especially compelling, but I'll toss it out there, Red Hat's downstream Ceph product has decided (independent of me) on libprometheus-cpp too. 

All other changes requested above have been addressed.

Updated files at

https://kojipkgs.fedoraproject.org//work/tasks/3120/98943120/libprometheus-cpp-1.1.0-1.fc39.src.rpm

or

https://kkeithle.fedorapeople.org/libprometheus-cpp/libprometheus-cpp-1.1.0-1.fc39.src.rpm
https://kkeithle.fedorapeople.org/libprometheus-cpp/libprometheus-cpp.spec

Comment 9 Vitaly 2023-03-20 19:51:51 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "Apache License 2.0",
     "*No copyright* Apache License 2.0", "BSD 0-Clause License". 132 files
     have unknown license. Detailed output of licensecheck in
     /var/lib/copr-rpmbuild/results/libprometheus-cpp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: libprometheus-cpp-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-devel-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-debuginfo-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-debugsource-1.1.0-1.fc39.x86_64.rpm
          libprometheus-cpp-1.1.0-1.fc39.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmprxqb7muw')]
checks: 31, packages: 5

libprometheus-cpp.x86_64: E: explicit-lib-dependency libxcrypt
 5 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.6 s 




Rpmlint (debuginfo)
-------------------
Checking: libprometheus-cpp-debuginfo-1.1.0-1.fc39.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp8c783o2j')]
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

libprometheus-cpp.x86_64: E: explicit-lib-dependency libxcrypt
 4 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.9 s 



Source checksums
----------------
https://github.com/jupp0r/prometheus-cpp/archive/v1.1.0/prometheus-cpp-1.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : 397544fe91e183029120b4eebcfab24ed9ec833d15850aae78fd5db19062d13a
  CHECKSUM(SHA256) upstream package : 397544fe91e183029120b4eebcfab24ed9ec833d15850aae78fd5db19062d13a


Requires
--------
libprometheus-cpp (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libcivetweb-cpp.so.1.15.0()(64bit)
    libcivetweb.so.1.15.0()(64bit)
    libcurl.so.4()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libprometheus-cpp-core.so.1.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxcrypt
    libz.so.1()(64bit)
    rtld(GNU_HASH)

libprometheus-cpp-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    cmake-filesystem(x86-64)
    libprometheus-cpp(x86-64)
    libprometheus-cpp-core.so.1.1()(64bit)
    libprometheus-cpp-pull.so.1.1()(64bit)
    libprometheus-cpp-push.so.1.1()(64bit)
    pkgconfig(libcurl)
    pkgconfig(prometheus-cpp-core)
    pkgconfig(zlib)

libprometheus-cpp-debuginfo (rpmlib, GLIBC filtered):

libprometheus-cpp-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libprometheus-cpp:
    libprometheus-cpp
    libprometheus-cpp(x86-64)
    libprometheus-cpp-core.so.1.1()(64bit)
    libprometheus-cpp-pull.so.1.1()(64bit)
    libprometheus-cpp-push.so.1.1()(64bit)

libprometheus-cpp-devel:
    cmake(prometheus-cpp)
    libprometheus-cpp-devel
    libprometheus-cpp-devel(x86-64)
    pkgconfig(prometheus-cpp-core)
    pkgconfig(prometheus-cpp-pull)
    pkgconfig(prometheus-cpp-push)

libprometheus-cpp-debuginfo:
    debuginfo(build-id)
    libprometheus-cpp-core.so.1.1.0-1.1.0-1.fc39.x86_64.debug()(64bit)
    libprometheus-cpp-debuginfo
    libprometheus-cpp-debuginfo(x86-64)
    libprometheus-cpp-pull.so.1.1.0-1.1.0-1.fc39.x86_64.debug()(64bit)
    libprometheus-cpp-push.so.1.1.0-1.1.0-1.fc39.x86_64.debug()(64bit)

libprometheus-cpp-debugsource:
    libprometheus-cpp-debugsource
    libprometheus-cpp-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name libprometheus-cpp --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: R, Python, fonts, Perl, Ocaml, SugarActivity, Haskell, Java, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 10 Vitaly 2023-03-20 19:52:48 UTC
> License:        MIT

# pull/src/detail/base64.h - 0BSD
License: MIT AND 0BSD

This minor issue can be fixed during import. Package approved.

Comment 11 Fedora Admin user for bugzilla script actions 2023-03-20 21:36:08 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libprometheus-cpp


Note You need to log in before you can comment on or make changes to this bug.