SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05656013-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05656013-openvkl/openvkl-1.3.2-1.fc39.src.rpm Description: Intel® Open Volume Kernel Library (Intel® Open VKL) is a collection of high-performance volume computation kernels, developed at Intel. The target users of Open VKL are graphics application engineers who want to improve the performance of their volume rendering applications by leveraging Open VKL’s performance-optimized kernels, which include volume traversal and sampling functionality for a variety of volumetric data formats. The kernels are optimized for the latest Intel® processors with support for SSE, AVX, AVX2, and AVX-512 instructions, and for ARM processors with support for NEON instructions.
Copr build: https://copr.fedorainfracloud.org/coprs/build/5656074 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/05656074-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
ExclusiveArch added SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05679093-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05679093-openvkl/openvkl-1.3.2-1.fc39.src.rpm
Created attachment 1951838 [details] The .spec file difference from Copr build 5656074 to 5679168
Copr build: https://copr.fedorainfracloud.org/coprs/build/5679168 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/05679168-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Could you list the shared libraries in %files section with a full SONAME <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files> without globs?
Thanks for the comment Petr SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05852072-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05852072-openvkl/openvkl-1.3.2-1.fc39.src.rpm
Created attachment 1960151 [details] The .spec file difference from Copr build 5679168 to 5852236
Copr build: https://copr.fedorainfracloud.org/coprs/build/5852236 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/05852236-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
URL and Source0 are Ok. TODO: Source0 address does not match what upstream advertise (<https://github.com/openvkl/openvkl/archive/refs/tags/v1.3.2.tar.gz>) at <https://github.com/openvkl/openvkl/releases>. Please use that URL listed byt the upstream. Source0 archive (SHA-512: 07dad3cf13c4aae18883b02dc6b0e41ba95fffea3f76c2f77ef3b8b55c5e7a8cfe666f88fb8b079cc07af11915ee4292406e42d11123c0f66f1a10413328a911) is original. Ok. FIX: Remove the registered marks (Intel®) from Summary and Description texts <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description>. Licenses found (the files are only examples): Apache-2.0: utility/vdb/include/openvkl/utility/vdb/VdbVolumeBuffers.h BSL-1.0: testing/external/catch.hpp MIT: testing/external/half.hpp MIT OR Unlicense: examples/interactive/imgui-1.83/imstb_truetype.h OFL-1.1-RFN: examples/interactive/imgui-1.83/misc/fonts/Karla-Regular.ttf Zlib: examples/interactive/imgui-1.83/examples/libs/usynergy/uSynergy.h TODO: If any of the files is built and packaged into a binary RPM package, their licenses must be mentioned in License tag. Also a corresponding subset of third-party-programs*.txt files should be packaged with %license macro instead of %doc macro. FIX: Build-require "cmake >= 3.1", not "cmake3" (<https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/>, CMakeLists.txt:6). TODO: Constrain 'rkcommon-devel' build-dependency with '>= 1.11.0' (CMakeLists.txt:66). TODO: Constrain 'embree-devel' build-dependency with '>= 4.0.0' (CMakeLists.txt:74). TODO: Constrain 'openvdb-devel' build-dependency wiht '>= 7.0.0' (utility/vdb/CMakeLists.txt:42). TODO: Are tbb-devel and zlib-devel indeed required? They are only referred from superbuild/CMakeLists.txt which is not used. I will continue with the review later.
Hello again, Source and trade marks fixed and we're not adding any of those examples to the package still need to add the licenses ? tbb-devel and zlib-devel mentioned in superbuild but those deps comes from rkcommon + openvdb cmake files. Thank you for your time and understanding. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05870221-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/05870221-openvkl/openvkl-1.3.2-1.fc39.src.rpm
Created attachment 1961990 [details] The .spec file difference from Copr build 5852236 to 5870421
Copr build: https://copr.fedorainfracloud.org/coprs/build/5870421 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/05870421-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
If those examples are not contained in a binary RPM package (e.g. named in %files section), than we do not list them in License tag. I'm sorry, I still did not find time to finish the review.
FIX: The current Source0 URL returns "404 Not Found" error. You need to remove the "%{name}-" part. > tbb-devel and zlib-devel mentioned in superbuild but those deps comes from rkcommon + openvdb cmake files. If openvdb cmake file requires tbb-devel, then openvdb-devel RPM package must run-require tbb-devel. It's not so: $ rpm -q --requires openvdb-devel libopenvdb.so.10.0()(64bit) openvdb-libs(x86-64) = 10.0.1-5.fc39 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Looking at openvdb headers: $ grep -hr '# *include' /usr/include/openvdb | sort -u | grep tbb #include <tbb/blocked_range2d.h> #include <tbb/blocked_range3d.h> #include <tbb/blocked_range.h> #include <tbb/blocked_range.h> // for tbb::split #include <tbb/blocked_range.h> // threading #include <tbb/combinable.h> #include <tbb/concurrent_hash_map.h> /// #include <tbb/concurrent_hash_map.h> #include <tbb/concurrent_vector.h> #include <tbb/enumerable_thread_specific.h> #include <tbb/null_mutex.h> #include <tbb/parallel_for.h> #include <tbb/parallel_for.h> // threading #include <tbb/parallel_invoke.h> #include <tbb/parallel_reduce.h> #include <tbb/parallel_sort.h> #include <tbb/partitioner.h> #include <tbb/spin_mutex.h> #include <tbb/task_arena.h> #include <tbb/task_group.h> #include <tbb/task.h> They indeed include tbb headers. Hence I conclude it's a bug in openvdb-devel. The dependency on tbb-devel should be added to openvdb-devel. Not to openvkl.spec. In RPM we specify direct dependencies, not transitive dependencies. Or can you see any other reason, why openvkl should directly depend on tbb-devel? With zlib it's even simpler: Neither openvdb-devel headers, nor openvkl sources include zlib headers. So the dependency shouldn't be there at all. rkcommon-devel is the same case. In my opinion both openvdb and rkcommon are wrongly packaged. Bugs to add a dependency on tbb-devel and cmake files not to require zlib should be open against them.
Hello Petr, I updated openvdb and openvkl. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/06001630-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/06001630-openvkl/openvkl-1.3.2-1.fc39.src.rpm
Created attachment 1968845 [details] The .spec file difference from Copr build 5870421 to 6001669
Copr build: https://copr.fedorainfracloud.org/coprs/build/6001669 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/06001669-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
FIX: Use "%{_prefix}" instead of "/usr" in "-DOpenVDB_ROOT=/usr" argument. FIX: Add "BSL-1.0" to License tag because of /usr/bin/vklTests packaged in openvkl binary package. /usr/bin/vklTests is built from testing/apps/vklTests.cpp which includes testing/external/catch.hpp which is BSL-1.0. FIX: Add "MIT" to License tag because /usr/bin/vklTests is built from tests/vectorized_sampling.cpp which includes testing/openvkl_testing.h which includes testing/volume/OpenVdbVolume.h which includes testing/external/half.hpp which is MIT. Don't forget to redefine a License tag for the devel subpackage so that it does not mention BSL-1.0 and MIT. All tests pass. Ok. $ rpmlint openvkl.spec ../SRPMS/openvkl-1.3.2-1.fc39.src.rpm ../RPMS/x86_64/openvkl-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 openvkl.x86_64: W: no-manual-page-for-binary vklTests openvkl-devel.x86_64: W: no-documentation ========= 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.7 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm -rwxr-xr-x 1 root root 2021672 Jun 5 02:00 /usr/bin/vklTests drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/34 lrwxrwxrwx 1 root root 41 Jun 5 02:00 /usr/lib/.build-id/34/3e0702221a970e32864340133d592df37015bd -> ../../../../usr/lib64/libopenvkl.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/45 lrwxrwxrwx 1 root root 61 Jun 5 02:00 /usr/lib/.build-id/45/aceb3f3f8552403af8e6384bd898137a199cdb -> ../../../../usr/lib64/libopenvkl_module_cpu_device_4.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/4c lrwxrwxrwx 1 root root 59 Jun 5 02:00 /usr/lib/.build-id/4c/bca0200125773eb33295e2aac821b59bdae9e2 -> ../../../../usr/lib64/libopenvkl_module_cpu_device.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/80 lrwxrwxrwx 1 root root 28 Jun 5 02:00 /usr/lib/.build-id/80/f310f2ca98a52d254a825b5b4d1fa3edc8b344 -> ../../../../usr/bin/vklTests drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/83 lrwxrwxrwx 1 root root 61 Jun 5 02:00 /usr/lib/.build-id/83/69b939c2e4e7b99a2859b49cf9df38394cc622 -> ../../../../usr/lib64/libopenvkl_module_cpu_device_8.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib/.build-id/8d lrwxrwxrwx 1 root root 62 Jun 5 02:00 /usr/lib/.build-id/8d/77a2677445857c3eb89ae9b32cf324c6abb400 -> ../../../../usr/lib64/libopenvkl_module_cpu_device_16.so.1.3.2 lrwxrwxrwx 1 root root 19 Jun 5 02:00 /usr/lib64/libopenvkl.so.1 -> libopenvkl.so.1.3.2 -rwxr-xr-x 1 root root 183168 Jun 5 02:00 /usr/lib64/libopenvkl.so.1.3.2 lrwxrwxrwx 1 root root 37 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device.so.1 -> libopenvkl_module_cpu_device.so.1.3.2 -rwxr-xr-x 1 root root 20632 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device.so.1.3.2 lrwxrwxrwx 1 root root 40 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_16.so.1 -> libopenvkl_module_cpu_device_16.so.1.3.2 -rwxr-xr-x 1 root root 8411648 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_16.so.1.3.2 lrwxrwxrwx 1 root root 39 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_4.so.1 -> libopenvkl_module_cpu_device_4.so.1.3.2 -rwxr-xr-x 1 root root 9549696 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_4.so.1.3.2 lrwxrwxrwx 1 root root 39 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_8.so.1 -> libopenvkl_module_cpu_device_8.so.1.3.2 -rwxr-xr-x 1 root root 10078496 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_8.so.1.3.2 drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/share/doc/openvkl -rw-r--r-- 1 root root 15168 Feb 28 19:14 /usr/share/doc/openvkl/CHANGELOG.md -rw-r--r-- 1 root root 131049 Feb 28 19:14 /usr/share/doc/openvkl/README.md -rw-r--r-- 1 root root 520 Feb 28 19:14 /usr/share/doc/openvkl/SECURITY.md drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/share/licenses/openvkl -rw-r--r-- 1 root root 11358 Feb 28 19:14 /usr/share/licenses/openvkl/LICENSE.txt -rw-r--r-- 1 root root 20741 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs-Embree.txt -rw-r--r-- 1 root root 23100 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs-OSPRay.txt -rw-r--r-- 1 root root 15991 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs-TBB.txt -rw-r--r-- 1 root root 36021 Feb 28 19:14 /usr/share/licenses/openvkl/third-party-programs.txt $ rpm -q -lv -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl -rw-r--r-- 1 root root 404 Feb 28 19:14 /usr/include/openvkl/VKLBackgroundUndefined.h -rw-r--r-- 1 root root 2630 Feb 28 19:14 /usr/include/openvkl/VKLDataType.h -rw-r--r-- 1 root root 688 Feb 28 19:14 /usr/include/openvkl/VKLError.h -rw-r--r-- 1 root root 722 Feb 28 19:14 /usr/include/openvkl/VKLFilter.h -rw-r--r-- 1 root root 745 Feb 28 19:14 /usr/include/openvkl/VKLFormat.h -rw-r--r-- 1 root root 399 Feb 28 19:14 /usr/include/openvkl/VKLLogLevel.h -rw-r--r-- 1 root root 862 Feb 28 19:14 /usr/include/openvkl/VKLTemporalFormat.h -rw-r--r-- 1 root root 1250 Feb 28 19:14 /usr/include/openvkl/common.h -rw-r--r-- 1 root root 388 Feb 28 19:14 /usr/include/openvkl/common.isph -rw-r--r-- 1 root root 1103 Feb 28 19:14 /usr/include/openvkl/data.h -rw-r--r-- 1 root root 1746 Feb 28 19:14 /usr/include/openvkl/device.h -rw-r--r-- 1 root root 200 Feb 28 19:14 /usr/include/openvkl/device.isph -rw-r--r-- 1 root root 3838 Feb 28 19:14 /usr/include/openvkl/ispc_cpp_interop.h -rw-r--r-- 1 root root 9678 Feb 28 19:14 /usr/include/openvkl/iterator.h -rw-r--r-- 1 root root 11506 Feb 28 19:14 /usr/include/openvkl/iterator.isph -rw-r--r-- 1 root root 1101 Feb 28 19:14 /usr/include/openvkl/max_iterator_size.h -rw-r--r-- 1 root root 240 Feb 28 19:14 /usr/include/openvkl/module.h -rw-r--r-- 1 root root 2114 Feb 28 19:14 /usr/include/openvkl/observer.h -rw-r--r-- 1 root root 484 Feb 28 19:14 /usr/include/openvkl/openvkl.h -rw-r--r-- 1 root root 288 Feb 28 19:14 /usr/include/openvkl/openvkl.isph -rw-r--r-- 1 root root 1096 Feb 28 19:14 /usr/include/openvkl/parameters.h -rw-r--r-- 1 root root 5816 Feb 28 19:14 /usr/include/openvkl/sampler.h -rw-r--r-- 1 root root 8098 Feb 28 19:14 /usr/include/openvkl/sampler.isph -rw-r--r-- 1 root root 7741 Feb 28 19:14 /usr/include/openvkl/types.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility/temporal_compression -rw-r--r-- 1 root root 4385 Feb 28 19:14 /usr/include/openvkl/utility/temporal_compression/douglas_peucker.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility/usda -rw-r--r-- 1 root root 3319 Feb 28 19:14 /usr/include/openvkl/utility/usda/usda.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/utility/vdb -rw-r--r-- 1 root root 5796 Feb 28 19:14 /usr/include/openvkl/utility/vdb/InnerNodes.h -rw-r--r-- 1 root root 19788 Feb 28 19:14 /usr/include/openvkl/utility/vdb/OpenVdbGrid.h -rw-r--r-- 1 root root 30482 Feb 28 19:14 /usr/include/openvkl/utility/vdb/VdbVolumeBuffers.h drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/include/openvkl/vdb -rw-r--r-- 1 root root 10334 Feb 28 19:14 /usr/include/openvkl/vdb.h -rw-r--r-- 1 root root 5883 Jun 5 02:00 /usr/include/openvkl/vdb/topology.h -rw-r--r-- 1 root root 5877 Jun 5 02:00 /usr/include/openvkl/vdb/topology_1.h -rw-r--r-- 1 root root 5871 Jun 5 02:00 /usr/include/openvkl/vdb/topology_2.h -rw-r--r-- 1 root root 5863 Jun 5 02:00 /usr/include/openvkl/vdb/topology_3.h -rw-r--r-- 1 root root 218 Jun 5 02:00 /usr/include/openvkl/version.h -rw-r--r-- 1 root root 1658 Feb 28 19:14 /usr/include/openvkl/volume.h -rw-r--r-- 1 root root 937 Feb 28 19:14 /usr/include/openvkl/volume.isph drwxr-xr-x 2 root root 0 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2 -rw-r--r-- 1 root root 1753 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvklConfig.cmake -rw-r--r-- 1 root root 2762 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvklConfigVersion.cmake -rw-r--r-- 1 root root 3614 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvkl_Exports-release.cmake -rw-r--r-- 1 root root 5865 Jun 5 02:00 /usr/lib64/cmake/openvkl-1.3.2/openvkl_Exports.cmake lrwxrwxrwx 1 root root 15 Jun 5 02:00 /usr/lib64/libopenvkl.so -> libopenvkl.so.1 lrwxrwxrwx 1 root root 33 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device.so -> libopenvkl_module_cpu_device.so.1 lrwxrwxrwx 1 root root 36 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_16.so -> libopenvkl_module_cpu_device_16.so.1 lrwxrwxrwx 1 root root 35 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_4.so -> libopenvkl_module_cpu_device_4.so.1 lrwxrwxrwx 1 root root 35 Jun 5 02:00 /usr/lib64/libopenvkl_module_cpu_device_8.so -> libopenvkl_module_cpu_device_8.so.1 File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 glibc >= 2.37.9000-10 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.32)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.38)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libembree4.so.4()(64bit) 1 libgcc_s.so.1()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgcc_s.so.1(GCC_3.3.1)(64bit) 1 libm.so.6()(64bit) 1 libm.so.6(GLIBC_2.2.5)(64bit) 1 libm.so.6(GLIBC_2.27)(64bit) 1 libm.so.6(GLIBC_2.29)(64bit) 1 libopenvdb.so.10.0()(64bit) 1 libopenvkl.so.1()(64bit) 1 librkcommon.so.1()(64bit) 1 libstdc++.so.6()(64bit) 1 libstdc++.so.6(CXXABI_1.3)(64bit) 1 libstdc++.so.6(CXXABI_1.3.13)(64bit) 1 libstdc++.so.6(CXXABI_1.3.3)(64bit) 1 libstdc++.so.6(CXXABI_1.3.8)(64bit) 1 libstdc++.so.6(CXXABI_1.3.9)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.11)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.14)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.15)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.18)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.19)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.20)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.21)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.22)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.26)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.29)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.30)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.32)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.5)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4.9)(64bit) 1 libtbb.so.2()(64bit) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) $ rpm -q --requires -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 cmake-filesystem(x86-64) 1 libopenvkl.so.1()(64bit) 1 libopenvkl_module_cpu_device.so.1()(64bit) 1 libopenvkl_module_cpu_device_16.so.1()(64bit) 1 libopenvkl_module_cpu_device_4.so.1()(64bit) 1 libopenvkl_module_cpu_device_8.so.1()(64bit) 1 openvkl(x86-64) = 1.3.2-1.fc39 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Run-require "openvdb-devel >= 7.0.0" by openvkl-devel (/usr/include/openvkl/utility/vdb/OpenVdbGrid.h:10). FIX: Run-require "rkcommon-devel >= 1.11.0" by openvkl-devel (/usr/include/openvkl/utility/vdb/VdbVolumeBuffers.h:9). $ rpm -q --provides -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 libopenvkl.so.1()(64bit) 1 libopenvkl_module_cpu_device.so.1()(64bit) 1 libopenvkl_module_cpu_device_16.so.1()(64bit) 1 libopenvkl_module_cpu_device_4.so.1()(64bit) 1 libopenvkl_module_cpu_device_8.so.1()(64bit) 1 openvkl = 1.3.2-1.fc39 1 openvkl(x86-64) = 1.3.2-1.fc39 $ rpm -q --provides -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 cmake(openvkl) = 1.3.2 1 openvkl-devel = 1.3.2-1.fc39 1 openvkl-devel(x86-64) = 1.3.2-1.fc39 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/openvkl{,-devel}-1.3.2-1.fc39.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 39 (https://koji.fedoraproject.org/koji/taskinfo?taskID=101834461). Ok. Otherwise, the package is in line with Fedora and CMake packaging guidelines. Please correct the FIX items and provide a new spec file.
Hello Petr, thank you for the comments SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/06006626-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/06006626-openvkl/openvkl-1.3.2-1.fc39.src.rpm
Created attachment 1969148 [details] The .spec file difference from Copr build 6001669 to 6006724
Copr build: https://copr.fedorainfracloud.org/coprs/build/6006724 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/06006724-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
$ rpmlint openvkl.spec ../SRPMS/openvkl-1.3.2-1.fc39.src.rpm ../RPMS/x86_64/openvkl-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 openvkl.x86_64: W: no-manual-page-for-binary vklTests openvkl-devel.x86_64: W: no-documentation ========= 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.8 s ======== rpmlint is Ok. $ rpm -q --qf '%{license}\n' -p ../RPMS/x86_64/openvkl-1.3.2-1.fc39.x86_64.rpm Apache-2.0 AND BSL-1.0 AND MIT Ok. $ rpm -q --qf '%{license}\n' -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm Apache-2.0 AND BSL-1.0 AND MIT FIX: openvkl-devel is now "Apache-2.0 AND BSL-1.0 AND MIT". That's incorrect because that package does not contain any BSL-1.0 or MIT files. A License tag is inherited from the main package. Please add "License: Apache-2.0" to openvkl-devel subpackage to fix it. $ rpm -q --requires -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm | sort -f | uniq -c 1 cmake-filesystem(x86-64) 1 libopenvkl.so.1()(64bit) 1 libopenvkl_module_cpu_device.so.1()(64bit) 1 libopenvkl_module_cpu_device_16.so.1()(64bit) 1 libopenvkl_module_cpu_device_4.so.1()(64bit) 1 libopenvkl_module_cpu_device_8.so.1()(64bit) 1 openvdb-devel >= 7.0.0 1 openvkl(x86-64) = 1.3.2-1.fc39 1 rkcommon-devel >= 1.11.0 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/x86_64/openvkl-{,devel-}1.3.2-1.fc39.x86_64.rpm Binary dependencies are resolvable. Ok. Please correct the FIX item and provide an updates spec file.
Thank you Petr SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/06008274-openvkl/openvkl.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/oneapi/fedora-rawhide-x86_64/06008274-openvkl/openvkl-1.3.2-1.fc39.src.rpm
Created attachment 1969291 [details] The .spec file difference from Copr build 6006724 to 6008454
Copr build: https://copr.fedorainfracloud.org/coprs/build/6008454 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2179404-openvkl/fedora-rawhide-x86_64/06008454-openvkl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
$ rpmlint openvkl.spec ../SRPMS/openvkl-1.3.2-1.fc39.src.rpm ../RPMS/x86_64/openvkl-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 openvkl.x86_64: W: no-manual-page-for-binary vklTests openvkl-devel.x86_64: W: no-documentation ========= 5 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 1.7 s ======== rpmlint is Ok. $ rpm -q --qf '%{license}\n' -p ../RPMS/x86_64/openvkl-devel-1.3.2-1.fc39.x86_64.rpm Apache-2.0 Ok. The package is in line with Fedora packaging guidelines. Thanks for you hard work on this package. Resolution: Package APPROVED.
Thank you :)
The Pagure repository was created at https://src.fedoraproject.org/rpms/openvkl