Description of problem: We added a metric name linter, that will check if the metric name meets the best practices requirements see: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2291. The linter failed with the following errors: - kubevirt_hco_out_of_band_modifications_count: counter metrics should have 'total' suffix. - kubevirt_hco_out_of_band_modifications_count: non-histogram and non-summary metrics should not have 'count' or 'sum' - kubevirt_hco_unsafe_modification_count: non-histogram and non-summary metrics should not have 'count' or 'sum' suffix. We should updates the names: - `kubevirt_hco_out_of_band_modifications_count` to `kubevirt_hco_out_of_band_modifications_total`. - `kubevirt_hco_unsafe_modification_count` to `kubevirt_hco_number_of_unsafe_modifications`. Version-Release number of selected component (if applicable): 4.13 How reproducible: 100% Steps to Reproduce: 1. open a pr 2. see the sanity check 3. see the metric name linter errors Actual results: metric names are not valid. Expected results: metrics names are valid.
Please rememeber to doublecheck if documentation will autogenerate. In first pass of the fix please consider deprecating 'old' names and introduce new ones to finally get rid of the 'old' names in the following release. Please also remember to check if 'old' names are not used to show any of the metrics somewhere in the UI.
@sradco, Is this a Known Issue or a Changed Feature for the 4.13 release notes? Thanks.
@aspauldi The inconsistencies were found when we run the new metrics name linter. We consider this as a bug. There should be a deprecation notice for the metrics listed in this bug.
As of CNV-v4.14.0.rhel9-1576, I see `kubevirt_hco_unsafe_modification_count` has been renamed to `kubevirt_hco_unsafe_modifications ` and `kubevirt_hco_out_of_band_modifications_count` has been renamed to `kubevirt_hco_out_of_band_modifications_total`. However, the doc text field values are not correct (see the first rename).