Spec URL: http://people.atrpms.net/~hdegoede/alphabet-soup.spec SRPM URL: http://people.atrpms.net/~hdegoede/alphabet-soup-1.1-1.fc7.src.rpm Description: Guide your worm through the soup to spell words and earn points. Play the way you like with several game mode selections. Words are chosen from one of three included dictionaries, or import your own. --- Note this requires alfont whose review is bug 217998
Build fails with: ncds.c:8:20: error: aldumb.h: No such file or directory Review blocked due to build failure.
==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - meets packaging guidelines - licensed with open source compatible license - license field matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream: 364fe30c53a86217db37f53308604f74 as11src.zip - successfully compiles and builds on FC6 x86_64 X missing BR: dumb-devel - no locales - no shared libraries - package is not relocatable - package owns all directories it creates X package uses directory not pulled in through Requires must require hicolor-icons - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no need for devel subpackage - no .la files - contains proper .desktop file - does not own files or directories owned by other packages ==== MUST FIX ==== - Add dumb-devel to BR - requires hicolor-icon-theme package
(In reply to comment #2) > ==== MUST FIX ==== > - Add dumb-devel to BR Good catch! > - requires hicolor-icon-theme package Will I ever learn? :( Both fixed, new version is here: Spec URL: http://people.atrpms.net/~hdegoede/alphabet-soup.spec SRPM URL: http://people.atrpms.net/~hdegoede/alphabet-soup-1.1-2.fc7.src.rpm
All MUST items fixed. APPROVED.
Thanks! Imported and build requested, closing.