Bug 2180790 - [RFE] Add "inspect" button to open the metrics query in virtualization metrics pages
Summary: [RFE] Add "inspect" button to open the metrics query in virtualization metric...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.13.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.14.0
Assignee: Tal Nisan
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-22 10:04 UTC by Guohua Ouyang
Modified: 2023-11-08 14:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-08 14:05:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
inspect example (101.95 KB, image/png)
2023-03-22 10:04 UTC, Guohua Ouyang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker CNV-27204 0 None None None 2023-03-22 10:07:09 UTC
Red Hat Product Errata RHSA-2023:6817 0 None None None 2023-11-08 14:05:48 UTC

Description Guohua Ouyang 2023-03-22 10:04:38 UTC
Created attachment 1952705 [details]
inspect example

Description of problem:
Currently, there is no button "inspect" in virtualization metrics pages.
So when there is no data, user don't know what's wrong and what's the query, add the inspect button there allow user to click it and get the query details.

Ref to the attachment for example.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Guohua Ouyang 2023-04-17 10:16:52 UTC
Move this to high as it's a very import improvement to let the user understand what's the query is and why no graph shows on UI.

Comment 2 Ronen 2023-07-25 15:39:16 UTC
Guohua, I guess you are referring to the VM Metric tab and only when there is no data (when there is data, you can click the graph to inspect it), is this correct?

Comment 3 Guohua Ouyang 2023-07-26 00:33:35 UTC
(In reply to Ronen from comment #2)
> Guohua, I guess you are referring to the VM Metric tab and only when there
> is no data (when there is data, you can click the graph to inspect it), is
> this correct?

If we add this inspect button, it should be added there no matter the graph is showing or not.

> when there is data, you can click the graph to inspect it
This is kind of unexpected result as it opens another page without a hint.
While clicking the graph in Observe -> Dashboards, it does not open the metrics until clicking the inspect button. 
Maybe we should remove the link in the graph after adding the inspect button.

Comment 4 Ronen 2023-07-26 06:28:11 UTC
This is the behavior across all OCP: If you view the metrics tab of any pod, clicking a graph will take you to the Metrics page.
The issue we have is that when the graph has no data, we do not enable the click, while for pods it will still take you to the Metrics page.
WDYT?

Comment 5 Guohua Ouyang 2023-07-26 07:27:52 UTC
Ah, I just checked the behavior on Pod, and it takes you to metrics details when there is no graph.
I agree with you to enable the click even there is no data would solve the problem we have.

Comment 6 Guohua Ouyang 2023-08-17 02:04:13 UTC
verified on kubevirt-console-plugin-rhel9-container-v4.14.0-2606

Comment 9 errata-xmlrpc 2023-11-08 14:05:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.14.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6817


Note You need to log in before you can comment on or make changes to this bug.