Bug 2181282 - apron: Use _fortify_level to manage fortification
Summary: apron: Use _fortify_level to manage fortification
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: apron
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2158232
TreeView+ depends on / blocked
 
Reported: 2023-03-23 14:49 UTC by Siddhesh Poyarekar
Modified: 2023-04-01 00:16 UTC (History)
2 users (show)

Fixed In Version: apron-0.9.13-17.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-01 00:16:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Siddhesh Poyarekar 2023-03-23 14:49:08 UTC
It looks like apron tries to drop _FORTIFY_SOURCE from Makefile.config using a regex:

sed -i 's/-Wp,-D_FORTIFY_SOURCE=2/-Werror=format-security &/' Makefile.config

This no longer works and apron now gets built with _FORTIFY_SOURCE=3. Is disabling fortification necessary?  If yes, then please using the new %_fortify_level macro instead:

https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md

Comment 1 Jerry James 2023-03-23 15:24:53 UTC
No, it isn't removing the fortify flag.  Notice the '&' character on the right hand side.  It's using the fortify flag to find a place to reinsert -Werror=format-security, which upstream's configure script removes.  I'll find a different anchor for reinserting that flag, or else bludgeon the configure script into not removing it in the first place.

Thanks for bringing this to my attention.

Comment 2 Fedora Update System 2023-03-23 16:32:49 UTC
FEDORA-2023-c3f47099c2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c3f47099c2

Comment 3 Fedora Update System 2023-03-24 03:01:13 UTC
FEDORA-2023-c3f47099c2 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c3f47099c2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2023-04-01 00:16:16 UTC
FEDORA-2023-c3f47099c2 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.