Spec URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils-0.6.3-1.src.rpm Description: <description here> This package is a set of chemical utils. Three programs are avaible: * A 3D molecular structure viewer (GChem3Viewer). * A Chemical calculator (GChemCalc). * A periodic table of the elements application (GChemTable). Package builds fine inside mock, and the only warnings that rpmlint returns are lacks of documentation for devel and mozplugin packages. This is my first package (apart from museek+ that still waits for review), so it looks like I need a sponsor.
Well, interesting package. From a quick view: A. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Requires: - for -mozplugin package: Why does this require pkgconfig? - for -devel package: Please check /usr/lib/pkgconfig/gcu.pc ---------------------------------------------------------- Requires: libglade-2.0 libgnomeui-2.0 libgnomeprintui-2.2 gtkglext-1.0 openbabel-2.0 ---------------------------------------------------------- This means that this (-devel) package requires: --------------------------------------------------------- (libglade2-devel : required by libgnomeui-devel so this is redundant). libgnomeui-devel libgnomeprintui22-devel gtkglext-devel openbabel-devel --------------------------------------------------------- Otherwise we get a error like: --------------------------------------------------------- [tasaka1@localhost ~]$ pkg-config --cflags gcu Package openbabel-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `openbabel-2.0.pc' to the PKG_CONFIG_PATH environment variable Package 'openbabel-2.0', required by 'Gnome Chemistry Utils', not found --------------------------------------------------------- * Documentation - Files under docs/reference/html are rather large in total and most (or all?) files are automatically generated by doxygen. I think these files should be in -devel package. * Desktop files - Please use 'desktop-file-install' and add 'fedora' as vendor tag (then add 'desktop-file-utils' to BuildRequires) - Would you ask upstream to include icons for GUI desktop? * Timestamps - Well, -devel package contains a lot of header files so keeping timestamps is highly preferable as * it shows if vendor (like you) have modified the original files * it shows when the files are created So keep timestamps, at least for header files. Usually, -------------------------------------------------------- make INSTALL="install -p" install -------------------------------------------------------- plays the trick. - /usr/bin/install -c -m 644 Use "%{__install} -c -p -m 644" to keep timestamps, use macros. B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : (Okay) C. Other things I have noticed: * test -z $RPM_BUILD_ROOT%{_datadir}/mime/packages || - This is redundant because it is apparently not zero length.
Parag, if you don't mind, I want to assign this bug to myself as a sponsor.
(In reply to comment #2) > Parag, if you don't mind, I want to assign this bug to myself > as a sponsor. Sure Go Ahead. You are always welcome for aa long as its a review for FE-NEEDSPONSOR. Becuase i don't have sponsor status.
(In reply to comment #3) > Sure Go Ahead. You are always welcome for aa long as its a review for > FE-NEEDSPONSOR. Becuase i don't have sponsor status. Thank you.
Spec URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils-0.6.3-2.src.rpm New release: - Fixed Requires for -devel and -mozplugin packages - Moved files in docs/reference/html to the devel package - Install .desktop files using desktop-file-install - Removed redundant stuff - Preserve timestamps I'll ask upstream for icons. BTW, why some .desktop files need to be installed using desktop-file-install and some do not (or are all these packages wrong)?
The icons enquiry has been filed: https://savannah.nongnu.org/bugs/index.php?18443
Well, before checking 0.6.3-2: (I am currently taking dinner and I will check it later) (In reply to comment #5) > BTW, why some .desktop files need to be installed > using desktop-file-install and some do not (or are all these packages wrong)? My recognition is that all packages in Fedora Core/Extras are required to use desktop-file-utils when installing desktop files. At least all packages I reviewed are modified to use desktop-file-utils when it tries to install desktop files without it. So under my recognition packages installing desktop files without desktop-file-utils are all wrong. NOTE: there are some desktop-*like* files which are installed without desktop-file-utils (e.g. in xscreensaver-extras-gss)
This software supports chemical-mime-data, so I'll try to wrap up a package. Feel free to continue the review in the meantime.
It was not that hard. Spec URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils-0.6.3-1.src.rpm New release: - Added doxygen to BuildRequires - Added support for chemical-mime-data Now it is blocked by bug #218210
Oops... SRPM URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils-0.6.3-3.src.rpm
Well: * BuildRequires: chemical-mime-data Should this be 'BuildRequires' or 'Requires'? * By the way, please remove unnecessary comments like: ------------------------------------------------ #mkdir -p -- $RPM_BUILD_ROOT%{_datadir}/mime/packages ------------------------------------------------ which are no longer used to make spec file more legible. Note: --add-category=X-Fedora Well, FE packaging committee made a semi(?)-conclusion that this should be removed because * desktop-file-utils 0.11 does _NOT_ allow this so * anyway this is deprecated and of no use However, now rawhide is desktop-file-utils 0.12 and this again _ALLOWS_ --add-category=X-Fedora ...... I think that '--add-category=X-Fedora' should be removed until the argument that "--add-category=X-Fedora should be revived" arises, however, it seems that this (--add-category=X-Fedora) is okay for now??
Spec URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils.spec SRPM URL: http://www.republika.pl/belegdol/rpmstuff/gnome-chemistry-utils-0.6.3-4.src.rpm New release: - Removed obsolete stuff - Fixed support for chemical-mime-data - Removed --add-category X-Fedora from desktop-file-install command I think that chemical-mime-data should be present both in BuildRequires and in Requires, as it is checked for presence by configure (and probably should be installed for this whole operation to make sense).
Okay. --------------------------------------------- This package (gnome-chemistry-utils) is APPROVED by me.
Removing FE-NEEDSPONSOR (bug 218210)
Thanks very much for sponsorship. Package imported, FC-5 and FC-6 branches requested.