Spec URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-subset-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-subset-fonts-2.004-1.fc37.src.rpm Description: Google Noto Sans CJK Subset Fonts Fedora Account System Username:pwu
Copr build: https://copr.fedorainfracloud.org/coprs/build/5711128 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181978-google-noto-sans-cjk-subset-fonts/fedora-rawhide-x86_64/05711128-google-noto-sans-cjk-subset-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* SIL Open Font License 1.1", "SIL Open Font License 1.1". 6 files have unknown license. Detailed output of licensecheck in /home/test/2181978-google-noto- sans-cjk-subset-fonts/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Installation errors ------------------- INFO: mock.py version 3.5 starting (python version = 3.11.2, NVR = mock-3.5-2.fc38)... Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.5 INFO: Mock Version: 3.5 Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.5 INFO: Mock Version: 3.5 Finish: chroot init INFO: installing package(s): /builddir/google-noto-sans-cjk-subset-fonts-all-2.004-1.fc39.noarch.rpm /builddir/google-noto-sans-tc-fonts-2.004-1.fc39.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 823be8346cbb411d9abc6eec7023faed -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.dddvkly1:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 39 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/google-noto-sans-cjk-subset-fonts-all-2.004-1.fc39.noarch.rpm /builddir/google-noto-sans-tc-fonts-2.004-1.fc39.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: google-noto-sans-tc-fonts-2.004-1.fc39.noarch.rpm google-noto-sans-cjk-subset-fonts-all-2.004-1.fc39.noarch.rpm google-noto-sans-cjk-subset-fonts-2.004-1.fc39.src.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9z80dh4w')] checks: 31, packages: 3 google-noto-sans-cjk-subset-fonts-all.noarch: W: no-documentation google-noto-sans-tc-fonts.noarch: W: no-documentation ==================================== 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 6.5 s ==================================== Source checksums ---------------- https://github.com/googlefonts/noto-cjk/releases/download/Sans2.004/05_NotoSansCJK-SubsetOTF.zip : CHECKSUM(SHA256) this package : 2b5462a1cb87ad0e9aec44b754246c4ae865acc05b20145ef11e0936740b8af9 CHECKSUM(SHA256) upstream package : 2b5462a1cb87ad0e9aec44b754246c4ae865acc05b20145ef11e0936740b8af9 Requires -------- google-noto-sans-tc-fonts (rpmlib, GLIBC filtered): config(google-noto-sans-tc-fonts) fontpackages-filesystem google-noto-sans-cjk-subset-fonts-all (rpmlib, GLIBC filtered): google-noto-sans-hk-fonts google-noto-sans-jp-fonts google-noto-sans-kr-fonts google-noto-sans-sc-fonts google-noto-sans-tc-fonts Provides -------- google-noto-sans-tc-fonts: config(google-noto-sans-tc-fonts) font(notosanstc) font(notosanstcblack) font(notosanstcdemilight) font(notosanstclight) font(notosanstcmedium) font(notosanstcthin) google-noto-sans-tc-fonts metainfo() metainfo(org.fedoraproject.google-noto-sans-tc-fonts.metainfo.xml) google-noto-sans-cjk-subset-fonts-all: google-noto-sans-cjk-subset-fonts-all Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2181978 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: fonts, Generic, Shell-api Disabled plugins: SugarActivity, C/C++, Python, PHP, Java, Ocaml, Haskell, R, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Suggestions: 1) Always use any "install" or "cp" commands as "install -p" or "cp -p" to preserve the timestamp. 2) the package google-noto-sans-cjk-subset-fonts-all is not installable. Looks like either bug in %fontmetapkg
Please review spec file again, thanks! Spec URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-subset-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/noto-cjk-v3/google-noto-sans-cjk-subset-fonts-2.004-2.fc37.src.rpm
Created attachment 1954348 [details] The .spec file difference from Copr build 5711128 to 5725417
Copr build: https://copr.fedorainfracloud.org/coprs/build/5725417 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181978-google-noto-sans-cjk-subset-fonts/fedora-rawhide-x86_64/05725417-google-noto-sans-cjk-subset-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good now. APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/google-noto-sans-cjk-subset-fonts
Built for Fedora rawhide. URL: https://koji.fedoraproject.org/koji/buildinfo?buildID=2178203