Bug 2181994 - Review Request: python-urltools - Some functions to parse and normalize URLs
Summary: Review Request: python-urltools - Some functions to parse and normalize URLs
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2181686
TreeView+ depends on / blocked
 
Reported: 2023-03-27 07:54 UTC by Steve Traylen
Modified: 2023-09-13 14:22 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-13 14:22:59 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
The .spec file difference from Copr build 5711343 to 5725506 (1.93 KB, patch)
2023-03-29 06:51 UTC, Jakub Kadlčík 		no flags Details | Diff
View All

Description Steve Traylen 2023-03-27 07:54:45 UTC 
Spec URL: http://cern.ch/straylen/rpms/python-urltools/python-urltools.spec
SRPM URL: http://cern.ch/straylen/rpms/python-urltools/python-urltools-0.4.0-1.fc39.src.rpm
Description: Some functions to parse and normalize URLs
Fedora Account System Username: stevetraylen
Comment 1 Steve Traylen 2023-03-28 16:55:32 UTC 
I don't like the way when you import this module it down loads a file.
I think it will be better to just ship the file?

The .tld file will nearly never change anyway.
Comment 2 Steve Traylen 2023-03-29 06:44:20 UTC 
* Much happier, I learnt that the package:

   $ rpm -ql publicsuffix-list
   /usr/share/publicsuffix/effective_tld_names.dat

which is a much better source for effective_tld_names.dat.

* Also converted to pyproject macros which I could not get to work before.
Comment 3 Steve Traylen 2023-03-29 06:44:40 UTC 
[fedora-review-service-build]
Comment 4 Jakub Kadlčík 2023-03-29 06:51:16 UTC 
Created attachment 1954349 [details]
The .spec file difference from Copr build 5711343 to 5725506
Comment 5 Derek 2023-09-13 14:22:59 UTC 
python-urltools is not used by any other packages, removing this request.
Note You need to log in before you can comment on or make changes to this bug.