Bug 2182080 - Review Request: snobol4 - A port of Macro SNOBOL4
Summary: Review Request: snobol4 - A port of Macro SNOBOL4
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL: http://www.regressive.org/snobol4/csn...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-27 14:14 UTC by Tom "spot" Callaway
Modified: 2023-04-15 02:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-09 01:41:17 UTC
Type: ---
Embargoed:
loganjerry: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 5712307 to 5731300 (1.43 KB, patch)
2023-03-30 22:00 UTC, Jakub Kadlčík
no flags Details | Diff

Description Tom "spot" Callaway 2023-03-27 14:14:58 UTC
Spec URL: https://spot.fedorapeople.org/snobol4.spec
SRPM URL: https://spot.fedorapeople.org/snobol4-2.3.1-1.fc37.src.rpm
Description: 
This is a free port of the original SIL (SNOBOL4 Implementation
Language) "macro" version of SNOBOL4 (developed at Bell Labs) with the
`C' language as a target.

SNOBOL4, while known primarily as a string language excels at any task
involving symbolic manipulations.  It provides dynamic typing, garbage
collection, user data types, on the fly compilation.
Fedora Account System Username: spot
Fedora 37 scratch build: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=99193040

Comment 1 Jakub Kadlčík 2023-03-27 14:27:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5712307
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182080-snobol4/fedora-rawhide-x86_64/05712307-snobol4/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jerry James 2023-03-29 19:46:54 UTC
I will take this review.  If you have time (ha ha!), could you possibly review bug 2176933 in exchange?  It's a small python package, shouldn't be hard to review.

Comment 3 Miro Hrončok 2023-03-29 20:23:00 UTC
I came here to offer my review, happy to take the small Python package instead. Tom has recently done something useful for me, so that should keep the exchange loop closed.

Comment 4 Tom "spot" Callaway 2023-03-29 20:27:19 UTC
(In reply to Miro Hrončok from comment #3)
> I came here to offer my review, happy to take the small Python package
> instead. Tom has recently done something useful for me, so that should keep
> the exchange loop closed.

I went to go start that review in 2176933 and saw it was assigned to you before I read this comment and I was momentarily confused as to why he could need me if he had you. :D

Comment 5 Jerry James 2023-03-29 21:22:37 UTC
I don't know, Miro.  I think I was already in debt to you, so this is going to push me in deeper. :-)  For this review:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues
======
- The output from licensecheck shows files with other licenses.  These are the
  ones I see being compiled in the build log:
  BSD-3-Clause: modules/random/random.c
  BSD-4-Clause: lib/bsd/popen.c
  ISC: modules/base64/base64.c

- Nit pick: the URL could be https instead of http.  Not a requirement, just
  pointing it out.

- Nit pick: I understand we prefer to use %{build_cflags} and %{build_cxxflags}
  these days instead of %{optflags}.  Also not a requirement.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 2-Clause License", "BSD-4-Clause
     (University of California-Specific)", "Historical Permission Notice
     and Disclaimer - sell variant [generated file]", "BSD 3-Clause
     License", "ISC License", "Kevlin Henney License". 732 files have
     unknown license. Detailed output of licensecheck in
     /home/jamesjer/2182080-snobol4/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 215040 bytes in 36 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     snobol4-devel

Errrrr ... it's in there.  I'm looking at it.  Fedora-review bug?

[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.

However, regression tests are run during the build, so there is probably no
point to a separate %check script.

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: snobol4-2.3.1-1.fc39.x86_64.rpm
          snobol4-devel-2.3.1-1.fc39.x86_64.rpm
          snobol4-debuginfo-2.3.1-1.fc39.x86_64.rpm
          snobol4-debugsource-2.3.1-1.fc39.x86_64.rpm
          snobol4-2.3.1-1.fc39.src.rpm
================================================ rpmlint session starts ================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp0wfetq57')]
checks: 31, packages: 5

snobol4.spec: W: patch-not-applied Patch1: snobol4-2.3.1-configure-no-opt.patch
snobol4-devel.x86_64: W: only-non-binary-in-usr-lib
snobol4.x86_64: W: no-manual-page-for-binary sdb-2.3.1
snobol4.x86_64: W: no-manual-page-for-binary snobol4-2.3.1
snobol4.x86_64: W: no-manual-page-for-binary snopea-2.3.1
snobol4-devel.x86_64: W: no-documentation
snobol4.src: W: name-repeated-in-summary SNOBOL4
snobol4.x86_64: W: name-repeated-in-summary SNOBOL4
snobol4.spec:47: W: configure-without-libdir-spec
================= 5 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.6 s =================




Rpmlint (debuginfo)
-------------------
Checking: snobol4-debuginfo-2.3.1-1.fc39.x86_64.rpm
================================================ rpmlint session starts ================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpan3cs5jk')]
checks: 31, packages: 1

================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s =================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/base64.so retstring_free	(/usr/lib64/snobol4/2.3.1/lib/shared/base64.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so lookup_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/digest.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/digest.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so remove_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/digest.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so nmgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/digest.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/digest.so new_handle2	(/usr/lib64/snobol4/2.3.1/lib/shared/digest.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so new_handle2	(/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so lookup_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so remove_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so mgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/dirs.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/fork.so getstring	(/usr/lib64/snobol4/2.3.1/lib/shared/fork.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/fork.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/fork.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/logic.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/logic.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so getstring	(/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so new_handle2	(/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so lookup_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so remove_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so mgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/readline.so retstring_free	(/usr/lib64/snobol4/2.3.1/lib/shared/readline.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/readline.so mgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/readline.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so getstring	(/usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so nmgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so new_handle2	(/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so lookup_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so remove_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so mgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stat.so mgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/stat.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so new_handle2	(/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so lookup_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so remove_handle	(/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so mgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/stcl.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/time.so getstring	(/usr/lib64/snobol4/2.3.1/lib/shared/time.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/time.so nmgetstring	(/usr/lib64/snobol4/2.3.1/lib/shared/time.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/time.so retstring	(/usr/lib64/snobol4/2.3.1/lib/shared/time.so)
snobol4.x86_64: W: undefined-non-weak-symbol /usr/lib64/snobol4/2.3.1/lib/shared/zlib.so retstring_free	(/usr/lib64/snobol4/2.3.1/lib/shared/zlib.so)
snobol4-devel.x86_64: W: only-non-binary-in-usr-lib
snobol4.x86_64: W: no-manual-page-for-binary sdb-2.3.1
snobol4.x86_64: W: no-manual-page-for-binary snobol4-2.3.1
snobol4.x86_64: W: no-manual-page-for-binary snopea-2.3.1
snobol4-devel.x86_64: W: no-documentation
snobol4.x86_64: W: name-repeated-in-summary SNOBOL4
 4 packages and 0 specfiles checked; 0 errors, 46 warnings, 0 badness; has taken 2.4 s 



Unversioned so-files
--------------------
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/base64.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/digest.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/dirs.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/fork.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/logic.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/ndbm.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/random.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/readline.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/sprintf.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/sqlite3.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/stat.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/stcl.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/time.so
snobol4: /usr/lib64/snobol4/2.3.1/lib/shared/zlib.so

Source checksums
----------------
https://ftp.regressive.org/snobol4/snobol4-2.3.1.tar.gz :
  CHECKSUM(SHA256) this package     : 91244d67d4e29d2aadce5655bd4382ffab44c624a7ea4ad6411427f3abf17535
  CHECKSUM(SHA256) upstream package : 91244d67d4e29d2aadce5655bd4382ffab44c624a7ea4ad6411427f3abf17535


Requires
--------
snobol4 (rpmlib, GLIBC filtered):
    /usr/bin/sh
    glibc
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.3()(64bit)
    libcrypto.so.3(OPENSSL_3.0.0)(64bit)
    libgdbm_compat.so.4()(64bit)
    liblzma.so.5()(64bit)
    liblzma.so.5(XZ_5.0)(64bit)
    libm.so.6()(64bit)
    libreadline.so.8()(64bit)
    libsqlite3.so.0()(64bit)
    libssl.so.3()(64bit)
    libssl.so.3(OPENSSL_3.0.0)(64bit)
    libtcl8.6.so()(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

snobol4-devel (rpmlib, GLIBC filtered):
    snobol4(x86-64)

snobol4-debuginfo (rpmlib, GLIBC filtered):

snobol4-debugsource (rpmlib, GLIBC filtered):



Provides
--------
snobol4:
    snobol4
    snobol4(x86-64)

snobol4-devel:
    snobol4-devel
    snobol4-devel(x86-64)

snobol4-debuginfo:
    debuginfo(build-id)
    snobol4-debuginfo
    snobol4-debuginfo(x86-64)

snobol4-debugsource:
    snobol4-debugsource
    snobol4-debugsource(x86-64)



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2182080 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: PHP, SugarActivity, Java, fonts, Ocaml, Python, R, Perl, Haskell, Ruby
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 6 Tom "spot" Callaway 2023-03-30 21:55:23 UTC
New SRPM: https://spot.fedorapeople.org/snobol4-2.3.1-2.fc39.src.rpm
New SPEC: https://spot.fedorapeople.org/snobol4.spec

- fix URL to be https
- use build_cflags and build_cxxflags
- correct License tag

Comment 7 Jakub Kadlčík 2023-03-30 22:00:00 UTC
Created attachment 1954798 [details]
The .spec file difference from Copr build 5712307 to 5731300

Comment 8 Jakub Kadlčík 2023-03-30 22:00:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5731300
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182080-snobol4/fedora-rawhide-x86_64/05731300-snobol4/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Jerry James 2023-03-31 16:22:38 UTC
Looks good.  This package is APPROVED.

Comment 10 Fedora Admin user for bugzilla script actions 2023-03-31 16:45:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/snobol4

Comment 11 Fedora Update System 2023-03-31 20:31:26 UTC
FEDORA-2023-bfcb03f733 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bfcb03f733

Comment 12 Fedora Update System 2023-03-31 20:31:27 UTC
FEDORA-2023-5265f4737a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5265f4737a

Comment 13 Fedora Update System 2023-03-31 20:31:27 UTC
FEDORA-2023-42b4a1056a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-42b4a1056a

Comment 14 Fedora Update System 2023-04-01 01:34:30 UTC
FEDORA-2023-5265f4737a has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5265f4737a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2023-04-01 02:11:55 UTC
FEDORA-2023-bfcb03f733 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-bfcb03f733 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-bfcb03f733

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2023-04-01 02:17:24 UTC
FEDORA-2023-42b4a1056a has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-42b4a1056a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-42b4a1056a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2023-04-09 01:41:17 UTC
FEDORA-2023-bfcb03f733 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2023-04-09 02:37:45 UTC
FEDORA-2023-42b4a1056a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2023-04-15 02:04:16 UTC
FEDORA-2023-5265f4737a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.