Description of problem: Currently, containers-common adds the Red Hat release key to /etc/pki/rpm-gpg. This behaviour was introduced in: https://src.fedoraproject.org/rpms/containers-common/c/67fd4062 Based on the above commit, the initial purpose of this change was to automatically trust signed Red Hat images. However, its effect is that it changes the default set of trusted keys during RPM transactions. I think it's surprising to have a package about containers do this since RPM keys fall outside the scope of this package's functionality. One suggestion is to move the key to another location and have the software stack look in both /etc/pki/rpm-gpg and the new location when building its keyring. Another suggestion is to add a weak dep to the distribution-gpg-keys package, and either document that if /usr/share/distribution-gpg-keys/redhat is present, it'll be added to the container stack-specific keyring, or let users add the directory themselves in some config file. Version-Release number of selected component (if applicable): All recent versions How reproducible: Always Steps to Reproduce: 1. Install containers-common Actual results: Default global RPM keyring is modified. Expected results: Default global RPM keyring is unmodified. Additional info:
Is there a standard place to put container signing keys that are independent of RPM GPG keys?
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle. Changing version to 39.
@dwalsh WDYT?
I do not want to remove it since it would cause RHEL images to not be trusted. Could we change podman and container/image to look in a different location? Adding Valentin and Miloslav.
> However, its effect is that it changes the default set of trusted keys during RPM transactions. Back In My Days™️, I think only keys imported via `rpm --import` were used; and Yum/DNF repo configurations pointed a specific file path to trust / import via a gpgkey= directive. To my knowledge, /etc/pki/rpm-gpg was just the conventional location to place such files. Yet now, yes, all files in there are automatically imported?! https://github.com/rpm-software-management/libdnf/blob/39098f39806becdc87cf93e03a49ae89a33e7ede/libdnf/dnf-transaction.cpp#L1075 --- c/image doesn’t care, policy.json can point at any path, as long as all consumers are allowed to read that file. The linked commit already shows where to adjust that. So that can point somewhere in /usr/share, or in /etc, maybe /usr/share/containers, /etc/containers, /etc/pki/containers. I’m sure the Fedora packaging committee has opinions; I don’t care to express a preference. (I would note that I’m mildly unhappy about containers-common taking on the responsibility to distribute Red Hat’s keys… as well as about the idea of relying on a distribution-gpg-keys with a single human maintainer. Not that I know what would a good process actually look like, and of course as long as containers-common distributes a policy.json, distributing the relevant keys is not any more responsibility.)
This message is a reminder that Fedora Linux 39 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 39 on 2024-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '39'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 39 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
Fedora Linux 39 entered end-of-life (EOL) status on 2024-11-26. Fedora Linux 39 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora Linux please feel free to reopen this bug against that version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see the version field. If you are unable to reopen this bug, please file a new report against an active release. Thank you for reporting this bug and we are sorry it could not be fixed.