Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Math-Stats.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Math-Stats-0.9.0-0.1.beta3.src.rpm Description: Package to calculate statistical parameters of numerical arrays of data. The data can be in a simple numerical array, or in a cummulative numerical array. A cummulative array, has the value as the index and the number of repeats as the value for the array item, e.g. $data = array(3=>4, 2.3=>5, 1.25=>6, 0.5=>3).
[jwhiter@dhcp59-101 ~]$ rpmlint /home/jwhiter/redhat/RPMS/noarch/php-pear-Math-Stats-0.9.0-0.1.beta3.noarch.rpm W: php-pear-Math-Stats non-standard-dir-in-usr doc [jwhiter@dhcp59-101 ~]$ I'm assuming thats ok since you are putting the doc into a php-pear doc directory. Everything else looks good. As this is my first review I'm going to wait on feedback for the rpmlint error before approving this.
Ok everything looks good, here is my review check list. review check: -rpmlint output: [jwhiter@dhcp59-101 ~]$ rpmlint /home/jwhiter/redhat/RPMS/noarch/php-pear-Math-Stats-0.9.0-0.1.beta3.noarch.rpm [jwhiter@dhcp59-101 ~]$ - package is named according to the php package naming guidelines - spec file name matches %{name} - package meets package guidlines - package is licensed with appropriate open source license - license feild matches actual license - license is in %doc - license file is written in american english - spec file is legible - sources match upstream ffc0b653e5e2985113262a5299ebe69b Math_Stats-0.9.0beta3.tgz - package successfully compiled on fc6 x86_64 box - buildrequires makes sense and everything required is present - no locales - no shared libraries - not relocatable - owns all directories it creates - no duplicates in %files - permissions set properly - contains a %clean section - uses macros consistently - contains code - no large documentation - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no dynamic libraries provided by package, no need for -devel package - no .la files - not a GUI application - does not own files or directories owned by other packages sorry about the rpmlint problem before, I hadn't run fedora-buildrpmtree on the box I was building on.
chris - since you haven't sponsored me yet, is this supposed to be assigned to me? If it is, am i supposed to move this into FE-ACCEPT? If not what do you need me to do?
The bug should still block FE-NEW and be assigned to nobody (or whatever the default asignee is)
Review: * rpmlint is quiet (and that's good ;-)) * I have no objection to names of package and spec file * sources match upstream (md5: ffc0b653e5e2985113262a5299ebe69b) * package is licensed under PHP open-source compatible license which is properly mentioned in License field and included in %doc * no problems with building on fc6/x86_64 * package isn't designed to be relocatable * %post and %postun are present (like in a template) * package meets every Guidelines it should * everything looks very similar to a php-pear spec template and everything is good :) There's even no need to set a FE-REVIEW blocker. Me and everything else can say that: ___________ < Approved! > ----------- \ ,__, \ (oo)____ (__) )\ ||--|| *
- Imported into CVS - Entry added to owners.list - Tagged and Built on devel - FC-5/6 branch request made Thanks for the review!
Package Change Request ====================== Package Name: php-pear-Math-Stats New Branches: EL-5