Spec URL: http://cern.ch/straylen/rpms/oidc-agent/oidc-agent.spec SRPM URL: http://cern.ch/straylen/rpms/oidc-agent/oidc-agent-4.5.1-1.fc39.src.rpm Description: Command-line tool for obtaining OpenID Connect access tokens Fedora Account System Username: stevetraylen This is re-submission of oidc-agent that was originally submitted here: https://bugzilla.redhat.com/show_bug.cgi?id=1997994 User vokac has agreed that I can take over the submission of oidc-agent. I will follow up shortly with the items from that review that have and have not been resolved.
From #1997994 * Dynamic requires are now relied upon - no explicit requires unless needed. * Bundling * Now using a system builds of liblist (clib-list) * Now using a system build of cjson * mustache is no longer needed as desktop package is removed. * src/oidc-gen/qr.c is still based on another lib but is not the whole lib. * windows binarys have gone , I guess upstream. * /etc/X11/Xsession.d has gone because the desktop ( useless on wayland anyway ) * Package now owns /etc/oidc-agent * all %defattr have gone. * src/oidc-prompt/html/static/css/lib/bootstrap.min.css has gone since desktop package gone. * BuildRoot gone. * The -p for install has been added upstream. * license file is now only liboidc-agent package which is required by all packages. * libsodium-static is no longer used or linked to. * Files inside %{_datadir}/bash-completion/completions/ are now explictly owned rather than duplicating the directory ownership. * Source URL is better (%forge macros) * This spec file is soly for Fedora and in time EPEL - it will not track upstream spec file. * %(__rm), %{_sed) replace with rm , sed. * suse conditionals all gone rpmlint is now clean. * Todo * src/oidc-prompt/html/static/css/lib/bootstrap.min.css should be removed from source in %prep (if still there) * Couple of patches need some work. * Understand what happened between F38 and F38 with respect to directories for created objects.
*** Bug 1997994 has been marked as a duplicate of this bug. ***
#2163447 is desktop dependency for mustach - re-add desktop after available.
Building without GUI component which allows us to build with out some of the harder dependencies. [fedora-review-service-build] Spec URL: http://cern.ch/straylen/rpms/oidc-agent/oidc-agent.spec SRPM URL: http://cern.ch/straylen/rpms/oidc-agent/oidc-agent-4.5.1-1.fc39.src.rpm * the parallel make is now fixed with respect to object creation. * src/oidc-prompt/html/static/css/lib/bootstrap.min.css is now being removed in %prep state to ensure it is not being used. Ready for a review.
[fedora-review-service-build]
We have worked on further removing code used from others by moving it into separate packages. I.e. you could remove certain parts of the code, when installing the required dependencies: cjson: (part of fedora) rm -rf lib/cJSON export USE_CJSON_SO=1 spec file: BuildRequires: cjson-devel or BuildRequires: cJSON-devel clibs/list: (part of fedora) rm -rf lib/list export USE_LIST_SO=1 spec file: BuildRequires: clibs-list-devel [..] %package -n oidc-agent-cli Requires: clibs-list [..] %package -n liboidc-agent4 Requires: clibs-list [..] %package -n oidc-agent-desktop Requires: clibs-list mustach: (packaging approved, but not yet part of fedora: https://bugzilla.redhat.com/show_bug.cgi?id=2163447) rm -rf src/oidc-prompt/mustache export USE_MUSTACHE_SO=1 spec file: BuildRequires: mustach-lib-cjson-devel [..] %package -n oidc-agent-desktop Requires: mustach-lib-cjson Only for oidc-agent-desktop: simple.css (replaces dependency on bootswatch) Package submitted for review: https://bugzilla.redhat.com/show_bug.cgi?id=2189488 rm -rf src/oidc-prompt/html/static/css/lib/bootstrap.min.css spec file: BuildRequires: simple.css I'm not 100% sure whether I forgot a runtime dependency, but I can't test this sufficiently well right now. I'll be AFK for 4 weeks, so I wanted to send this update nevertheless. Best, Marcus.