Spec URL: https://download.copr.fedorainfracloud.org/results/sshil/fonts-compare/fedora-37-x86_64/05727164-fonts-compare/fonts-compare.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sshil/fonts-compare/fedora-37-x86_64/05727164-fonts-compare/fonts-compare-1.2.6-1.fc37.src.rpm Description: Fonts-Compare is a project that allows users to compare different fonts of a specific language, based on their FontWeight, FontSize, and FontStyle. The project is designed to help users choose the best font for their needs, whether they are creating a document or designing a website. The project uses the Gtk4 toolkit and requires the installation of font packages for the specific languages users wish to work with. The project is available on Fedora Copr and can also be installed by downloading the Git repository and installing the necessary dependencies. Fedora Account System Username:sshil
Copr build: https://copr.fedorainfracloud.org/coprs/build/5728843 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182963-fonts-compare/fedora-rawhide-x86_64/05728843-fonts-compare/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks @jkadlcik Here is the updated version of spec and srpm below Spec URL:https://download.copr.fedorainfracloud.org/results/sshil/fonts-compare/fedora-37-x86_64/05728940-fonts-compare/fonts-compare.spec SRPM URL:https://download.copr.fedorainfracloud.org/results/sshil/fonts-compare/fedora-37-x86_64/05728940-fonts-compare/fonts-compare-1.2.6-2.fc37.src.rpm
Created attachment 1954601 [details] The .spec file difference from Copr build 5728843 to 5728977
Copr build: https://copr.fedorainfracloud.org/coprs/build/5728977 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182963-fonts-compare/fedora-rawhide-x86_64/05728977-fonts-compare/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed these issues generated by fedora-review: fonts-compare.noarch: E: wrong-icon-size /usr/share/icons/hicolor/16x16/apps/fonts-compare.png expected: 16x16 actual: 128x128 fonts-compare.noarch: E: wrong-icon-size /usr/share/icons/hicolor/22x22/apps/fonts-compare.png expected: 22x22 actual: 128x128 fonts-compare.noarch: E: wrong-icon-size /usr/share/icons/hicolor/256x256/apps/fonts-compare.png expected: 256x256 actual: 128x128 fonts-compare.noarch: E: wrong-icon-size /usr/share/icons/hicolor/32x32/apps/fonts-compare.png expected: 32x32 actual: 128x128 fonts-compare.noarch: E: wrong-icon-size /usr/share/icons/hicolor/48x48/apps/fonts-compare.png expected: 48x48 actual: 128x128 fonts-compare.noarch: E: wrong-icon-size /usr/share/icons/hicolor/64x64/apps/fonts-compare.png expected: 64x64 actual: 128x128 Also updated spec file Spec URL: https://download.copr.fedorainfracloud.org/results/sshil/fonts-compare/fedora-37-x86_64/05729647-fonts-compare/fonts-compare.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sshil/fonts-compare/fedora-37-x86_64/05729647-fonts-compare/fonts-compare-1.2.7-1.fc37.src.rpm
Created attachment 1954667 [details] The .spec file difference from Copr build 5728977 to 5729772
Copr build: https://copr.fedorainfracloud.org/coprs/build/5729772 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182963-fonts-compare/fedora-rawhide-x86_64/05729772-fonts-compare/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/fonts-compare/licensecheck.txt I see https://github.com/sudipshil9862/fonts-compare/blob/main/LICENSE says "MIT" license but you wrote in SPEC "GPLv3" which is wrong then [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/fonts-compare Why you install like this install -D -m 755 fonts_compare.py %{buildroot}%{_datadir}/%{name}/fonts_compare.py and not just install -D -m 755 fonts_compare.py %{buildroot}%{_datadir}/%{name}/ Also, why not write a build-system for your project like using autotools or Cmake? [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/fonts-compare, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/scalable, /usr/share/icons/hicolor/16x16 Same applies as suggested in above point. Why not write like install -D -m 644 logo/16x16/fonts-compare.png %{buildroot}/%{_datadir}/icons/hicolor/16x16/apps/ [!] rpmlint output says fonts-compare.noarch: W: no-manual-page-for-binary fonts-compare ==> This is okay but maybe you want to write man-page for your tool in upstream fonts-compare.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13) ==> You can check this in your SPEC editor fonts-compare.noarch: E: description-line-too-long Fonts-Compare is a tool that enables individuals to compare various fonts in a particular language. fonts-compare.src: E: description-line-too-long Fonts-Compare is a tool that enables individuals to compare various fonts in a particular language. ==> split description line in 2 lines wrapping per line 80 characters
Spec URL: https://sshil.fedorapeople.org/reviews/fonts-compare/fonts-compare.spec SRPM URL: https://sshil.fedorapeople.org/reviews/fonts-compare/fonts-compare-1.3.0-1.fc37.src.rpm - licence update with MIT - some core spec file issues fixed and updated - Package must own all directories that it creates, this issue fixed - README.md update with instruction and commands Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99751924
Created attachment 1956610 [details] The .spec file difference from Copr build 5729772 to 5766508
Copr build: https://copr.fedorainfracloud.org/coprs/build/5766508 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182963-fonts-compare/fedora-rawhide-x86_64/05766508-fonts-compare/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://sshil.fedorapeople.org/reviews/fonts-compare/fonts-compare.spec SRPM URL: https://sshil.fedorapeople.org/reviews/fonts-compare/fonts-compare-1.3.1-1.fc37.src.rpm - LICENSE changed to GPL-2.0+ - little change in README Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99767637
Created attachment 1956651 [details] The .spec file difference from Copr build 5766508 to 5767429
Copr build: https://copr.fedorainfracloud.org/coprs/build/5767429 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182963-fonts-compare/fedora-rawhide-x86_64/05767429-fonts-compare/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
1) The license name GPL-2.0+ is incorrect. It should be GPL-2.0-or-later 2) Instead of %setup use %autosetup 3) Why logo directory is created? there is nothing installed in that directory
I have approved this anyhow. Fix above issues before adding package in Fedora.
Spec URL: https://sshil.fedorapeople.org/reviews/fonts-compare/fonts-compare.spec SRPM URL: https://sshil.fedorapeople.org/reviews/fonts-compare/fonts-compare-1.3.1-2.fc37.src.rpm LICENSE is GPL-2.0-or-later now, %autosetup, mkdir -p %{buildroot}%{_datadir}/%{name}/ added, removed unnecessary directory that created by spec Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99786323
The Pagure repository was created at https://src.fedoraproject.org/rpms/fonts-compare
FEDORA-2023-1ff348eb72 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ff348eb72
FEDORA-2023-68c3069b96 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-68c3069b96
FEDORA-2023-63df8aa409 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-63df8aa409
FEDORA-2023-63df8aa409 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-63df8aa409 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-1ff348eb72 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1ff348eb72 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1ff348eb72 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-68c3069b96 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-68c3069b96 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-68c3069b96 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-63df8aa409 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-1ff348eb72 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-68c3069b96 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-36ed08150f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-36ed08150f
FEDORA-EPEL-2023-b14eae14c1 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-b14eae14c1
FEDORA-EPEL-2023-36ed08150f has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-36ed08150f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-b14eae14c1 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-b14eae14c1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-66f8b6a57a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-66f8b6a57a
FEDORA-2023-f93e80f957 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f93e80f957
FEDORA-2023-1d867ea22b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1d867ea22b
FEDORA-2023-f93e80f957 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f93e80f957` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f93e80f957 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-1d867ea22b has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-1d867ea22b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-1d867ea22b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-66f8b6a57a has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-66f8b6a57a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-66f8b6a57a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-66f8b6a57a has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-1d867ea22b has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-f93e80f957 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.