Bug 2183334 - Review Request: rust-toml_datetime - TOML-compatible datetime type
Summary: Review Request: rust-toml_datetime - TOML-compatible datetime type
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Felix Wang
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/toml_datetime
Whiteboard:
Depends On:
Blocks: 2136899 2162586
TreeView+ depends on / blocked
 
Reported: 2023-03-30 21:51 UTC by Fabio Valentini
Modified: 2023-04-03 22:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-03 22:01:41 UTC
Type: ---
Embargoed:
topazus: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-03-30 21:51:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-toml_datetime.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-toml_datetime-0.6.1-1.fc38.src.rpm

Description:
A TOML-compatible datetime type.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=99336531

Comment 1 Jakub Kadlčík 2023-03-30 21:59:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5731290
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183334-rust-toml_datetime/fedora-rawhide-x86_64/05731290-rust-toml_datetime/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Felix Wang 2023-04-02 00:08:07 UTC
The spec file was generated with rust2rpm, and Copr build successfully. It seems good to me, so I approved the package.

Comment 3 Fabio Valentini 2023-04-02 08:21:20 UTC
Thanks! You will need to change the "Assignee" field of the bug to yourself (by clicking "Take"), as well, for the review to be valid.

I see you're interested in getting the "toml" crate updated (going by the PR you submitted)? I have the update to the latest version prepared, but this package and two more needed to be reviewed (serde_spanned and winnow).

Comment 4 Felix Wang 2023-04-02 08:47:32 UTC
Sorry, I missed with the change of Assignee field. Yes, I'm interested in rust-packaging, I just became a packager not long ago and take some rpm packages which is not about rust. When I try to build an interested application written by rust, it may need to build several nonexistent rust dependencies that need review requests and some existing rust packages that need to be updated, which the rust-packaging process is much more alleviated by rust2rpm tool though, I still give up.

Comment 5 Fedora Admin user for bugzilla script actions 2023-04-02 14:11:14 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-toml_datetime

Comment 6 Fabio Valentini 2023-04-02 14:12:23 UTC
> When I try to build an interested application written by rust [...], I still give up.

What project were you interested in packaging? Maybe there's something other packagers can do to help make it happen, you don't need to do everything alone.

Comment 7 Fedora Update System 2023-04-03 21:59:41 UTC
FEDORA-2023-819f0f3a80 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-819f0f3a80

Comment 8 Fedora Update System 2023-04-03 22:01:41 UTC
FEDORA-2023-819f0f3a80 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.