Spec URL: https://dghubble.fedorapeople.org/golang-github-containerd-btrfs-2.spec SRPM URL: https://dghubble.fedorapeople.org/golang-github-containerd-btrfs-2-2.0.0-1.fc39.src.rpm Description: Btrfs bindings for Go Fedora Account System Username: dghubble We're working on creating packages to be able to build containerd v1.7.0. See https://src.fedoraproject.org/rpms/containerd/pull-request/13#comment-135159 Created this review request by following https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_Existing_Contributors/
I'll take this review :). Here are some initial comments: > %gometa -f Remove the `-f` flag and just use plain `%gometa`. The `-f` flag disables building/testing the package on i386 which we don't want in this case. We're only using this flag for new packages that don't have dependents. containerd is still built for i386. The package only contains a btrfs-test binary which isn't useful for end users, so I wouldn't ship it. You'll have to add ``` %global debug_package %{nil} ``` to the beginning of the specfile (right above %bcond_without check is a standard place, but it doesn't particularly matter) and make the changes listed below. > %build > for cmd in cmd/* ; do > %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > done Remove the entire %build section. We don't want to ship the btrfs-test binary. > > %install > %gopkginstall > install -m 0755 -vd %{buildroot}%{_bindir} > install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ Remove the two install invocations. We're not installing any binaries. > %files > %license LICENSE > %doc README.md > %{_bindir}/* Remove this %files section.
Initial fixes should be there, and updated the links to use fedorapeople.org
[fedora-review-service-build]
Please rebuild the SRPM and upload it again
Local mockbuild works and I've uploaded the SRPM.
This package was generated using go2rpm, which simplifies the review. Normally, I'd go through the full template generated by the `fedora-review` tool. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors - [x] The package runs tests in %check - [x] The latest version is packaged. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. I'll send you a separate email later with instructions since this is your first Package Review ticket. Thanks!
> I'll send you a separate email later with instructions since this is your first Package Review ticket. Sent!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-containerd-btrfs-2
FEDORA-2023-0416784055 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0416784055
FEDORA-2023-0416784055 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.