RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2183447 - Crash when verifying a client certificate
Summary: Crash when verifying a client certificate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: freeradius
Version: 9.1
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Antonio Torres
QA Contact: Michal Polovka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-03-31 07:41 UTC by Renaud Métrich
Modified: 2023-11-07 09:48 UTC (History)
5 users (show)

Fixed In Version: freeradius-3.0.21-38.el9
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-07 08:33:01 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FREEIPA-9629 0 None None None 2023-03-31 07:44:58 UTC
Red Hat Issue Tracker RHELPLAN-153711 0 None None None 2023-03-31 07:45:03 UTC
Red Hat Product Errata RHBA-2023:6443 0 None None None 2023-11-07 08:33:03 UTC

Description Renaud Métrich 2023-03-31 07:41:59 UTC
Description of problem:

We have a customer encountering a crash of radiusd when `cbtls_verity()` executes:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
(gdb) f 6
#6  0x000055ce87cc8992 in cbtls_verify (ok=1, ctx=0x55ce894cb7b0) at src/main/tls.c:3007
3007		RDEBUG2("(TLS) Creating attributes from %s certificate", cert_names[lookup]);
(gdb) p err
$1 = 0
(gdb) p depth
$2 = 3
(gdb) p lookup
$3 = 3
(gdb) p cert_names
$4 = {0x55ce87cda04f "client", 0x55ce87cd5871 "server"}
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

Here above, we can see that "lookup" is out of range, it should be only 0 or 1, but is 3 here.
"lookup" is initially set to "depth" variable, which doesn't make sense to me since there was no error with the certificate:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
2936 int cbtls_verify(int ok, X509_STORE_CTX *ctx)
2937 {
 :
2970         client_cert = X509_STORE_CTX_get_current_cert(ctx);
2971         err = X509_STORE_CTX_get_error(ctx);
2972         depth = X509_STORE_CTX_get_error_depth(ctx);
2973 
2974 HERE>>  lookup = depth;
2975 
2976         /*
2977          *      Log client/issuing cert.  If there's an error, log
2978          *      issuing cert.
2979          */
2980         if ((lookup > 1) && !my_ok) lookup = 1;
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

I don't understand the logic behind setting "lookup" to "depth" at all, IMHO it should be set to 0 (since it's a client cert here).
Upstream v3.0.x branch has exact same code (which disappeared with more recent branches).

Version-Release number of selected component (if applicable):

freeradius-3.0.21-34.el9

How reproducible:

Always on customer system when doing when doing EAP-TLS

Additional info:

Coredump available in initial customer case if needed.

Comment 17 aland 2023-05-26 20:02:17 UTC
See the v3.0.x branch.  All uses of cert_attr_names[FR_TLS_ISSUER][lookup] are protected by a check: if (lookup <= 1) ...

Comment 26 errata-xmlrpc 2023-11-07 08:33:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (freeradius bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6443


Note You need to log in before you can comment on or make changes to this bug.