Spec URL: https://decathorpe.fedorapeople.org/rust-clap_mangen.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-clap_mangen-0.2.10-1.fc38.src.rpm Description: A manpage generator for clap. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=99404366
Copr build: https://copr.fedorainfracloud.org/coprs/build/5735589 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183742-rust-clap_mangen/fedora-rawhide-x86_64/05735589-rust-clap_mangen/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Approved. > # * missing dev-dependencies: snapbox Good thing: tests currently do not require snapbox. Bad thing: that's because `include.workspace = true` in Cargo.toml resolves to the list from https://github.com/clap-rs/clap/blob/0.2.10/Cargo.toml#L17 which does not include 'tests/**/*' ¯\_(ツ)_/¯ There are no tests to run, but if there were any, they would still require snapbox. With that in mind, `%bcond_with check` seems fine to me. You might want to check with the clap upstream if the omission was intentional though.
Thanks for the review! And good catch. I will update the comment before import.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap_mangen
FEDORA-2023-bf649844fc has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bf649844fc
FEDORA-2023-bf649844fc has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.