Spec URL: https://download.copr.fedorainfracloud.org/results/@designsuite/gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05737622-gnome-shell-extension-screen-autorotate/gnome-shell-extension-screen-autorotate.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@designsuite/gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05737622-gnome-shell-extension-screen-autorotate/gnome-shell-extension-screen-autorotate-10-1.fc39.src.rpm Description: A GNOME extension to enable screen rotation regardless of touch mode. This extension uses Mutter's D-Bus API, so it works on both X11 and Wayland. Fedora Account System Username:luya
Link for review file: https://download.copr.fedorainfracloud.org/results/@designsuite/gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05737622-gnome-shell-extension-screen-autorotate/fedora-review/review.txt
Copr build: https://copr.fedorainfracloud.org/coprs/build/5737628 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183901-gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05737628-gnome-shell-extension-screen-autorotate/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking, could you take https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2184590 in exchange?
(In reply to Sandro Mani from comment #3) > Taking, could you take > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2184590 in exchange? Done.
- Why BuildRequires: gettext? - License should be GPL-3.0-or-later - Use cp -a or cp -p -r in %install to preserve timestamps Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2 GNU General Public License v3.0 or later", "GNU General Public License v3.0 or later". 5 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/gnome-shell-extension- screen-autorotate/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: gnome-shell-extension-screen-autorotate-10-1.fc39.noarch.rpm gnome-shell-extension-screen-autorotate-10-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp818_n_5n')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/shyzus/gnome-shell-extension-screen-autorotate/archive/v10/gnome-shell-extension-screen-autorotate-10.tar.gz : CHECKSUM(SHA256) this package : aff6cb7fb8a229aae9f2012734b2d9393a4c61a6a74dcf2a8005cf609ee067f6 CHECKSUM(SHA256) upstream package : aff6cb7fb8a229aae9f2012734b2d9393a4c61a6a74dcf2a8005cf609ee067f6 Requires -------- gnome-shell-extension-screen-autorotate (rpmlib, GLIBC filtered): gnome-shell iio-sensor-proxy Provides -------- gnome-shell-extension-screen-autorotate: gnome-shell-extension-screen-autorotate screen-rotate Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name gnome-shell-extension-screen-autorotate --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Haskell, Ocaml, Perl, Python, R, PHP, fonts, SugarActivity, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Here is the update with the following fix: - Dropped BuildRequires: gettext - Fix license - use cp -p -f for the preservation of timestamps SPEC: https://download.copr.fedorainfracloud.org/results/@designsuite/gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05757919-gnome-shell-extension-screen-autorotate/gnome-shell-extension-screen-autorotate.spec SRPM: https://download.copr.fedorainfracloud.org/results/@designsuite/gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05757919-gnome-shell-extension-screen-autorotate/gnome-shell-extension-screen-autorotate-10-1.fc39.src.rpm
Created attachment 1956304 [details] The .spec file difference from Copr build 5737628 to 5757924
Copr build: https://copr.fedorainfracloud.org/coprs/build/5757924 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183901-gnome-shell-extension-screen-autorotate/fedora-rawhide-x86_64/05757924-gnome-shell-extension-screen-autorotate/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM, approved!
Thank you!
The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-screen-autorotate
FEDORA-EPEL-2023-af25406b74 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-af25406b74
FEDORA-2023-6fbcb66b74 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6fbcb66b74
FEDORA-2023-53933b4440 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-53933b4440
FEDORA-2023-53933b4440 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-53933b4440 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-6fbcb66b74 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6fbcb66b74 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6fbcb66b74 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-af25406b74 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-af25406b74 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-6fbcb66b74 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-53933b4440 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-af25406b74 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.