Spec URL: https://gotmax23.fedorapeople.org/reviews/rust-associative-cache/rust-associative-cache.spec SRPM URL: https://gotmax23.fedorapeople.org/reviews/rust-associative-cache/rust-associative-cache-1.0.1-1.fc37.src.rpm Description: A generic N-way associative cache with fixed-size capacity and random or least recently used (LRU) replacement. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99477591
Copr build: https://copr.fedorainfracloud.org/coprs/build/5738673 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184004-rust-associative-cache/fedora-rawhide-x86_64/05738673-rust-associative-cache/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests are disabled with link to upstream bug report) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora ? license files are included with %license in %files (upstream unresponsive, standard license files for Apache-2.0 and MIT included manually) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Non-blocking issues, please address them before importing the package: 1. Exclude some CI files from the package, i.e. by adding this to Cargo.toml's [package] table: exclude = ["/ci/", "/azure-pipelines.yml"] 2. Include a link the upstream bug report about the 32-bit test failures in the spec file: https://github.com/fitzgen/associative-cache/issues/15 3. If you can, provide more details than "Doctests are broken". It looks like many of them are not compilable / runnable, but not annotated with "ignore", i.e. like this: ```ignore this is not valid rust code ``` 4. You can de-duplicate the license files. Right now they are installed twice (once in %crate_instdir, and once in %_licensedir). You can pass an absolute path to the %license macro instead so the files are not copied to %_licensedir, i.e. %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT
> test suite is run and all unit tests pass (tests are disabled with link to upstream bug report) Well, the tests are only disabled on 32-bit arches. They're enabled everywhere else. > Non-blocking issues, please address them before importing the package: How's https://git.sr.ht/~gotmax23/fedora-python-orjson/commit/20d759663a3d42f601819722b6bcceb437cc13d6 ?
Perfect, thanks. You could have used "rust2rpm -p" to generate the "exclude" patch, but this is fine :)
> You could have used "rust2rpm -p" to generate the "exclude" patch Yeah, but then I'd have to reapply my local modifications, wouldn't I?
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-associative-cache
FEDORA-2023-d08e6ddfb4 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d08e6ddfb4
FEDORA-2023-d08e6ddfb4 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2
FEDORA-2023-02616d2cc2 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02616d2cc2
FEDORA-2023-8aa6dbb1df has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-534a134bb2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8aa6dbb1df \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.